New issue
Advanced search Search tips

Issue 655729 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug



Sign in to add a comment

[Remoting Android] Telemetry should report version number

Project Member Reported by yuweih@chromium.org, Oct 13 2016 
Currently the version number is missing and we got empty version for M53 release.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f

commit c2be2f19ba1f97e8f47c1cde42593238e8b6a37f
Author: yuweih <yuweih@chromium.org>
Date: Thu Oct 13 20:22:05 2016

[Remoting Android] Log app version for telemetry

This CL makes the telemetry logger log the app version.

BUG= 655729 

Review-Url: https://codereview.chromium.org/2418883002
Cr-Commit-Position: refs/heads/master@{#425142}

[modify] https://crrev.com/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f/remoting/base/BUILD.gn
[modify] https://crrev.com/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f/remoting/base/chromoting_event.cc
[modify] https://crrev.com/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f/remoting/base/chromoting_event.h

Comment 2 by yuweih@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)

Comment 3 by yuweih@chromium.org, Oct 14 2016

Labels: Merge-Request-55
This bug will only affect the Chrome Remote Desktop Android client and will not affect the Chrome browser.

Comment 4 by dimu@chromium.org, Oct 14 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 14 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae06684dcaf75332984db2528ee4e5c51c8d688

commit aae06684dcaf75332984db2528ee4e5c51c8d688
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Oct 14 18:02:24 2016

[Remoting Android] Log app version for telemetry

This CL makes the telemetry logger log the app version.

BUG= 655729 

Review-Url: https://codereview.chromium.org/2418883002
Cr-Commit-Position: refs/heads/master@{#425142}
(cherry picked from commit c2be2f19ba1f97e8f47c1cde42593238e8b6a37f)

Review URL: https://codereview.chromium.org/2420103003 .

Cr-Commit-Position: refs/branch-heads/2883@{#112}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/BUILD.gn
[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/chromoting_event.cc
[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/chromoting_event.h

Comment 6 by jamiewa...@chromium.org, Oct 14 2016

Labels: M-55
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae06684dcaf75332984db2528ee4e5c51c8d688

commit aae06684dcaf75332984db2528ee4e5c51c8d688
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Oct 14 18:02:24 2016

[Remoting Android] Log app version for telemetry

This CL makes the telemetry logger log the app version.

BUG= 655729 

Review-Url: https://codereview.chromium.org/2418883002
Cr-Commit-Position: refs/heads/master@{#425142}
(cherry picked from commit c2be2f19ba1f97e8f47c1cde42593238e8b6a37f)

Review URL: https://codereview.chromium.org/2420103003 .

Cr-Commit-Position: refs/branch-heads/2883@{#112}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/BUILD.gn
[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/chromoting_event.cc
[modify] https://crrev.com/aae06684dcaf75332984db2528ee4e5c51c8d688/remoting/base/chromoting_event.h

Comment 8 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment