Merge desktop engagement service fixes to M54 |
||||||
Issue descriptionThere were a couple bugs in the measurement logic with the desktop engagement service. We'd really like to have accurate metrics available on higher channels in order to determine whether or not getting default browser / pinned states makes a difference to user engagement. We are running new first install promos with M54, so it would be good to have it there to get good numbers during this release. A CL with the necessary code (against M54) is available here: https://codereview.chromium.org/2412133002/
,
Oct 14 2016
,
Oct 18 2016
Ping?
,
Oct 18 2016
M54 is already in Stable (deployed to 5% of Win users). We are taking only CRITICAL merges. Could you please confirm the following. 1. Is this change baked/verified in Canary and safe to merge? 2. Any impact on Stability/Performance/enterprise users? 3. How feasible is the revert in case of any breakage?
,
Oct 18 2016
Sounds like we missed the boat and should just wait for M55. I don't think this warrants a stable merge.
,
Oct 18 2016
Thanks for confirmation.Looping to appropriate owners.
,
Oct 18 2016
,
Oct 19 2016
Okay, closing this. (Still not sure why M54 went out a week before the scheduled date on the chromepmo calendar?) No need to merge this to M55, as the code is already there. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dimu@chromium.org
, Oct 14 2016