New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655666 link

Starred by 7 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

upgrade fleet to java 1.8

Project Member Reported by stip@chromium.org, Oct 13 2016

Issue description

With the android N SDK, the cronet javadoc prints out many warnings:

warning: something.jar(Something.class): major version 52 is newer than 51, the highest major version supported by this compiler.
  It is recommended that the compiler be upgraded.

Since components/cronet/tools/generate_javadoc.py fails on warnings, this fails cronet builds.
 

Comment 1 by mge...@chromium.org, Oct 18 2016

Owner: mge...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by mge...@chromium.org, Oct 18 2016

Components: Infra>Client>Android
Owner: ----
Status: Untriaged (was: Assigned)
I looked up the error and it looks like it means that something.jar, which is imported by Something.class, was compiled with a newer compiler than the one currently being used. If I'm understanding this correctly, it would have to be fixed by using a newer Java compiler on the bots. (I tried patching in the SDK roll locally and couldn't repro.) Adding the infra component since I don't think we can fix the compiler situation on our end, and we need to fail on warnings to keep our javadoc well-formed.

For reference, here's the full wording of one of the warnings from the trybot run:
  [javadoc] warning: /b/c/b/android_cronet/src/third_party/android_tools/sdk/platforms/android-24/android.jar(android/annotation/SuppressLint.class): major version 52 is newer than 51, the highest major version supported by this compiler.
  [javadoc]   It is recommended that the compiler be upgraded.

Comment 3 by stip@chromium.org, Oct 20 2016

Cc: jbudorick@chromium.org
Status: Available (was: Untriaged)
Summary: upgrade fleet to java 1.8 (was: fix cronet javadoc after N SDK changes)
I just ran into this on my dev machine after syncing today.

Comment 5 by sanfin@chromium.org, Oct 27 2016

Cc: sanfin@chromium.org
Should http://www.chromium.org/developers/how-tos/android-build-instructions be updated as well?
Currently have "Make also sure that OpenJDK 1.7 is selected as default:".
Mergedinto: 662467
Status: Duplicate (was: Available)
Tracking progress in a newer bug: # 662467

Comment 8 by pdk...@gmail.com, Jan 11 2017

Unfortunately the other bug is secret. Since it doesn't seem possible to install OpenJDK 1.8 on Ubuntu 14.04, I'm not sure what to do, if anything. Does Chrome for Android compile with Oracle Java? I assume yes.
https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa is one option for OpenJDK 1.8 on Ubuntu 14.04

Comment 10 by pdk...@gmail.com, Jan 12 2017

Thanks.

Sign in to add a comment