Media controls overflow stay visible when window is resized. |
||||||||
Issue descriptionSee https://bugs.chromium.org/p/chromium/issues/detail?id=638807#c35 """ When resizing the window with overflow menu open the menu doesn't close(either the menu should close when action performed or the drag functionality should be absent when menu is in open state). """ I think we could drop the overflow menu on the window 'resize' event. It would also apply on Android when the screen is rotated which is probably good. zqzhang@, I think it's a simple addition to the current click behaviour, is that correct?
,
Oct 13 2016
I see onscroll is another possibility. Maybe also add listener for onscroll?
,
Oct 13 2016
Let's do only resize for now. Scroll sounds less obvious because you might scroll a little bit to see the overflow if the top is not visible for some reasons.
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/554c3f7915afd590dfd16fb7d1e7d0ae16defb16 commit 554c3f7915afd590dfd16fb7d1e7d0ae16defb16 Author: zqzhang <zqzhang@chromium.org> Date: Mon Oct 17 14:19:43 2016 [MediaControl] Hide overflow menu on window resize BUG= 655646 Review-Url: https://codereview.chromium.org/2417003002 Cr-Commit-Position: refs/heads/master@{#425676} [add] https://crrev.com/554c3f7915afd590dfd16fb7d1e7d0ae16defb16/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-resize.html [modify] https://crrev.com/554c3f7915afd590dfd16fb7d1e7d0ae16defb16/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp [modify] https://crrev.com/554c3f7915afd590dfd16fb7d1e7d0ae16defb16/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.h
,
Oct 17 2016
Let's see if we can merge it into M55
,
Oct 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a810dc31d6fd3cb5e154862fdaacc68855399c commit 00a810dc31d6fd3cb5e154862fdaacc68855399c Author: Zhiqiang Zhang <zqzhang@google.com> Date: Tue Oct 18 16:08:18 2016 [MediaControl] Hide overflow menu on window resize BUG= 655646 Review-Url: https://codereview.chromium.org/2417003002 Cr-Commit-Position: refs/heads/master@{#425676} (cherry picked from commit 554c3f7915afd590dfd16fb7d1e7d0ae16defb16) Review URL: https://codereview.chromium.org/2428493004 . Cr-Commit-Position: refs/branch-heads/2883@{#175} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [add] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-resize.html [modify] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp [modify] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.h
,
Oct 18 2016
,
Oct 26 2016
Tested the same on win10, mac10.11.6 and Linux14.04 using chrome version 55.0.2883.28 - Observed that the overflow menu hides on resizing the window Please find the screencast
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a810dc31d6fd3cb5e154862fdaacc68855399c commit 00a810dc31d6fd3cb5e154862fdaacc68855399c Author: Zhiqiang Zhang <zqzhang@google.com> Date: Tue Oct 18 16:08:18 2016 [MediaControl] Hide overflow menu on window resize BUG= 655646 Review-Url: https://codereview.chromium.org/2417003002 Cr-Commit-Position: refs/heads/master@{#425676} (cherry picked from commit 554c3f7915afd590dfd16fb7d1e7d0ae16defb16) Review URL: https://codereview.chromium.org/2428493004 . Cr-Commit-Position: refs/branch-heads/2883@{#175} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [add] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-resize.html [modify] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp [modify] https://crrev.com/00a810dc31d6fd3cb5e154862fdaacc68855399c/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by zqzh...@chromium.org
, Oct 13 2016