Issue 655637 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ hunyadym@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	atwilson@chromium.org █ jinzhang@chromium.org
Components:	Enterprise
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	1
Type:	Feature

Add DMServer requests query parameters to indicate whether it's a retry and why

Project Member Reported by hunyadym@chromium.org, Oct 13 2016

Issue description

Add "retry" and "lasterror" query parameters to DMServer requests.

Retry is true/false, showing if it's the first attempt to communicate with the DMServer.

Lasterror is present only if it's a retry, and it contains the network error code (https://cs.chromium.org/chromium/src/net/base/net_error_list.h) of the problem why we retried the request.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8

commit 6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8
Author: hunyadym <hunyadym@chromium.org>
Date: Thu Oct 13 14:49:38 2016

Add retry and lasterror parameters to DMServer requests.

Parameter retry=true/false is added to every request, lasterror=x is added if the request is a retry, and contains the NET_ERROR code.

BUG= 655637 

Review-Url: https://codereview.chromium.org/2419783002
Cr-Commit-Position: refs/heads/master@{#425028}

[modify] https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8/components/policy/core/common/cloud/cloud_policy_constants.cc
[modify] https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8/components/policy/core/common/cloud/cloud_policy_constants.h
[modify] https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8/components/policy/core/common/cloud/device_management_service.cc
[modify] https://crrev.com/6a65956c4809b7d161cf2bfbe25401f6dfa4a9a8/components/policy/core/common/cloud/device_management_service_unittest.cc

Comment 2 by hunyadym@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

►

Issue 655637 link

Issue metadata

Add DMServer requests query parameters to indicate whether it's a retry and why

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

Comment 1 Deleted

Comment 2 by hunyadym@chromium.org, Oct 13 2016

Comment 2 Deleted

Sign in to add a comment