New issue
Advanced search Search tips

Issue 655628 link

Starred by 1 user
Status: Assigned
Owner:
clamy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome
Pri: 1
Type: ----



Sign in to add a comment

WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit is flaky

Project Member Reported by joh...@chromium.org, Oct 13 2016 
WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit is very flaky on all bots (Android, Linux and Chrome OS; it was never enabled on Mac or Windows):
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit

The test was added in https://codereview.chromium.org/1825523002
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c3600844ea20144671602ac6508cfeb8f163f8

commit d4c3600844ea20144671602ac6508cfeb8f163f8
Author: johnme <johnme@chromium.org>
Date: Thu Oct 13 13:56:10 2016

Mark WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit flaky

NOTREECHECKS=true
NOTRY=true
BUG=655628
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2417843002
Cr-Commit-Position: refs/heads/master@{#425014}

[modify] https://crrev.com/d4c3600844ea20144671602ac6508cfeb8f163f8/content/browser/web_contents/web_contents_impl_browsertest.cc

Comment 2 by omrilio@chromium.org, Nov 1 2016

Status: Assigned (was: Untriaged)

Comment 3 by a...@chromium.org, Mar 31 2017 

This test shows a beforeunload dialog. It assumes that it will be displayed, which means it races the timer for beforeunload.

Adding a call to disable the timer should deflake it. See https://codereview.chromium.org/2780343002/ for an example.

Comment 4 by a...@chromium.org, Mar 31 2017 

OK, ignore my comment.

What's happening here on the Mac at least is that the app-modal dialogs are hard modal. Nothing is running while that dialog is up, not even the tests.

No good way around that that I can think of.

Comment 5 by a...@chromium.org, Apr 1 2017 

Actually, try the patch at https://codereview.chromium.org/2791873002 as a base.

Comment 6 by dpranke@chromium.org, Jan 22 2018

Labels: Test-Disabled
Adding Test-Disabled label, the Tests>Disabled component is going away.
►

Sign in to add a comment