New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655589 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

'add app' dialog has glitches in Harmony mode

Reported by lpa...@etouch.net, Oct 13 2016

Issue description

Chrome Version: 55.0.2883.11 (Official Build) 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}- 32/64 bit.
OS: Windows (7,8,10)
Pre-Condition: Enable 'Material Design in the rest of the browser's native UI' flag from chrome://flags.

Steps:
1. Launch chrome and navigate to https://chrome.google.com/webstore/detail/helium-backup/gpglbgbpeobllokpmeagpoagjbfknanl?utm_source=chrome-ntp-icon
2. Click on 'Add to chrome' and observe the 'Add app' overlay.

Actual: Unwanted white patch is observed in the overlay.

Expected: No such white patch should be seen.

This is a regression issue broken in M-55, will soon update the other info.

Manual Regression Range:
Good Build: 55.0.2862.0
Bad Build: 55.0.2863.0

Note: Issue is not seen in Mac and Linux OS.
 
white patch.png
175 KB View Download
Overlay.png
295 KB View Download
Labels: Needs-Bisect
There are quite a few potential causes in the changelist. I am particularly suspecting one of the ones related to filters because it seems that the broken one has a blurry edge and the non-broken one does not. We need a bisect to narrow it down to a specific patch.

In particular, https://chromium.googlesource.com/chromium/src/+/05c8461dff1ce44b6bb1d2675492078d332bd209 enables filters that would previously have been considered errors.

If that is indeed the cause, then this is may be a web site problem and not a Chrome problem.

Comment 2 by lpa...@etouch.net, Oct 14 2016

Labels: -Needs-Bisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/57da1c75484e5a3f0af03d038c43e6f23e1549e8..a6085a6a3f95d949f7b81361c901816c5e4a8dcf?pretty=fuller&n=100

Suspecting: r419203 ?

Please re-assign if your change is not the cause of this issue.

Comment 3 by est...@chromium.org, Oct 17 2016

Summary: 'add app' dialog has glitches in Harmony mode (was: Regression: Unwanted white patch is observed in the 'Add app' overlay.)
Components: -Blink>Paint UI>Browser>Bubbles Internals>Skia
Labels: -Type-Bug-Regression Type-Bug
This is not a regression. Rather it is a deliberate change that has quality problems. Next step is to for estade@ to determine if it's a bug in the change they made or if it has revealed an issue in Skia painting.

Comment 5 by est...@chromium.org, Oct 20 2016

Status: Started (was: Assigned)
yea, it's a bug --- described by  bug 656662 

shouldn't really be necessary to port the fix to m55 as the flag is non-default there.

Comment 6 by hcm@chromium.org, Oct 20 2016

Components: -Internals>Skia
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1448a03ddd9c30a6711cb485ba0614a5e41579e

commit b1448a03ddd9c30a6711cb485ba0614a5e41579e
Author: estade <estade@chromium.org>
Date: Thu Oct 20 19:52:12 2016

Harmony - Draw bubble/dialog borders just outside the content area
instead of just inside of it.

As noted in code comments, this creates minor graphical bugs at scale
factors greater than 1, but I don't think they can be addressed at the
moment.

BUG= 655589 , 656662 

Review-Url: https://chromiumcodereview.appspot.com/2439793002
Cr-Commit-Position: refs/heads/master@{#426570}

[modify] https://crrev.com/b1448a03ddd9c30a6711cb485ba0614a5e41579e/ui/views/bubble/bubble_border.cc

Comment 8 by est...@chromium.org, Oct 20 2016

Status: Fixed (was: Started)
should be fixed

Sign in to add a comment