'add app' dialog has glitches in Harmony mode
Reported by
lpa...@etouch.net,
Oct 13 2016
|
|||||||
Issue descriptionChrome Version: 55.0.2883.11 (Official Build) 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}- 32/64 bit. OS: Windows (7,8,10) Pre-Condition: Enable 'Material Design in the rest of the browser's native UI' flag from chrome://flags. Steps: 1. Launch chrome and navigate to https://chrome.google.com/webstore/detail/helium-backup/gpglbgbpeobllokpmeagpoagjbfknanl?utm_source=chrome-ntp-icon 2. Click on 'Add to chrome' and observe the 'Add app' overlay. Actual: Unwanted white patch is observed in the overlay. Expected: No such white patch should be seen. This is a regression issue broken in M-55, will soon update the other info. Manual Regression Range: Good Build: 55.0.2862.0 Bad Build: 55.0.2863.0 Note: Issue is not seen in Mac and Linux OS.
,
Oct 14 2016
Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/57da1c75484e5a3f0af03d038c43e6f23e1549e8..a6085a6a3f95d949f7b81361c901816c5e4a8dcf?pretty=fuller&n=100 Suspecting: r419203 ? Please re-assign if your change is not the cause of this issue.
,
Oct 17 2016
,
Oct 17 2016
This is not a regression. Rather it is a deliberate change that has quality problems. Next step is to for estade@ to determine if it's a bug in the change they made or if it has revealed an issue in Skia painting.
,
Oct 20 2016
yea, it's a bug --- described by bug 656662 shouldn't really be necessary to port the fix to m55 as the flag is non-default there.
,
Oct 20 2016
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1448a03ddd9c30a6711cb485ba0614a5e41579e commit b1448a03ddd9c30a6711cb485ba0614a5e41579e Author: estade <estade@chromium.org> Date: Thu Oct 20 19:52:12 2016 Harmony - Draw bubble/dialog borders just outside the content area instead of just inside of it. As noted in code comments, this creates minor graphical bugs at scale factors greater than 1, but I don't think they can be addressed at the moment. BUG= 655589 , 656662 Review-Url: https://chromiumcodereview.appspot.com/2439793002 Cr-Commit-Position: refs/heads/master@{#426570} [modify] https://crrev.com/b1448a03ddd9c30a6711cb485ba0614a5e41579e/ui/views/bubble/bubble_border.cc
,
Oct 20 2016
should be fixed |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by schenney@chromium.org
, Oct 13 2016