New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655574 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
█ tkonch...@chromium.org
█ tdander...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

checkbox's ink drop ripple misplaced in RTL

Reported by lpa...@etouch.net, Oct 13 2016 
Chrome Version: 55.0.2883.11 (Official Build) 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}-32/64 bit
OS: Windows(7,8,10)
Pre-Condition: Enable 'Material Design in the rest of the browser's native UI' flag from chrome://flags.

Steps:
1. Launch chrome and navigate to chrome://settings/addLanguage
2. Change the browser language to 'Arabic'.
3. Go to chrome://apps, click on 'remove from Chrome...' 
4. Check/uncheck the report abuse check box and observe.

Actual: Focus highlight on check/uncheck the checkbox is misplaced.

Expected: Focus highlight should proper.

This is a regression issue broken in M-54, will soon update the other info.

Manual Regression Range:
Good Build:54.0.2796.2
Bad Build: 54.0.2797.0

Note: Issue is not seen in Mac and Linux OS.

Comment 1 by lpa...@etouch.net, Oct 13 2016

Actual.mp4
248 KB View Download
Expected.mp4
245 KB View Download

Comment 2 by lpa...@etouch.net, Oct 14 2016

Labels: hasbisect
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to provide bisect info as getting bad behavior in all chromium builds:
Change log URL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2796.0..54.0.2797.0?pretty=fuller&n=10000

Suspecting: r405397 ?

Please re-assign if your change is not the cause of this issue.

Comment 3 by dbeam@chromium.org, Oct 14 2016

Cc: tdander...@chromium.org
Owner: est...@chromium.org
perhaps we need to sprinkle some base::i18n::IsRTL() calls in views::Checkbox::OnPaint() when UseMd() is true?

Comment 4 by est...@chromium.org, Oct 17 2016

Summary: checkbox's ink drop ripple misplaced in RTL (was: Regression: Focus highlight on the 'report abuse' checkbox is misplaced.)

Comment 5 by tkonch...@chromium.org, Oct 19 2016

Labels: Needs-Feedback
Unable to reproduce the issue on win10 chrome version 56.0.2894.3

 lpanse@, Could you please check the same and update the thread.

Comment 6 by lpa...@etouch.net, Oct 19 2016

Labels: -Needs-Feedback
With response to comment #5:
Re-checked the issue on latest chrome canary (56.0.2895.0), issue is still reproducible.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7723387a069c61c42d80c433b55e4e24e3e9512

commit f7723387a069c61c42d80c433b55e4e24e3e9512
Author: estade <estade@chromium.org>
Date: Thu Oct 20 21:00:41 2016

Fix checkbox ink drop ripple for RTL.

BUG= 655574 

Review-Url: https://chromiumcodereview.appspot.com/2438053002
Cr-Commit-Position: refs/heads/master@{#426593}

[modify] https://crrev.com/f7723387a069c61c42d80c433b55e4e24e3e9512/ui/views/controls/button/checkbox.cc

Comment 8 by est...@chromium.org, Oct 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment