Issue metadata
Sign in to add a comment
|
Regression : At devtools device toolbar, ‘More options’, ‘Devices’ and ‘Zoom’ drop down menu goes unresponsive.
Reported by
yfulgaon...@etouch.net,
Oct 13 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 55.0.2883.11 (Official Build) 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79} 64-bit OS: Mac(10.10.5)(10.11.5) What steps will reproduce the problem? 1. Launch chrome, open NTP and open devtools. 2. Click on ‘toggle device toolbar’ button, click on ‘Customize and control devtools’ and select ‘Undock into separate window’ option. 3. Now click on ‘More options’ icon (seen at device toolbar) 2-3 times and observe. Actual : ‘More options’, ‘Devices’ and ‘Zoom’ drop down menu goes unresponsive after step 2. Expected : ‘More options’, ‘Devices’ and ‘Zoom’ drop down menus should work after step 2. This is a regression issue broken in ‘M-50’, below is the Manual Regression and Narrow Bisect info. Good build : 50.0.2655.0 Bad build : 50.0.2656.0 Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/6bfb8dfbca1349e5f53731aa4a0e358b9e86b776..5f04d0b3af773b5e6bed7423d36e39f0a7b6b9c1?pretty=fuller&n=10000 Suspecting: r376345 from Narrow Bisect @dgozman : Please take a look. Note : This is mac specific issue and not seen on Windows/Linux OS.
,
Oct 26 2016
@ dgozman : Able to reproduce in Mac canary 56.0.2901.0. After step 2, do not click anywhere on the page and directly double click on 'More options' icon, observe the device toolbar. Issue is reproducible with this step, kindly review and attached screen cast. Thank you!
,
Oct 28 2016
,
Nov 3 2016
It appears that this problem also happens on any real (not-soft) context menu that can be triggered by click (also the drawer's 3 dot menu). Filed another bug for the core issue: https://bugs.chromium.org/p/chromium/issues/detail?id=661766
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b231468fd5825415fff761c25f561c8c782ab25c commit b231468fd5825415fff761c25f561c8c782ab25c Author: luoe <luoe@chromium.org> Date: Thu Nov 03 01:15:51 2016 DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context menu state on Mac WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is possible to reach a bad state on Mac OS by focusing on a different window, then making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the originally unfocused DevTools. On the first mouse press, nothing happens, but on the second, two mousedown events are sent within 300ms of each other. The context menu starts to open, but is cleared almost immediately afterwards. After that, the button no longer shows context menus. Showing a real context menu on click only happens on ToolbarMenuButton, and throttling its trigger function will fix the symptom. The core issue is tracked at crbug.com/661766 . BUG= 655556 Review-Url: https://codereview.chromium.org/2469813005 Cr-Commit-Position: refs/heads/master@{#429498} [modify] https://crrev.com/b231468fd5825415fff761c25f561c8c782ab25c/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
,
Nov 9 2016
,
Nov 9 2016
,
Nov 9 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/586ccb873fb16a5aa74088a0bee823ae290bb836 commit 586ccb873fb16a5aa74088a0bee823ae290bb836 Author: luoe <luoe@chromium.org> Date: Wed Nov 09 19:06:15 2016 DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context menu state on Mac WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is possible to reach a bad state on Mac OS by focusing on a different window, then making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the originally unfocused DevTools. On the first mouse press, nothing happens, but on the second, two mousedown events are sent within 300ms of each other. The context menu starts to open, but is cleared almost immediately afterwards. After that, the button no longer shows context menus. Showing a real context menu on click only happens on ToolbarMenuButton, and throttling its trigger function will fix the symptom. The core issue is tracked at crbug.com/661766 . BUG= 655556 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2469813005 Cr-Commit-Position: refs/heads/master@{#429498} (cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c) Review-Url: https://codereview.chromium.org/2492523003 Cr-Commit-Position: refs/branch-heads/2883@{#510} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/586ccb873fb16a5aa74088a0bee823ae290bb836/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
,
Nov 16 2016
Verified the fix on Mac 10.11.6 using Chrome Beta version #55.0.2883.52 as per the comment #0. Observed that the fix is working as expected. Attaching the screencast for reference Hence, adding the verified labels
,
Nov 16 2016
Thanks for the screencast, looks good! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dgozman@chromium.org
, Oct 17 2016