Issue metadata
Sign in to add a comment
|
Regression: Position of the separator line is not proper in zoom section of wrench menu in arabic language.
Reported by
lpa...@etouch.net,
Oct 13 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 55.0.2883.11 (Official Build) 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}-32/64 bit OS: Windows (7,8,10) Steps: 1. Launch chrome and navigate to chrome://settings/addLanguage 2. Change the browser language to 'Arabic'. 3. Click on the wrench menu and observe the position of the separator line in zoom option. Actual: Position of the separator line is not proper in zoom section. Expected: Position of the separator line should be proper. This is a regression issue broken in M-54, will soon update the other info. Manual Regression Range: Good Build: 54.0.2832.0 Bad Build: 54.0.2833.0 Note: Issue is not seen in Mac and Linux OS.
,
Oct 14 2016
,
Oct 25 2016
Fix up for review; will want to merge to M55 once it lands.
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/200957be2c524036da93b36b69360f8d4ed83c81 commit 200957be2c524036da93b36b69360f8d4ed83c81 Author: pkasting <pkasting@chromium.org> Date: Tue Oct 25 19:30:26 2016 Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG= 655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Review-Url: https://codereview.chromium.org/2448903002 Cr-Commit-Position: refs/heads/master@{#427439} [modify] https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81/chrome/browser/ui/views/toolbar/app_menu.cc
,
Oct 25 2016
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e91bed12e40a4568953d09679727c5c9857ca93 commit 5e91bed12e40a4568953d09679727c5c9857ca93 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Oct 26 21:26:57 2016 Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG= 655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Review-Url: https://codereview.chromium.org/2448903002 Cr-Commit-Position: refs/heads/master@{#427439} (cherry picked from commit 200957be2c524036da93b36b69360f8d4ed83c81) Review URL: https://codereview.chromium.org/2452183002 . Cr-Commit-Position: refs/branch-heads/2883@{#315} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/5e91bed12e40a4568953d09679727c5c9857ca93/chrome/browser/ui/views/toolbar/app_menu.cc
,
Oct 26 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e91bed12e40a4568953d09679727c5c9857ca93 commit 5e91bed12e40a4568953d09679727c5c9857ca93 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Oct 26 21:26:57 2016 Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG= 655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Review-Url: https://codereview.chromium.org/2448903002 Cr-Commit-Position: refs/heads/master@{#427439} (cherry picked from commit 200957be2c524036da93b36b69360f8d4ed83c81) Review URL: https://codereview.chromium.org/2452183002 . Cr-Commit-Position: refs/branch-heads/2883@{#315} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/5e91bed12e40a4568953d09679727c5c9857ca93/chrome/browser/ui/views/toolbar/app_menu.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Oct 13 2016Owner: pkasting@chromium.org
Status: Assigned (was: Unconfirmed)