New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

Failures in all/conformance/more/functions/copyTexImage2D.html on Windows Skylake using Intel GPU

Project Member Reported by jiawei.s...@intel.com, Oct 13 2016

Issue description

What steps will reproduce the problem?
(1) open chrome with command line: --enable-unsafe-es3-apis
(2) open url: https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/copyTexImage2D.html

What is the expected output?
All tests can always pass.

What do you see instead?
Sometimes case testRoundtrip fails on Windows Skylake using Intel GPU.

Please use labels and text to provide additional information.
The failure is caused because sometimes gl.clear() fails to take effect when the width or the height < 16.
Other failures due to the same reason:
all/conformance/more/functions/copyTexSubImage2D.html
all/conformance/textures/misc/copy-tex-image-2d-formats.html
all/conformance/canvas/viewport-unchanged-upon-resize.html
 
Labels: -Pri-3 Pri-2
After further investigation, we found gl.clearBufferfv() may also fail to work  on targets with any size.
The possible workaround for these clear issues are the same that when we call clear twice everything turns to be right.

Related failures are as follows:
all/deqp/functional/gles3/framebufferblit/default_framebuffer_00.html
all/deqp/functional/gles3/framebufferblit/default_framebuffer_01.html
all/deqp/functional/gles3/framebufferblit/default_framebuffer_02.html
all/deqp/functional/gles3/framebufferblit/default_framebuffer_03.html
all/deqp/functional/gles3/framebufferblit/default_framebuffer_04.html
all/deqp/functional/gles3/framebufferblit/default_framebuffer_06.html

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b0e6e412026e45bf0d4d363ee4bb4afba0b6276f

commit b0e6e412026e45bf0d4d363ee4bb4afba0b6276f
Author: Jiawei-Shao <jiawei.shao@intel.com>
Date: Fri Oct 14 07:59:47 2016

Workaround clear issue on Intel Skylake D3D driver

On some Intel D3D drivers on Skylake, calling clear may take no effect.
To work around this bug, we call clear() twice when we attempt to do clear
on these platforms.

BUG= chromium:655534 

Change-Id: I3b05892e80e5797d268861e8f52e080f5175855b
Reviewed-on: https://chromium-review.googlesource.com/398522
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/b0e6e412026e45bf0d4d363ee4bb4afba0b6276f/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
[modify] https://crrev.com/b0e6e412026e45bf0d4d363ee4bb4afba0b6276f/src/libANGLE/renderer/d3d/WorkaroundsD3D.h
[modify] https://crrev.com/b0e6e412026e45bf0d4d363ee4bb4afba0b6276f/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a8e6fdfe6fc127842878381cd15844d9ce3411d

commit 5a8e6fdfe6fc127842878381cd15844d9ce3411d
Author: jmadill <jmadill@chromium.org>
Date: Mon Oct 31 22:20:35 2016

Roll ANGLE 705a919..60e6edf

https://chromium.googlesource.com/angle/angle.git/+log/705a919..60e6edf

BUG= chromium:655534 , chromium:659472 , chromium:660670 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2470533002
Cr-Commit-Position: refs/heads/master@{#428839}

[modify] https://crrev.com/5a8e6fdfe6fc127842878381cd15844d9ce3411d/DEPS

Comment 5 by zmo@chromium.org, Nov 5 2016

Status: Fixed (was: Assigned)
Since we had a workaround already, let's close this.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/61491505e8775d9cd6f17ea0bf0ffa4c2e6ffe51

commit 61491505e8775d9cd6f17ea0bf0ffa4c2e6ffe51
Author: Jiawei Shao <jiawei.shao@intel.com>
Date: Thu Sep 21 12:46:44 2017

Tighten clear-twice workaround on Windows Skylake Intel GPU

The workaround for calling clearRenderTargetView on small targets
isn't needed on the newly released Intel D3D driver 15.46-4771
because the fix of this bug has been merged into this driver.

BUG= chromium:655534 

Change-Id: I90125971fd4b782b7363b8ca3104bd500e21a034
Reviewed-on: https://chromium-review.googlesource.com/668223
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/61491505e8775d9cd6f17ea0bf0ffa4c2e6ffe51/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/48497462c18533794979cb8020a982f4681fd635

commit 48497462c18533794979cb8020a982f4681fd635
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Sep 21 13:50:20 2017

Roll skia/third_party/externals/angle2/ a5dc625c9..61491505e (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/a5dc625c9ab0..61491505e877

$ git log a5dc625c9..61491505e --date=short --no-merges --format='%ad %ae %s'
2017-09-15 jiawei.shao Tighten clear-twice workaround on Windows Skylake Intel GPU

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 655534 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE
TBR=fmalita@google.com

Change-Id: I5bc454df53cb52680d8e8757c128a04314ed37e5
Reviewed-on: https://skia-review.googlesource.com/49661
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/48497462c18533794979cb8020a982f4681fd635/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4c1105a36b2474a8aca40003e945bc2ef9ee69

commit 3d4c1105a36b2474a8aca40003e945bc2ef9ee69
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Sep 21 16:22:41 2017

Roll src/third_party/skia/ 24a9cec8c..48497462c (1 commit)

https://skia.googlesource.com/skia.git/+log/24a9cec8c47a..48497462c185

$ git log 24a9cec8c..48497462c --date=short --no-merges --format='%ad %ae %s'
2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ a5dc625c9..61491505e (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG= 655534 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I10a47e0fae3b61110d1743e6b7c5ae15cc83e126
Reviewed-on: https://chromium-review.googlesource.com/677064
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503462}
[modify] https://crrev.com/3d4c1105a36b2474a8aca40003e945bc2ef9ee69/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2ec8306dd6854d928eb3bf88840af0a5fdb983

commit cb2ec8306dd6854d928eb3bf88840af0a5fdb983
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Thu Sep 21 19:19:25 2017

Roll ANGLE 47bf2dc..1f9d684

https://chromium.googlesource.com/angle/angle.git/+log/47bf2dc..1f9d684

BUG= chromium:767279 ,chromium:725308, chromium:765321 , chromium:655534 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I794ad67e2a1ef672855c65eef94959800cba9477
Reviewed-on: https://chromium-review.googlesource.com/677428
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503529}
[modify] https://crrev.com/cb2ec8306dd6854d928eb3bf88840af0a5fdb983/DEPS

Sign in to add a comment