Issue metadata
Sign in to add a comment
|
imageCapture: getPhotoCapabilities crashes |
||||||||||||||||||||||
Issue descriptionIMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it. Chrome Version: 55.0.2883.7 Operating System: Linux 3.8.11 URL (if applicable) where crash occurred: https://beaufortfrancois.github.io/sandbox/image-capture/playground.html Can you reproduce this crash? Yes What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?) 1. Open https://beaufortfrancois.github.io/sandbox/image-capture/playground.html 2. It crashes 3. ****DO NOT CHANGE BELOW THIS LINE**** Crash ID: crash/3e80665b00000000
,
Oct 13 2016
I believe this is related to the fact I'm calling getPhotoCapabilities as when commenting out the line, I don't crash.
,
Oct 13 2016
,
Oct 13 2016
FYI, Adding a small timeout of 500ms before calling getPhotoCapabilities doesn't crash. If the timeout is about 200ms, it still crashes.
,
Oct 13 2016
https://crash.corp.google.com/browse?q=stable_signature%3D%27content%3A%3AVideoCaptureManager%3A%3AOnDeviceStarted-7c854294%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports:15,+magicsignature,filepath,magicsignature2,operatingsystem,osversion,stablesignature2 is the crash search for this (only friends&family so far)
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124fafd9aae60044673495b39a775a931cbdf90e commit 124fafd9aae60044673495b39a775a931cbdf90e Author: mcasas <mcasas@chromium.org> Date: Thu Oct 13 17:13:04 2016 VideoCaptureManager: handle case when GetDeviceEntryBySessionId is null VCM's l.553 uses GetDeviceEntryBySessionId(request->first) without checking the result, that could be null, and is, speculatively, the root cause of the crashes linked in the bug. BUG= 655522 Review-Url: https://codereview.chromium.org/2419613003 Cr-Commit-Position: refs/heads/master@{#425072} [modify] https://crrev.com/124fafd9aae60044673495b39a775a931cbdf90e/content/browser/renderer_host/media/video_capture_manager.cc
,
Oct 14 2016
For repro, this needs at least 2 cameras connected and recognised. Tentatively fixed by #6, to verify.
,
Oct 14 2016
,
Oct 19 2016
I'm waiting for the next CrOs Dev channel release to verify this bug (currently is 55.0.2883.17, should move soon).
,
Oct 21 2016
,
Oct 21 2016
Issue 657323 has been merged into this issue.
,
Oct 21 2016
ot fixed, reproducible using the instructions in https://crbug.com/657323 : What steps will reproduce the problem? (1) Go to https://beaufortfrancois.github.io/sandbox/image-capture/get-photo-capabilities-crash.html (getUserMedia) (2) Hit "Reload" button multiple times (3) It works fine (4) Go to https://beaufortfrancois.github.io/sandbox/image-capture/get-photo-capabilities-crash.html?ImageCapture (getUserMedia + new ImageCapture) (5) Hit "Reload" button multiple times (6) It works fine (7) Go to https://beaufortfrancois.github.io/sandbox/image-capture/get-photo-capabilities-crash.html?ImageCapture&getPhotoCapabilities (getUserMedia + new ImageCapture + getPhotoCapabilities) (8) Hit "Reload" button multiple times
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a76be1ce16df264f18a66359177f91f2959fe77 commit 6a76be1ce16df264f18a66359177f91f2959fe77 Author: mcasas <mcasas@chromium.org> Date: Fri Oct 21 04:30:15 2016 ImageCapture: fix using invalidated iterator after removing entry from |photo_request_queue_| This CL avoids preincrementing a potentially invalidated iterator after it has been erase()d from |photo_request_queue_|. It caused the crash detailed in the bug. BUG= 655522 TEST= see bug, I could repro in a Linux dev debug build. Review-Url: https://chromiumcodereview.appspot.com/2443473002 Cr-Commit-Position: refs/heads/master@{#426728} [modify] https://crrev.com/6a76be1ce16df264f18a66359177f91f2959fe77/content/browser/renderer_host/media/video_capture_manager.cc
,
Oct 21 2016
Preventively marking as Fixed, since I could repro consistently. fbeaufort@ or myself should verify in the next CrOs Canary
,
Oct 24 2016
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue?
,
Nov 23 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fbeaufort@chromium.org
, Oct 13 2016