New issue
Advanced search Search tips

Issue 655521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 657266



Sign in to add a comment

Turn down DrMemory

Project Member Reported by benwells@chromium.org, Oct 13 2016

Issue description

These bots are going to be removed from the waterfall.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/8f268fe2f6249ccf63c1dd0964d7c4a0db3c39ea

commit 8f268fe2f6249ccf63c1dd0964d7c4a0db3c39ea
Author: benwells <benwells@google.com>
Date: Fri Oct 14 00:38:21 2016

Blockedon: 657266
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e7a0251e3368561f3718ed3996e564b6bf9f817

commit 3e7a0251e3368561f3718ed3996e564b6bf9f817
Author: benwells <benwells@chromium.org>
Date: Thu Oct 20 21:26:29 2016

Remove DrMemory suppressions and test exclusions.

BUG= 655521 

Review-Url: https://chromiumcodereview.appspot.com/2435853004
Cr-Commit-Position: refs/heads/master@{#426602}

[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/drmemory/OWNERS
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/drmemory/PRESUBMIT.py
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/drmemory/suppressions.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/drmemory/suppressions_full.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/blink_heap_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/cast_unittests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/chrome_elf_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/components_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/extensions_unittests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/gin_unittests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/ipc_tests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/libphonenumber_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/printing_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win-xp.txt
[delete] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt

Cc: thestig@chromium.org
+thestig

Dirk / Lei - in the main chrome repo there are lots of references to drmemory in things like tools/valgrind/chrome_tests.py, tools/mb/mb_config.py ... and a bunch of other places. Do you think these should be cleaned up?

I don't really mind (I don't mind some mindless work between meetings) but won't bother if people will push back on review.
If the bots are gone, then I believe tools/mb/mb_config.py can go to, but Dirk can confirm. I'd just leave tools/valgrind/chrome_tests.py alone. It's on its way out anyway, if I get my act together.
Yes, the entries in mb_config.py can and should be deleted. I would clean up all the references you find (and feel motivated to clean up); we should not leave stale things in the repo.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e144de966f4224bbcef74582dfd49ac324d15dec

commit e144de966f4224bbcef74582dfd49ac324d15dec
Author: benwells <benwells@chromium.org>
Date: Tue Nov 08 21:04:49 2016

Remove redundant disabling of DesktopMediaListAshTest.

The test was disabled on Windows, but Ash isn't a thing on Windows any
more so the ifdeffery to disable it can be removed. It also only timed
out on DrMemory (according to the comment) which also isn't a thing.

BUG= 493187 ,  655521 

Review-Url: https://codereview.chromium.org/2487523002
Cr-Commit-Position: refs/heads/master@{#430712}

[modify] https://crrev.com/e144de966f4224bbcef74582dfd49ac324d15dec/chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc

Status: Fixed (was: Started)
I think this is all done now. The drmemory and dynamorio masters are deliberately left around.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/5c19c3597b2865c0b5bc2c61fc5911cbd5d6ba90

commit 5c19c3597b2865c0b5bc2c61fc5911cbd5d6ba90
Author: dan sinclair <dsinclair@chromium.org>
Date: Wed Feb 01 23:38:58 2017

Remove DrMemory

The DrMemory bots have been removed, remove the config and infrastructure.

BUG= chromium:655521 

Change-Id: I065d717b11d615a6dc981b79a8caefd8783b105b
Reviewed-on: https://pdfium-review.googlesource.com/2494
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/5c19c3597b2865c0b5bc2c61fc5911cbd5d6ba90/testing/tools/common.py
[modify] https://crrev.com/5c19c3597b2865c0b5bc2c61fc5911cbd5d6ba90/testing/tools/test_runner.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/DrMemory-Windows-sfx.exe
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/README
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/common.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/drmemory_analyze.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/logging_utils.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/path_utils.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/pdfium_tests.bat
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/pdfium_tests.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/scripts/valgrind_test.py
[delete] https://crrev.com/1f5e327bc8a4114b5c390b89ac94ee320d1d06de/tools/drmemory/suppressions.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9828a98170ac83fc22070d0a308baa02a946585b

commit 9828a98170ac83fc22070d0a308baa02a946585b
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Feb 02 01:09:57 2017

Roll src/third_party/pdfium/ 1f5e327bc..5c19c3597 (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/1f5e327bc8a4..5c19c3597b28

$ git log 1f5e327bc..5c19c3597 --date=short --no-merges --format='%ad %ae %s'
2017-02-01 dsinclair Remove DrMemory

BUG= 655521 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2667273002
Cr-Commit-Position: refs/heads/master@{#447667}

[modify] https://crrev.com/9828a98170ac83fc22070d0a308baa02a946585b/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d2d8e45ab8777bc238eb3e6c94827fee307c28

commit 28d2d8e45ab8777bc238eb3e6c94827fee307c28
Author: Nico Weber <thakis@chromium.org>
Date: Sun Oct 01 02:16:44 2017

win: Stop pulling a drmemory .exe from a DEPS hook.

We removed the DrMemory bots a while ago (see bug), so this should not
longer be needed.  Also delete a few other references to drmemory.

Bug:  655521 
Change-Id: I03f499036e8205575b43aa54c63f26d569cf958f
Reviewed-on: https://chromium-review.googlesource.com/693158
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505490}
[modify] https://crrev.com/28d2d8e45ab8777bc238eb3e6c94827fee307c28/DEPS
[modify] https://crrev.com/28d2d8e45ab8777bc238eb3e6c94827fee307c28/third_party/.gitignore
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/third_party/drmemory/LICENSE
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/third_party/drmemory/OWNERS
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/third_party/drmemory/README.chromium
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/third_party/drmemory/drmemory-windows-sfx.exe.sha1
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/tools/valgrind/browser_wrapper_win.py
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/tools/valgrind/drmemory.bat
[delete] https://crrev.com/f55a9b4724687afe0057e24509bd21099b881fbb/tools/valgrind/drmemory_analyze.py
[modify] https://crrev.com/28d2d8e45ab8777bc238eb3e6c94827fee307c28/tools/valgrind/suppressions.py
[modify] https://crrev.com/28d2d8e45ab8777bc238eb3e6c94827fee307c28/tools/valgrind/test_suppressions.py

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a009106d3a971dfe05602765fc5b3d9798e59f28

commit a009106d3a971dfe05602765fc5b3d9798e59f28
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Sun Oct 01 19:30:01 2017

Drop tools/valgrind/browser_wrapper_win.py (unused and recently removed)

This unblocks Chromium roll after
https://chromium-review.googlesource.com/693158

Bug:  chromium:655521 
Change-Id: I15c8f66a4fe962b5e30a3197a57c7ffc8260d0e9
Reviewed-on: https://webrtc-review.googlesource.com/5002
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20055}
[modify] https://crrev.com/a009106d3a971dfe05602765fc5b3d9798e59f28/tools_webrtc/valgrind/valgrind.gni

Sign in to add a comment