Issue metadata
Sign in to add a comment
|
Regression: In chrome://history, blue highlight on main menu list is chopped on pressing Tab key.
Reported by
vvishwak...@etouch.net,
Oct 13 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 56.0.2889.0 (Official Build) canary 1e457676004f8af16e0086280b73d87c1e5efba7-refs/heads/master@{#424926} (64-bit) OS: Mac (10.10.5, 10.11.4) What steps will reproduce the problem? 1) Launch chrome, go to chrome://history and press Tab key till focus is on Tabs from Other devices. 2) Observe the right side of Blue highlight. Blue highlight on right side is chopped. Blue highlight on right side should be seen properly. This is a Regression issue broken in M-56, will soon update other info
,
Oct 13 2016
Using the per-revision bisect providing the bisect results, Good build:56.0.2888.0(Revision: 424625). Bad build:56.0.2889.0 (Revision: 424926). You are probably looking for a change made after 424685 (known good), but no later than 424686 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/1bee8df0bab836996dbdddd4e6817f11f3bae320..bd29d296277d9115186c6f76e1cebce4eaefc2fc From the CL above, assigning the issue to the concern owner @ tsergeant - Could you please check whether this is caused with respect to your change.. looks like this is intended, Could you please check and confirm.. Review-Url: https://chromium.googlesource.com/chromium/src/+/bd29d296277d9115186c6f76e1cebce4eaefc2fc
,
Oct 19 2016
,
Nov 15 2016
Weirdly, this is caused by setting the overflow property on <history-side-bar>. The simplest fix seems to be to change the margin on the individual sidebar items so that there's enough room for the outline. I'm not sure if there's a better solution than that.
,
Nov 15 2016
I've filed a Blink bug for this at issue 665260 .
,
Nov 15 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db319346f11bfeac596508b7183eaf1e320d3b0b commit db319346f11bfeac596508b7183eaf1e320d3b0b Author: tsergeant <tsergeant@chromium.org> Date: Tue Nov 15 06:26:46 2016 MD History: Add margin to sidebar items so focus outline shows fully This adds 4px of spacing to the end of each sidebar item, which is sufficient to allow the outline to show without being cropped. BUG= 655503 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2502903002 Cr-Commit-Position: refs/heads/master@{#432132} [modify] https://crrev.com/db319346f11bfeac596508b7183eaf1e320d3b0b/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/db319346f11bfeac596508b7183eaf1e320d3b0b/chrome/browser/resources/md_history/side_bar.html
,
Nov 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vvishwak...@etouch.net
, Oct 13 2016133 KB
133 KB View Download