New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Pdf page gets auto scrolled after dragging mouse cursor from RHS to LHS in viewer pdf toolbar area.

Reported by mni...@etouch.net, Oct 13 2016

Issue description

Version: 55.0.2883.11 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79} (64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)
URL : http://www.cbu.edu.zm/downloads/pdf-sample.pdf

What steps will reproduce the problem?
1. Launch chrome and navigate to above url.
2. Now drag the mouse cursor over title 'Pdf-sample.pdf' in viewer pdf toolbar from RHS to LHS and observe the Pdf page.(Refer screencast)

Actual: Pdf page gets auto scrolled after dragging mouse cursor over title 'Pdf-sample.pdf'in viewer pdf toolbar from RHS to LHS
Expected: Pdf page should not auto scroll after dragging mouse cursor over title 'Pdf-sample.pdf' in viewer pdf toolbar from RHS to LHS

This is regression issue, broken in ‘M 55’ and will soon update other info
Good build : 55.0.2865.0
Bad build : 55.0.2867.0
 
Actual_video.mov
2.5 MB Download
Expected_video.mov
726 KB Download

Comment 1 by hdodda@chromium.org, Oct 13 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: grunell@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2865.0(Revision: 419399).
Bad build: 55.0.2867.0 (Revision: 419930).


You are probably looking for a change made after 419695 (known good), but no later than 419696 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/e698f733b78ea46b1e1ba045e4ea2a3cf98a1e7e..86cc5ff4d533256008521baaac593e9c55077798

From the CL above, assigning the issue to the concern owner 

@grunell - Could you please check whether this is caused with respect to your change, if not please help us in assign it to the right owner.

Review-Url: https://codereview.chromium.org/2350413002

Note : Adding RB-stable for now , please feel free to edit it.

Thanks!
Owner: ----
Status: Untriaged (was: Assigned)
This is not related to WebRTC. The suspect CL is a WebRTC roll.
Cc: wjmaclean@chromium.org bokan@chromium.org
wjmaclean@, bokan@ you've looked into scrolling issues with PDFs before I believe, does this ring any bells?

Comment 4 by bokan@chromium.org, Oct 13 2016

Labels: Hotlist-Input-Dev Needs-Bisect
Owner: sunyunjia@chromium.org
Status: Assigned (was: Untriaged)
This sounds like an autoscrolling bug. sunyunjia@ has made some autoscrolling changes recently, and sure enough b7026e2d381d6f3f8d46394bf173b92c2826a5d5 is in the regression range.

I suspect the bisect was wrong, could we please try again?

In the meantime, sunyunjia@, please take a look.

Comment 5 by mni...@etouch.net, Oct 14 2016

Labels: -Needs-Bisect
With response to comment #4:
Test URL : https://graduateland.com/api/v2/users/jesper/cv as the above mentioned url is not working.

Re bisected the above issue and below is the narrow bisect info :

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/6ef830bbfcde9c92f95c45838f1cd9e41235caaa..4e472b9a8d316d2eea6c7561a0b8f330d82b739e?pretty=fuller&n=100

Suspecting: r419654 from Narrow bisect

@sunyunjia : Could you please help to reassign if your change is not the cause for this change.

Status: Started (was: Assigned)
sunyunjia@, just wondering do we have any further update on the fix?

Thank you!
Yes, I just figured out the problem. The bug is not intrinsically a regression. Without the patch, when we select the 'xxx.pdf' in the pdf-toolbar while moving mouse over the browser-toolbar, it will still trigger autoscroll. My patch triggers the autoscroll when the mousedrag is within a range to the border. The goal was to fix the no-autoscroll problem in the full-screen model, but brings out the pdf-autoscroll problem, as the toolbar is within that range.

I'm investigating whether we could detect whether the mouse in the tool bar, and if not, we can only trigger autoscroll at the top when the mouse is outside the document.
Thank you for the update!
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53546e297f782849d9da8004508d0b85c2fd931c

commit 53546e297f782849d9da8004508d0b85c2fd931c
Author: sunyunjia <sunyunjia@chromium.org>
Date: Mon Oct 24 21:00:37 2016

Prevent AutoscrollForSelection when selecting text in a fixed-position element.

AutoscrollForSelection is triggered when selecting text and dragging mouse out
of the container. However, we don't want selecting text in a fixed-position
element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find
the object is inside a fixed-position element, we should prevent
AutoscrollForSelection from happening.

BUG= 655489 

Review-Url: https://codereview.chromium.org/2441683002
Cr-Commit-Position: refs/heads/master@{#427146}

[add] https://crrev.com/53546e297f782849d9da8004508d0b85c2fd931c/third_party/WebKit/LayoutTests/fast/events/autoscroll-disabled-in-fix.html
[modify] https://crrev.com/53546e297f782849d9da8004508d0b85c2fd931c/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Status: Fixed (was: Started)
Labels: TE-Verified-56.0.2900.0 TE-Verified-M56
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest Dev M56-56.0.2900.0 by following steps mentioned in the original comment. Observed no auto scrolling in the pdf page while dragging the mouse cursor. Hence adding TE-Verified label.

Tested the same on chrome latest M55-55.0.2883.28 and observed still issue persists on it.

sunyunjia@  Could you please merge this CL to M55 branch. 

Thanks!
655489.ogv
1.6 MB View Download
Labels: Merge-Request-55

Comment 14 by dimu@chromium.org, Oct 27 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9021d6508dfddb41393ae8fa2af2e6dae8cac676

commit 9021d6508dfddb41393ae8fa2af2e6dae8cac676
Author: Majid Valipour <majidvp@chromium.org>
Date: Thu Oct 27 18:27:43 2016

Prevent AutoscrollForSelection when selecting text in a fixed-position element.

AutoscrollForSelection is triggered when selecting text and dragging mouse out
of the container. However, we don't want selecting text in a fixed-position
element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find
the object is inside a fixed-position element, we should prevent
AutoscrollForSelection from happening.

BUG= 655489 

Review-Url: https://codereview.chromium.org/2441683002
Cr-Commit-Position: refs/heads/master@{#427146}
(cherry picked from commit 53546e297f782849d9da8004508d0b85c2fd931c)

Review URL: https://codereview.chromium.org/2455163002 .

Cr-Commit-Position: refs/branch-heads/2883@{#342}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/9021d6508dfddb41393ae8fa2af2e6dae8cac676/third_party/WebKit/LayoutTests/fast/events/autoscroll-disabled-in-fix.html
[modify] https://crrev.com/9021d6508dfddb41393ae8fa2af2e6dae8cac676/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9021d6508dfddb41393ae8fa2af2e6dae8cac676

commit 9021d6508dfddb41393ae8fa2af2e6dae8cac676
Author: Majid Valipour <majidvp@chromium.org>
Date: Thu Oct 27 18:27:43 2016

Prevent AutoscrollForSelection when selecting text in a fixed-position element.

AutoscrollForSelection is triggered when selecting text and dragging mouse out
of the container. However, we don't want selecting text in a fixed-position
element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find
the object is inside a fixed-position element, we should prevent
AutoscrollForSelection from happening.

BUG= 655489 

Review-Url: https://codereview.chromium.org/2441683002
Cr-Commit-Position: refs/heads/master@{#427146}
(cherry picked from commit 53546e297f782849d9da8004508d0b85c2fd931c)

Review URL: https://codereview.chromium.org/2455163002 .

Cr-Commit-Position: refs/branch-heads/2883@{#342}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/9021d6508dfddb41393ae8fa2af2e6dae8cac676/third_party/WebKit/LayoutTests/fast/events/autoscroll-disabled-in-fix.html
[modify] https://crrev.com/9021d6508dfddb41393ae8fa2af2e6dae8cac676/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Labels: TE-Verified-M55 TE-Verified-55.0.2883.33
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest M55-55.0.2883.33 and observed the fix got merged to M55 branch successfully. Hence adding TE-Verified label.

Comment 18 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 19 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment