New issue
Advanced search Search tips

Issue 655479 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Compat


Sign in to add a comment

Pass web platform tests for the cache storage

Project Member Reported by shimazu@chromium.org, Oct 13 2016

Issue description

This is an ☂️umbrella☂️ bug to track the cache-storage related web platform tests.

 

Comment 1 by jsb...@chromium.org, Nov 21 2016

Blockedon: 508984 667376 666991

Comment 2 by jsb...@chromium.org, Nov 21 2016

Blockedon: 666993
Cc: jkarlin@chromium.org cmumford@chromium.org
PR https://github.com/w3c/web-platform-tests/pull/4235 filed to start to align upstream tests w/ our local copies. That's a mechanical change that just reconciles assert_promise_rejects w/ promise_rejects to minimize the overall diff.

Follow up will be to audit the differences between our local tests and WPT, upstream anything appropriate, then start going through the failures. 
https://codereview.chromium.org/2790143003/ for reconciling/deleting or local copies

(We don't pass everything but at least there's only one set of tests to chase)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c004f971b6a204a8802b0fad4cac0401b17771

commit 44c004f971b6a204a8802b0fad4cac0401b17771
Author: jsbell <jsbell@chromium.org>
Date: Thu Apr 06 19:52:04 2017

Cache Storage API tests: Fix WPT test bugs, remove redundant local copies

* Use promise_rejects consistently and fix parameters.
* Don't use .php in upstreamed tests.
* Add additional test cases from blink's copies.
* Tightened up assertions about result array ordering.
* Remove blink's redundant copies of tests.

I left the credentials tests alone since Blink is mid-deprecation.

BUG=655479
R=jkarlin@chromium.org

Review-Url: https://codereview.chromium.org/2790143003
Cr-Commit-Position: refs/heads/master@{#462593}

[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/resources/test-helpers.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-add.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-delete.js
[rename] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-keys.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-match.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-matchAll.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-put.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage.js
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt
[add] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-keys.https.html
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-add.https-expected.txt
[add] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-keys.https.html
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-storage.https-expected.txt
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-add.https-expected.txt
[rename] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-keys.https.html
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-put.https-expected.txt
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-storage.https-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/common.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/blank.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/common-worker.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/fetch-status.php
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/iframe.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-delete.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-put.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-keys.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage.js
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-delete.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-keys.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-put.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-keys.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage.html
[modify] https://crrev.com/44c004f971b6a204a8802b0fad4cac0401b17771/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/ignore-search-with-credentials.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-add-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-add.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-delete.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-keys.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-put.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-keys.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-storage.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/sandboxed-iframes-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/sandboxed-iframes.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-add-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-add.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-delete.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-put.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-expected.txt
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-keys.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage-match.html
[delete] https://crrev.com/a1597ec0c31e6d96f3fdba7c34c4d1b28dc52b4f/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-storage.html

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5136241948671b538965c783e8aee27e88037aa9

commit 5136241948671b538965c783e8aee27e88037aa9
Author: jsbell <jsbell@chromium.org>
Date: Mon Apr 10 08:25:24 2017

Cache API tests: prepopulate cache in deterministic order

Chrome and Firefox differ in the order in which cache keys() are
returned. Chrome orders by according to when the put()s were issued.
Firefox orders by when the body is complete. The test helper
prepopulated_cache_test did not guarantee that these matched, leading
to the tests being flaky in Firefox. This change tweaks the helper so
that the put()s are processed serially so that the order is
deterministic for both.

Spec issue: https://github.com/w3c/ServiceWorker/issues/823
BUG=655479

Review-Url: https://codereview.chromium.org/2806793002
Cr-Commit-Position: refs/heads/master@{#463195}

[modify] https://crrev.com/5136241948671b538965c783e8aee27e88037aa9/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/resources/test-helpers.js

Comment 6 by jsb...@chromium.org, Apr 10 2017

That unblocked the upstreaming, so that part is complete (apart from the credentials tests).

Now we need to analyze failures and make sure we have tracking bugs for all of those.

Comment 7 by jsb...@chromium.org, Apr 10 2017

Status: Started (was: Assigned)

Comment 8 by jsb...@chromium.org, Apr 10 2017

Blockedon: -666993

Comment 9 by jsb...@chromium.org, May 10 2017

Blockedon: 720918
Blockedon: 720919
Blockedon: 720921
Blockedon: 432746
Failures: 

window/sandboxed-iframes.https.html - issue 720921
*/cache-storage.https.html - issue 432746
*/cache-matchAll.https.html - issue 720918
*/cache-add.https.html - issue 720919


Cc: jsb...@chromium.org
Owner: ----
Status: Available (was: Started)
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: wanderview@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment