Issue metadata
Sign in to add a comment
|
Integer-overflow in blink::CounterDirectives::combinedValue |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6001544598388736 Fuzzer: miaubiz_svg_fuzzer Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::CounterDirectives::combinedValue planCounter blink::makeCounterNodeIfNeeded Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Minimized Testcase (1.10 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97b5HGz-LK4gK0AoPx7H_2c57mpKZb7Y4Y4QIIz6wkRP8ZDe9YB_fc1_XpKoIQ1xcEW6SkOu5NPG6lxR0eKE6tssDui2Ia2hGNvTzzFA4q6vTB6fSqqG19-ci2h13ZkoFUo1TtakE5wQmsBCdsBfjDLrIJyIw?testcase_id=6001544598388736 Issue manually filed by: nyerramilli See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Oct 18 2016
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1 2017
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
,
Oct 2 2017
Looks like this FIXME needs to be fixed: https://chromium.googlesource.com/chromium/src/+/9da284ba7ab742893cba73c1078908eac5d3a6d1/third_party/WebKit/Source/core/style/CounterDirectives.h#86 Making Blink>CSS the sole component as per our triage procedure.
,
Oct 3 2017
Hi Eddy, do you know what we're supposed to do with integer overflows? Can we just cap the value at INT_MAX?
,
Oct 3 2017
,
Oct 9 2017
,
Oct 10 2017
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e18ac62b00618f26ef125554dd8241b2aed711e9 commit e18ac62b00618f26ef125554dd8241b2aed711e9 Author: Darren Shen <shend@chromium.org> Date: Tue Oct 17 10:44:55 2017 Prevent counter values from over/underflowing. Currently we over/underflow if a counter value goes beyond the limits of a 32 bit integer. The spec [1] says we can ignore the increment if it would cause an over/underflow. This patch implements this behaviour. Firefox follows the spec in this. [1] https://drafts.csswg.org/css-lists-3/#valdef-counter-reset-custom-ident-integer Bug: 655473 Change-Id: I6e10b6e4f5f672d723a0ccb69fd309d52d1d1204 Reviewed-on: https://chromium-review.googlesource.com/708105 Reviewed-by: Justin Schuh <jschuh@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509351} [add] https://crrev.com/e18ac62b00618f26ef125554dd8241b2aed711e9/third_party/WebKit/LayoutTests/fast/css/counters/counter-overflow.html [modify] https://crrev.com/e18ac62b00618f26ef125554dd8241b2aed711e9/third_party/WebKit/Source/core/layout/CounterNode.cpp [modify] https://crrev.com/e18ac62b00618f26ef125554dd8241b2aed711e9/third_party/WebKit/Source/core/style/CounterDirectives.h
,
Oct 18 2017
ClusterFuzz has detected this issue as fixed in range 509326:509389. Detailed report: https://clusterfuzz.com/testcase?key=6001544598388736 Fuzzer: miaubiz_svg_fuzzer Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: blink::CounterDirectives::CombinedValue PlanCounter blink::MakeCounterNodeIfNeeded Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=370022:370027 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=509326:509389 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6001544598388736 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Oct 18 2017
ClusterFuzz testcase 6001544598388736 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Nov 7 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Oct 13 2016Components: Tools>Test>FindIt>WrongResult Infra>Git
Labels: -Type-Bug findit-wrong M-54 Te-Logged Type-Bug-Regression
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)