New issue
Advanced search Search tips

Issue 655443 link

Starred by 1 user
Status: Fixed
Owner:
sdy@chromium.org
Closed: Oct 2016
Cc:
mac-bugs-priority@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Clicking "settings" on a notification doesn't bring Chrome to the foreground

Project Member Reported by sdy@chromium.org, Oct 13 2016 
Version: 56.0.2888.0
OS: macOS

What steps will reproduce the problem?
(1) Get a notification when Chrome is not the front-most app.
(2) Click the settings button in the notification.

What is the expected output?
Chrome comes to the foreground.

What do you see instead?
A settings tab opens, but Chrome doesn't come to the foreground.

My own regression from crrev.com/2393323005.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72276b24d4574f8a2ba899c27dff45be4d4cbfd

commit c72276b24d4574f8a2ba899c27dff45be4d4cbfd
Author: sdy <sdy@chromium.org>
Date: Thu Oct 13 15:38:17 2016

[Mac] Bring Chrome to the front when the settings button in a notification is clicked.

BUG= 655443 

Review-Url: https://codereview.chromium.org/2412983004
Cr-Commit-Position: refs/heads/master@{#425042}

[modify] https://crrev.com/c72276b24d4574f8a2ba899c27dff45be4d4cbfd/ui/message_center/cocoa/notification_controller.mm

Comment 2 by sdy@chromium.org, Oct 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment