New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655435 link

Starred by 1 user
Status: Fixed
Owner:
shuchen@chromium.org
Closed: Dec 2016
Cc:
█ cibu@google.com
wuyingbing@chromium.org
azurewei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Chrome IME API should work well with multiple user profiles.

Project Member Reported by shuchen@chromium.org, Oct 13 2016 
Version: R55
OS: Linux

What steps will reproduce the problem?
(1) Open Chrome windows for profile A & B.
(2) Install Google Input Tools extension for both profiles.
(3) Activates an input method in A, and verify whether it can work in B.
(4) Activates an input method in B, and verify whether it can work in A.
(5) Deactivates the input method in B, and verify whether the input method of A can work in A.

What is the expected output?
(3) No.
(4) No.
(5) Yes.

What do you see instead?
(3) Yes.
(4) Yes.
(5) No.

Please use labels and text to provide additional information.

Comment 1 by shuchen@chromium.org, Oct 13 2016 

Offline discussed with azurewei and came up with a solution:
The active IME API engine (per profile) should be considered to be switch on/off when the root window is focused/blurred.

Comment 2 by azurewei@chromium.org, Nov 23 2016

Cc: wuyingbing@chromium.org

Comment 3 by shuchen@chromium.org, Nov 29 2016

Cc: -shuchen@chromium.org azurewei@chromium.org
Labels: M-57
Owner: shuchen@chromium.org
Status: Started (was: Assigned)

Comment 4 by shuchen@chromium.org, Nov 29 2016

Cc: cibu@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e264372929e2a983205b972a06a517ac25a1685

commit 2e264372929e2a983205b972a06a517ac25a1685
Author: shuchen <shuchen@chromium.org>
Date: Fri Dec 23 08:39:21 2016

Makes the InputMethodEngine can be switched per profile when the top-level browser window is switched.

BUG= 655435 

Review-Url: https://codereview.chromium.org/2597413002
Cr-Commit-Position: refs/heads/master@{#440602}

[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/chromeos/input_method/mock_input_method_engine.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/chromeos/input_method/mock_input_method_engine.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/extensions/api/input_ime/input_ime_api.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/ui/input_method/input_method_engine_base.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/ui/input_method/input_method_engine_base.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/chrome/browser/ui/input_method/input_method_engine_unittest.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/ui/base/ime/chromeos/mock_ime_engine_handler.cc
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/ui/base/ime/chromeos/mock_ime_engine_handler.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/ui/base/ime/ime_engine_handler_interface.h
[modify] https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685/ui/base/ime/input_method_base.cc

Comment 6 by shuchen@chromium.org, Dec 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment