New issue
Advanced search Search tips

Issue 655430 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: 2016-10-13
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: script executed from console isn't visible in timeline

Project Member Reported by paulir...@chromium.org, Oct 13 2016 
0. go to a page that's not too complex. google homepage is probably good.
1. put this into a snippet https://gist.github.com/anonymous/604f59a3e8521e278d1baf35a02b3da8
2. run the snippet
3. open drawer console.
4. go to timeline
5. start timeline recording
6. in console evaluate: 

axe.a11yCheck(document, function (results) {
   console.log(results);
});


7. stop recording once you see the console update
8. timeline recording is missing all the JS callstacks.

see screenshot
on left is how canary looks. on right is mostly how it should look.
Screen Shot 2016-10-12 at 6.10.43 PM.png
183 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6882c91ecd222f3ee2feb42ad73fbc796d5c8172

commit 6882c91ecd222f3ee2feb42ad73fbc796d5c8172
Author: alph <alph@chromium.org>
Date: Thu Oct 13 21:57:29 2016

[inspector] Record EvaluateScript trace event upon console evaluation

It will allow timeline to show JS profile on code evaluated from console.

BUG= chromium:655430 

Review-Url: https://codereview.chromium.org/2413943002
Cr-Commit-Position: refs/heads/master@{#40289}

[modify] https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172/src/inspector/DEPS
[modify] https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172/src/inspector/v8-runtime-agent-impl.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/64378066b7f520e4b62dae472e4acba56469dd4c

commit 64378066b7f520e4b62dae472e4acba56469dd4c
Author: machenbach <machenbach@chromium.org>
Date: Fri Oct 14 08:51:19 2016

Revert of [inspector] Record EvaluateScript trace event upon console evaluation (patchset #2 id:20001 of https://codereview.chromium.org/2413943002/ )

Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10647

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> [inspector] Record EvaluateScript trace event upon console evaluation
>
> It will allow timeline to show JS profile on code evaluated from console.
>
> BUG= chromium:655430 
>
> Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172
> Cr-Commit-Position: refs/heads/master@{#40289}

TBR=caseq@chromium.org,paulirish@chromium.org,dgozman@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:655430 

Review-Url: https://codereview.chromium.org/2416213002
Cr-Commit-Position: refs/heads/master@{#40299}

[modify] https://crrev.com/64378066b7f520e4b62dae472e4acba56469dd4c/src/inspector/DEPS
[modify] https://crrev.com/64378066b7f520e4b62dae472e4acba56469dd4c/src/inspector/v8-runtime-agent-impl.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799eabe2822ffaea3ca8c841d5bca1fbb9fbc979

commit 799eabe2822ffaea3ca8c841d5bca1fbb9fbc979
Author: alph <alph@chromium.org>
Date: Fri Oct 14 18:36:46 2016

Prepare for new EvaluateScript event coming from V8.

BUG= 655430 
TBR=caseq@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2422643003
Cr-Commit-Position: refs/heads/master@{#425398}

[modify] https://crrev.com/799eabe2822ffaea3ca8c841d5bca1fbb9fbc979/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/74a392cc88c2217709db643c7ca7664564b97db7

commit 74a392cc88c2217709db643c7ca7664564b97db7
Author: alph <alph@chromium.org>
Date: Fri Oct 14 19:04:45 2016

[inspector] Record EvaluateScript trace event upon console evaluation

It will allow timeline to show JS profile on code evaluated from console.

BUG= chromium:655430 

Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172
Review-Url: https://codereview.chromium.org/2413943002
Cr-Original-Commit-Position: refs/heads/master@{#40289}
Cr-Commit-Position: refs/heads/master@{#40323}

[modify] https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7/src/inspector/DEPS
[modify] https://crrev.com/74a392cc88c2217709db643c7ca7664564b97db7/src/inspector/v8-runtime-agent-impl.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc0e803ee2205a7b456b93fb9a33c0b523216a7

commit afc0e803ee2205a7b456b93fb9a33c0b523216a7
Author: alph <alph@chromium.org>
Date: Fri Oct 14 22:34:17 2016

DevTools: Allow EvaluateScript event with no arguments.

BUG= 655430 

Review-Url: https://codereview.chromium.org/2417643005
Cr-Commit-Position: refs/heads/master@{#425494}

[modify] https://crrev.com/afc0e803ee2205a7b456b93fb9a33c0b523216a7/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a31b9d310728c7c77b5d755fe45a04ee203d10b1

commit a31b9d310728c7c77b5d755fe45a04ee203d10b1
Author: alph <alph@chromium.org>
Date: Fri Oct 14 23:52:47 2016

DevTools: Prepare tests for EvaluateScript trace event coming from V8.

BUG= 655430 
TBR=caseq@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2418313002
Cr-Commit-Position: refs/heads/master@{#425512}

[modify] https://crrev.com/a31b9d310728c7c77b5d755fe45a04ee203d10b1/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef128f21633d5b5bebcb61ab7df16f5ede78a90

commit 1ef128f21633d5b5bebcb61ab7df16f5ede78a90
Author: alph <alph@chromium.org>
Date: Mon Oct 17 19:55:43 2016

DevTools: update expectation after v8 inspector started emitting EvaluateScript event.

BUG= 655430 
TBR=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2428673002
Cr-Commit-Position: refs/heads/master@{#425759}

[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-tag-1-expected.txt
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-tag-2-expected.txt
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event-expected.txt
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-time-expected.txt
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-expected.txt
[modify] https://crrev.com/1ef128f21633d5b5bebcb61ab7df16f5ede78a90/third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames-expected.txt

Comment 8 by alph@chromium.org, Oct 17 2016

Status: Fixed (was: Assigned)

Comment 9 by alph@chromium.org, Oct 17 2016

Status: Started (was: Fixed)

Comment 10 by alph@chromium.org, Oct 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment