git cl land doesn't respect per-file OWNERS |
||
Issue descriptionIn attempting to land a CL (https://chromereviews.googleplex.com/519517013/), I'm using 'git cl land' because the CQ hasn't passed after a couple tries. But git cl land won't accept it because it's missing an LGTM from someone in the OWNERS file, but the only people listed in the OWNERS file are not listed as per-file owners of services.md """ $ git cl land Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit commit checks ... ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: doc/services.md benhenry@benhenry:~/checkouts/infra_internal/infra_internal/doc (blink)$ more OWNERS per-file commit_queue.md=akuegel@google.com per-file commit_queue.md=phajdan@google.com per-file commit_queue.md=sergiyb@google.com per-file commit_queue.md=tandrii@google.com """
,
Oct 13 2016
OWNERS files are hereditary. The full set of OWNERS for doc/services.md is both that owners file, and the one in the root infra_internal.git directory. $ cd infra_internal $ cat OWNERS doc/OWNERS | egrep '(dpranke|benhenry)' $ echo $? 1 Since neither the uploaded nor reviewer is an OWNER, git-cl is doing the right thing and refusing the CL.
,
Oct 13 2016
(Also, the reason the CQ was failing was that you didn't have LGTM from an OWNER. So using 'git cl land' wasn't going to make that any better.) |
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Oct 13 2016