Blink's one-pixel-wide caret is hard to see on high-DPI displays |
|||||
Issue descriptionGoogle Chrome 53.0.2785.144 (Official Build) (64-bit) Platform 8530.93.0 (Official Build) stable-channel samus Blink looks like it draws text-input carets (in both textareas and text inputs) as a one-pixel-wide vertical line (first attachment), which is pretty hard to see on a high-DPI (2x, in samus's case) display. When I focus the omnibox, the caret used there looks like it's two pixels wide (second attachment). Is there any reason why we can't do the same thing in Blink?
,
Oct 13 2016
,
Feb 8 2017
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3353063df1bbda55628a8c1e0a0d1f1289d80b78 commit 3353063df1bbda55628a8c1e0a0d1f1289d80b78 Author: malaykeshav <malaykeshav@chromium.org> Date: Mon Feb 13 23:59:14 2017 Set caret width based on device scale factor Moves caretWidth() function from LayoutObject to FrameView and computes the width according to the device scale factor. COMPONENT=LayoutObject, FrameView, Caret BUG= 655410 Review-Url: https://codereview.chromium.org/2683233005 Cr-Commit-Position: refs/heads/master@{#450160} [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/3353063df1bbda55628a8c1e0a0d1f1289d80b78/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
,
Feb 14 2017
,
Apr 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by osh...@chromium.org
, Oct 13 2016Status: Assigned (was: Untriaged)