Remove CQ +2 flag. |
||||||||||||
Issue descriptionThe CQ +2 flag tends to confuse people, and isn't very useful anymore since we rarely close the tree (and tend to chump fixes if it is closed). Should we just get rid of it?
,
Oct 13 2016
Seems like we should be able to remove it from the Gerrit configurations now, then clean up the code. Does anyone but Sosa have access to the relevant Gerrit configs?
,
Oct 17 2016
assigning to Don to either do it or reassign.
,
Jan 26 2017
Aviv has Gerrit admin rights, he should be able to make the config change there.
,
Jan 27 2017
Next step is to remove the matching cbuildbot logic. That sounds like fixit material to me!
,
Jan 30 2017
,
Feb 1 2017
,
Feb 1 2017
,
Feb 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/repohooks/+/5ac59528997d9eacc9ba47f2d30839f92c5f1cf7 commit 5ac59528997d9eacc9ba47f2d30839f92c5f1cf7 Author: Aviv Keshet <akeshet@chromium.org> Date: Wed Feb 01 22:29:23 2017 pre-upload: add COMMIT-QUEUE.ini parse check BUG= chromium:655381 TEST=None Change-Id: I17aa70eeb519dde79e7c17266e86e3ed0a0f87f9 Reviewed-on: https://chromium-review.googlesource.com/435579 Commit-Ready: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/5ac59528997d9eacc9ba47f2d30839f92c5f1cf7/pre-upload_unittest.py [modify] https://crrev.com/5ac59528997d9eacc9ba47f2d30839f92c5f1cf7/pre-upload.py
,
Feb 2 2017
Uh the above CL actually was a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=681110 (just for the record)
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/repohooks/+/d0523446ad7da8b4d30f29e08561c5ef652ae237 commit d0523446ad7da8b4d30f29e08561c5ef652ae237 Author: Mike Frysinger <vapier@chromium.org> Date: Thu Jan 04 22:35:19 2018 pre-upload: fix COMMIT-QUEUE.ini check The current check never works because _get_file_content always returns an empty string. This is because we pass it full filesystem paths, but _get_file_content only works with relative paths. Fix the file filtering call to get relative paths, and add a sanity check to the _get_file_content helper to prevent any future hooks from going unnoticed. BUG= chromium:655381 TEST=`repo upload` rejects an invalid COMMIT-QUEUE.ini CL now Change-Id: If80aa5ed18e932255262ad5aba5ccb8bc0cefd8d Reviewed-on: https://chromium-review.googlesource.com/847941 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/d0523446ad7da8b4d30f29e08561c5ef652ae237/pre-upload.py |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by akes...@chromium.org
, Oct 13 2016