Additional request from UI review is to keep UI review in the loop as we proceed with implementation so they can get a sense of image previews + visual weight of icons.
Nice! (did you remove the cc's for a reason btw?)
Looks great. Only nit is the Link -> Image height jump. Do you know if we're planning on addressing that?
Yeah, it would be great to implement the smooth transition we discussed. There are also some small visual tweaks to be made – are you ready for that kind of pixel-level review?
Fyi, I just landed a patch to make the bottom system navigation bar white on OMR1+. With this treatment, the tabular context menu looks odd since the scrim doesn't cover the system controls (see attached screenshot)
I think there are two options:
- Increase the scrim height and possibly needs to invert the navigation button colors to match other dialogs
- Make the bottom system nav for this context menu black (for now) by using a different style than DialogWhenLarge
More details here: https://bugs.chromium.org/p/chromium/issues/detail?id=778736#c31
Hello everybody,
Could somebody from you look into bugs/fr submitted my "mwiacek" too?
I was submitting various things, but they were less or more suspended or dropped, examples:
1. unifying context menu from NTP and webpages (I have even partially working code, which is displaying webpage context menus for NTP elements)
2. displaying link title with/instead of URL in the header
3. resizing context menu after expanding url this way, that menu options are still visible
4. displaying "switch to tab" (instead of "open in new tab" or as extra menu option)
etc.
I don't have ability to comment internally on things.
Comment 1 by k...@chromium.org
, Oct 12 2016