New issue
Advanced search Search tips

Issue 655341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Improve downloads stuck impression

Project Member Reported by dougarnett@chromium.org, Oct 12 2016

Issue description

Besides UX improvements, determine other improvements to faster service background load requests for downloads requested in foreground.
 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e325cb30270ec359ee79055e825f0e3cfb334a

commit 75e325cb30270ec359ee79055e825f0e3cfb334a
Author: dougarnett <dougarnett@chromium.org>
Date: Wed Nov 02 15:43:11 2016

[Offline Pages] Adds UMA for effective network connection on api calls.
Captures the NetworkQualityEstimator connection type on SavePageLater,
RemoveRequests, PauseRequest, and ResumeRequests to shed some insight
on the conditions under which the user is triggering these apis.

BUG= 655341 

Review-Url: https://codereview.chromium.org/2466343003
Cr-Commit-Position: refs/heads/master@{#429283}

[modify] https://crrev.com/75e325cb30270ec359ee79055e825f0e3cfb334a/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/75e325cb30270ec359ee79055e825f0e3cfb334a/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12aa9df385dcd9e1b85ead71827358bc32648873

commit 12aa9df385dcd9e1b85ead71827358bc32648873
Author: dougarnett <dougarnett@chromium.org>
Date: Fri Nov 04 22:05:58 2016

[Offline Pages] Coordinator checks for net connection before starting next req

As part of improving the servicing of background load requests, we should
avoid scheduling the next request if we have lost the network connection (to
save resources and attempt count). When the network comes back then we want
scheduler to start us again.

BUG= 655341 

Review-Url: https://codereview.chromium.org/2467333003
Cr-Commit-Position: refs/heads/master@{#430027}

[modify] https://crrev.com/12aa9df385dcd9e1b85ead71827358bc32648873/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/12aa9df385dcd9e1b85ead71827358bc32648873/components/offline_pages/background/request_coordinator_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0aebf37854698a45180ac8886b78d22f8b5de4

commit fa0aebf37854698a45180ac8886b78d22f8b5de4
Author: dougarnett <dougarnett@chromium.org>
Date: Thu Nov 10 00:20:54 2016

[Offline Pages] Feature flag to allow concurrent background loading on svelte

Adds flag (default off) to allow immediate processing of SavePageLater requests
on low-end devices. This will allow us to evaluate concurrent loading on our
development devices and allows for prospect of a future Finch trial.

BUG= 655341 

Review-Url: https://codereview.chromium.org/2483463002
Cr-Commit-Position: refs/heads/master@{#431094}

[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/chrome/app/generated_resources.grd
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/chrome/browser/about_flags.cc
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/background/BUILD.gn
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/offline_page_feature.cc
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/offline_page_feature.h
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/fa0aebf37854698a45180ac8886b78d22f8b5de4/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Closing this now for the M-56 work. Opened 670119 for leveraging network
observer for M-57.

Sign in to add a comment