New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655333 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[OffscreenCanvas] content displaying upside-down

Project Member Reported by junov@chromium.org, Oct 12 2016

Issue description

WebGL content displayed via the commit flow is showing up upside-down
See attached example.

Note: With GPU disabled, contents are not inverted (observed in a remote desktop ssession)
 
offscreen_webgl_bug.html
2.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b

commit 8ff3caa7df9850d82ade934e1415b6ff8cb43a6b
Author: xidachen <xidachen@chromium.org>
Date: Sat Oct 15 19:16:39 2016

Fix content upside down when call OffscreenCanvas's commit

The reason that the content is upside down is that we have a flag called
yflipped and it is always false. In the case of GPU compositing, this flag
should be true.

This CL also updates pixel tests for WebGL's commit, such that instead
of drawing a uniform color square, we draw a white triangle on a green
background.

BUG= 655333 ,  655311 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2417773003
Cr-Commit-Position: refs/heads/master@{#425571}

[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93a6aea7e77a239b0552564d946520c17d1cb29

commit d93a6aea7e77a239b0552564d946520c17d1cb29
Author: xidachen <xidachen@chromium.org>
Date: Sun Oct 16 16:02:55 2016

Remove some failure entries in pixel_expectations.py

In our previous CL: https://codereview.chromium.org/2417773003/, we
changed the contents of some pixel tests and labeled them failure. The
above CL has been picked up by most of the GPU bots, I have checked all
the generated reference images and they are all fine. Some of the FYI
bots (android ones) are purple for a while, so I will keep an eye on
those bots once this CL is in.

BUG= 655333 
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2420353002
Cr-Commit-Position: refs/heads/master@{#425591}

[modify] https://crrev.com/d93a6aea7e77a239b0552564d946520c17d1cb29/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2016

Labels: merge-merged-2892
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93a6aea7e77a239b0552564d946520c17d1cb29

commit d93a6aea7e77a239b0552564d946520c17d1cb29
Author: xidachen <xidachen@chromium.org>
Date: Sun Oct 16 16:02:55 2016

Remove some failure entries in pixel_expectations.py

In our previous CL: https://codereview.chromium.org/2417773003/, we
changed the contents of some pixel tests and labeled them failure. The
above CL has been picked up by most of the GPU bots, I have checked all
the generated reference images and they are all fine. Some of the FYI
bots (android ones) are purple for a while, so I will keep an eye on
those bots once this CL is in.

BUG= 655333 
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2420353002
Cr-Commit-Position: refs/heads/master@{#425591}

[modify] https://crrev.com/d93a6aea7e77a239b0552564d946520c17d1cb29/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b5ad14320726b53e0da301023cef1ba7818daf

commit 97b5ad14320726b53e0da301023cef1ba7818daf
Author: xlai <xlai@chromium.org>
Date: Wed Oct 19 15:25:54 2016

Fix Unaccelerated2DGpuCompositing gpu test cases

TBR=junov@chromium.org
BUG= 655333 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2426573004
Cr-Commit-Position: refs/heads/master@{#426199}

[modify] https://crrev.com/97b5ad14320726b53e0da301023cef1ba7818daf/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/97b5ad14320726b53e0da301023cef1ba7818daf/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Sign in to add a comment