New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655311 link

Starred by 3 users
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
█ kbr@chromium.org
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Improve gpu pixel test for OffscreenCanvas

Project Member Reported by xidac...@chromium.org, Oct 12 2016 
At this moment, in all our gpu pixel tests for OffscreenCanvas, we basically just fill the canvas with one uniform color. This kind of test easily hide bugs, for example, we won't know if the rendered image is upside down or not.

We should improve our test cases, suggestions:
for 2d: we use fillRect to fill the canvas with red, green, blue and black in 4 sub-squares.

for webgl: we clear canvas with a background color, and draw a triangle on it.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b

commit 8ff3caa7df9850d82ade934e1415b6ff8cb43a6b
Author: xidachen <xidachen@chromium.org>
Date: Sat Oct 15 19:16:39 2016

Fix content upside down when call OffscreenCanvas's commit

The reason that the content is upside down is that we have a flag called
yflipped and it is always false. In the case of GPU compositing, this flag
should be true.

This CL also updates pixel tests for WebGL's commit, such that instead
of drawing a uniform color square, we draw a white triangle on a green
background.

BUG= 655333 ,  655311 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2417773003
Cr-Commit-Position: refs/heads/master@{#425571}

[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/8ff3caa7df9850d82ade934e1415b6ff8cb43a6b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f30364de462f0a655b33085a1404cd445feb46e2

commit f30364de462f0a655b33085a1404cd445feb46e2
Author: xlai <xlai@chromium.org>
Date: Mon Oct 17 21:03:57 2016

Improve gpu pixel tests for OffscreenCanvas 2d

BUG= 655311 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2416953002
Cr-Commit-Position: refs/heads/master@{#425776}

[modify] https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html
[modify] https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
[modify] https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/f30364de462f0a655b33085a1404cd445feb46e2/content/test/gpu/gpu_tests/pixel_test_pages.py
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edeb9140a03270a5be2fa2e7d36014949b7128df

commit edeb9140a03270a5be2fa2e7d36014949b7128df
Author: xlai <xlai@chromium.org>
Date: Thu Oct 20 16:50:32 2016

Remove failed entries in gpu pixel expectations

The reference images generated for Accelerated2D and
Unaccelerated2D cases look correct.

TBR=zmo@chromium.org
BUG= 655311 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2423413002
Cr-Commit-Position: refs/heads/master@{#426503}

[modify] https://crrev.com/edeb9140a03270a5be2fa2e7d36014949b7128df/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 4 by xidac...@chromium.org, Nov 28 2016

Cc: -xlai@chromium.org
Owner: xlai@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba383c57f8705d7bd67bd69e12288c5403ddd584

commit ba383c57f8705d7bd67bd69e12288c5403ddd584
Author: xlai <xlai@chromium.org>
Date: Wed Jan 04 16:33:06 2017

Improve gpu pixel test for OffscreenCanvas

BUG= 655311 

Review-Url: https://codereview.chromium.org/2594393003
Cr-Commit-Position: refs/heads/master@{#441389}

[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_main.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_worker.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_transfer_after_style_resize.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_transfer_before_style_resize.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html
[modify] https://crrev.com/ba383c57f8705d7bd67bd69e12288c5403ddd584/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html

Comment 6 by xlai@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment