New issue
Advanced search Search tips

Issue 655286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Use Milo's pubsub topic instead of polling CBE

Project Member Reported by seanmccullough@google.com, Oct 12 2016

Issue description

This is part of go/som-pubsub
 
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 13 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ffa265f477d555578fa5066a00e4162e446b5bda

commit ffa265f477d555578fa5066a00e4162e446b5bda
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Oct 13 15:25:34 2016

[som] Fix pubsub push handler to log errors and return OK

So pubsub doesn't keep retrying doomed messages.

BUG= 655286 

Change-Id: If9b6c8904d0e4d6a47232ce5594ddef1be32679e
Reviewed-on: https://chromium-review.googlesource.com/397916
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/ffa265f477d555578fa5066a00e4162e446b5bda/go/src/infra/appengine/sheriff-o-matic/pubsub.go
[modify] https://crrev.com/ffa265f477d555578fa5066a00e4162e446b5bda/go/src/infra/appengine/sheriff-o-matic/pubsub_test.go

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/13dd1a21351bdc14013ea5ddc17c803476497c1a

commit 13dd1a21351bdc14013ea5ddc17c803476497c1a
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Thu Oct 27 20:17:36 2016

[som] pubsub alerts: persist alerts using LUCI's datastore wrapper.

BUG= 655286 

Change-Id: Ie6434d352c04ff9403bdd844a351b1935bb42540
Reviewed-on: https://chromium-review.googlesource.com/400558
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/appengine/sheriff-o-matic/pubsub.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/analyzer/test/test_helpers.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/analyzer/test/test_helpers_test.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/inmemstore.go
[add] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/persistentstore.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/pubsub.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/pubsub_test.go
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/pubsubalerts.infra_testing
[modify] https://crrev.com/13dd1a21351bdc14013ea5ddc17c803476497c1a/go/src/infra/monitoring/pubsubalerts/pull/main.go

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3e2fb96235a9498bcaef9e287c8d2751c418422b

commit 3e2fb96235a9498bcaef9e287c8d2751c418422b
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Oct 31 23:25:00 2016

Update relnotes for SOM

BUG= 655234 , 655286 , 637006 

Change-Id: I914008d6cb9e0c684ceaa53552b57e4700149f38
Reviewed-on: https://chromium-review.googlesource.com/405827
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/3e2fb96235a9498bcaef9e287c8d2751c418422b/go/src/infra/appengine/sheriff-o-matic/RELNOTES.md

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7c2d143dd563838ff2f98b0baaf629caa91bddee

commit 7c2d143dd563838ff2f98b0baaf629caa91bddee
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Nov 09 00:15:55 2016

[som] prep to generate alerts feed from pubsub persistent store

This doesn't generate the actual AlertsJSON object yet, but it does add
the necessary code to go from /pubsubalerts/:tree to getting the 
masters for that tree and querying the datastore for alerts on each 
tree.

This includes a workaround for reading gatekeeper_trees.json from 
luci-config: It reads the file from gitiles and cahces it in memcache.
Not ideal since it can't read internal tree configs in this state.

BUG= 655286 

Change-Id: I1b56bf570e5cb67820a4efe0a083bf88184e6282
Reviewed-on: https://chromium-review.googlesource.com/405781
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/appengine/sheriff-o-matic/main.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/appengine/sheriff-o-matic/pubsub.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/appengine/sheriff-o-matic/pubsub_test.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/monitoring/pubsubalerts/inmemstore.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/monitoring/pubsubalerts/persistentstore.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/monitoring/pubsubalerts/pubsub.go
[modify] https://crrev.com/7c2d143dd563838ff2f98b0baaf629caa91bddee/go/src/infra/monitoring/pubsubalerts/pubsub_test.go

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3a1045920ac73b18e6d7263dfbb7e2f93eda5198

commit 3a1045920ac73b18e6d7263dfbb7e2f93eda5198
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Nov 15 23:29:22 2016

[som] Fix pusbsub alert storage issue

This was causing a lot of 500s on staging.

BUG= 655286 

Change-Id: I4f700dd36fb04f23de5fbd3e16ce4ebebc801109
Reviewed-on: https://chromium-review.googlesource.com/411373
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/3a1045920ac73b18e6d7263dfbb7e2f93eda5198/go/src/infra/monitoring/pubsubalerts/persistentstore.go

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3a1045920ac73b18e6d7263dfbb7e2f93eda5198

commit 3a1045920ac73b18e6d7263dfbb7e2f93eda5198
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Nov 15 23:29:22 2016

[som] Fix pusbsub alert storage issue

This was causing a lot of 500s on staging.

BUG= 655286 

Change-Id: I4f700dd36fb04f23de5fbd3e16ce4ebebc801109
Reviewed-on: https://chromium-review.googlesource.com/411373
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/3a1045920ac73b18e6d7263dfbb7e2f93eda5198/go/src/infra/monitoring/pubsubalerts/persistentstore.go

Comment 9 by aga...@chromium.org, Nov 22 2016

Owner: seanmccullough@chromium.org
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
Status: Fixed (was: Started)

Sign in to add a comment