New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655285 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Logging error when label discovery on moblab

Project Member Reported by haddowk@chromium.org, Oct 12 2016

Issue description

Filling this as a moblab issue but likely this happens when the label code is run on any dut that does not have a servo.

I see this in the logs :

10/12 13:34:14.402 INFO |        base_label:0196| checking label ServoLabel
10/12 13:34:14.415 ERROR|        base_label:0201| error getting label ServoLabel: 'NoneType' object has no attribute 'get'
Traceback (most recent call last):
  File "/usr/local/autotest/server/hosts/base_label.py", line 198, in get_labels
    labels.extend(label.get(host))
  File "/usr/local/autotest/server/hosts/base_label.py", line 72, in get
    if self.exists(host):
  File "/usr/local/autotest/server/hosts/cros_label.py", line 316, in exists
    servo_host_hostname = servo_args.get(servo_host.SERVO_HOST_ATTR)
AttributeError: 'NoneType' object has no attribute 'get'
10/12 13:34:14.416 INFO |        base_label:0196| checking label StorageLabel



 
Ping on this I came across it again when debugging logs - can we address this ?
Labels: OS-Chrome
Status: Started (was: Assigned)
Sorry about that, this should be a quick fix, whipping up a cl now.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/745b8167a5a346742905c7b4d8b74ec722d56314

commit 745b8167a5a346742905c7b4d8b74ec722d56314
Author: Kevin Cheng <kevcheng@google.com>
Date: Mon Jun 05 20:01:50 2017

[autotest] Make servo label detection more robust.

BUG= chromium:655285 
TEST=None

Change-Id: Ia53afbc1dfb3b5f7fb8ba27df97a714e25541f51
Reviewed-on: https://chromium-review.googlesource.com/517322
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/745b8167a5a346742905c7b4d8b74ec722d56314/server/hosts/cros_label.py

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/030417a5346cdaea9d9f88dd90922c8c1e5d316a

commit 030417a5346cdaea9d9f88dd90922c8c1e5d316a
Author: Kevin Cheng <kevcheng@google.com>
Date: Thu Aug 24 20:33:53 2017

[autotest] Make servo label detection more robust.

BUG= chromium:655285 
TEST=None

Change-Id: Ia53afbc1dfb3b5f7fb8ba27df97a714e25541f51
Reviewed-on: https://chromium-review.googlesource.com/517322
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>
(cherry picked from commit 745b8167a5a346742905c7b4d8b74ec722d56314)
Reviewed-on: https://chromium-review.googlesource.com/633684
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/030417a5346cdaea9d9f88dd90922c8c1e5d316a/server/hosts/cros_label.py

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment