New issue
Advanced search Search tips

Issue 655279 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 547071



Sign in to add a comment

Remove deprecated methods from browsercrapplication+applescript_test.mm

Project Member Reported by erikc...@chromium.org, Oct 12 2016 
[39364/40640] OBJCXX obj/chrome/test/browser_tests/browsercrapplication+applescript_test.o
../../chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm:113:59: warning: 'title' is deprecated: first deprecated in macOS 10.9 [-Wdeprecated-declarations]
  EXPECT_NSEQ(@"Other Bookmarks", [[NSApp otherBookmarks] title]);
                                                          ^
/Users/erikchen/projects/osx_sdks/MacOSX10.10.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSliderCell.h:72:1: note: 'title' has been explicitly marked deprecated here
- (NSString *)title NS_DEPRECATED_MAC(10_0, 10_9);
^
../../chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm:114:55: warning: 'title' is deprecated: first deprecated in macOS 10.9 [-Wdeprecated-declarations]
  EXPECT_NSEQ(@"Bookmarks Bar", [[NSApp bookmarksBar] title]);
                                                      ^
/Users/erikchen/projects/osx_sdks/MacOSX10.10.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSSliderCell.h:72:1: note: 'title' has been explicitly marked deprecated here
- (NSString *)title NS_DEPRECATED_MAC(10_0, 10_9);
^
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac97ed3b0abc4370979ebbebeafa622ff2c7749

commit 1ac97ed3b0abc4370979ebbebeafa622ff2c7749
Author: erikchen <erikchen@chromium.org>
Date: Wed Oct 12 21:21:32 2016

Fix a deprecated declaration warning in browsercrapplication+applescript_test.mm.

The test was trying to call a method on an untyped object.

BUG= 655279 

Review-Url: https://codereview.chromium.org/2420463002
Cr-Commit-Position: refs/heads/master@{#424857}

[modify] https://crrev.com/1ac97ed3b0abc4370979ebbebeafa622ff2c7749/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

Comment 2 by erikc...@chromium.org, Oct 13 2016

Blocking: 547071
Status: Fixed (was: Assigned)
►

Sign in to add a comment