New issue
Advanced search Search tips

Issue 655277 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 166704



Sign in to add a comment

Android Seccomp Crash: SYS_sysinfo

Project Member Reported by rsesek@chromium.org, Oct 12 2016

Issue description

From https://buganizer.corp.google.com/issues/31171101#comment46

Only seeing this on arm32. sysno = 116.

Partially reconstructed stack:

Thread 10 CRASHED [SIGSEGV @ 0x0a53c074 ] MAGIC SIGNATURE THREAD
0xdcc5e05a      (libmonochrome.so -sigsys_handlers.cc:128 )     sandbox::CrashSIGSYS_Handler(sandbox::arch_seccomp_data const&, void*)
0xdcc5fa83      (libmonochrome.so -trap.cc:244 )        sandbox::Trap::SigSys(int, siginfo*, ucontext*)
0xf3641f7a      (libc.so + 0x00017f7a ) __restore
0xf36734ea      (libc.so + 0x000494ea ) sysinfo
0xf364afd7      (libc.so + 0x00020fd7 ) get_phys_pages
0xdbf61e7b      (libmonochrome.so -sys_info_linux.cc:23 )       base::SysInfo::AmountOfPhysicalMemory()
0xdc218d5b      (libmonochrome.so -isolate_holder.cc:40 )       gin::IsolateHolder::IsolateHolder(gin::IsolateHolder::AccessMode)
0xdc218d11      (libmonochrome.so -isolate_holder.cc:30 )       gin::IsolateHolder::IsolateHolder()

We should just allow sysinfo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc408a029eb5fc6d9c10f556df6c717fcaabb9a

commit 6cc408a029eb5fc6d9c10f556df6c717fcaabb9a
Author: rsesek <rsesek@chromium.org>
Date: Wed Oct 12 23:52:09 2016

[Android] Allow __NR_sysinfo and __NR_clock_getres under seccomp.

sysinfo() is allowed unconditionally, while clock_getres() is restricted to the
set of clk_ids that clock_gettime() is.

BUG= 655277 , 655299 
R=rickyz@chromium.org

Review-Url: https://codereview.chromium.org/2417673002
Cr-Commit-Position: refs/heads/master@{#424911}

[modify] https://crrev.com/6cc408a029eb5fc6d9c10f556df6c717fcaabb9a/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc

Comment 2 by rsesek@chromium.org, Oct 13 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b24153c24947d53fb5158a4888285c9f48850ff7

commit b24153c24947d53fb5158a4888285c9f48850ff7
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Oct 13 14:37:01 2016

[Android] Allow __NR_sysinfo and __NR_clock_getres under seccomp.

sysinfo() is allowed unconditionally, while clock_getres() is restricted to the
set of clk_ids that clock_gettime() is.

BUG= 655277 , 655299 
R=rickyz@chromium.org

Review-Url: https://codereview.chromium.org/2417673002
Cr-Commit-Position: refs/heads/master@{#424911}
(cherry picked from commit 6cc408a029eb5fc6d9c10f556df6c717fcaabb9a)

Review URL: https://codereview.chromium.org/2410303007 .

Cr-Commit-Position: refs/branch-heads/2883@{#86}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/b24153c24947d53fb5158a4888285c9f48850ff7/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc

Comment 5 by rsesek@chromium.org, Oct 13 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b24153c24947d53fb5158a4888285c9f48850ff7

commit b24153c24947d53fb5158a4888285c9f48850ff7
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Oct 13 14:37:01 2016

[Android] Allow __NR_sysinfo and __NR_clock_getres under seccomp.

sysinfo() is allowed unconditionally, while clock_getres() is restricted to the
set of clk_ids that clock_gettime() is.

BUG= 655277 , 655299 
R=rickyz@chromium.org

Review-Url: https://codereview.chromium.org/2417673002
Cr-Commit-Position: refs/heads/master@{#424911}
(cherry picked from commit 6cc408a029eb5fc6d9c10f556df6c717fcaabb9a)

Review URL: https://codereview.chromium.org/2410303007 .

Cr-Commit-Position: refs/branch-heads/2883@{#86}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/b24153c24947d53fb5158a4888285c9f48850ff7/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc

Comment 7 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment