New issue
Advanced search Search tips

Issue 655256 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTest orphan-set-selection-range.html is WontFix due to asserts

Project Member Reported by schenney@chromium.org, Oct 12 2016

Issue description

The test editing/input/orphan-set-selection-range.html appears in NeverFixTests because it fails with an assert in Debug builds. Having code in this state is a drag on other developers, because unnecessary asserts impact development.

However, what's really odd is that the test is disabled for Release.

Either the assert should be removed or the condition leading the the assert should be fixed or the test should be removed (because we never run it and never plan to). The test does not belong in NeverFixTests in it's current state.

 
Summary: LayoutTest orphan-set-selection-range.html is WontFix due to asserts (was: LayoutTest orphan-set-selection-range.html asserts in Debug)

Comment 2 by yosin@chromium.org, Oct 13 2016

Owner: yshin@google.com
Status: Started (was: Untriaged)
Attempt to enable rphan-set-selection-range.html: http://crrev.com/2414863003
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5888b30e1be4f8755616ad5ae1a9cc5aedd7656

commit a5888b30e1be4f8755616ad5ae1a9cc5aedd7656
Author: yosin <yosin@chromium.org>
Date: Thu Oct 13 08:10:51 2016

Enable editing/input/orphan-set-selection-range.html

This patch enables "editing/input/orphan-set-selection-range.html" since
it succeeds without assertion failure.

BUG= 655256 
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2414863003
Cr-Commit-Position: refs/heads/master@{#424979}

[modify] https://crrev.com/a5888b30e1be4f8755616ad5ae1a9cc5aedd7656/third_party/WebKit/LayoutTests/NeverFixTests

Comment 4 by yosin@chromium.org, Oct 18 2016

Owner: yosin@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment