Refactor how gvr context is created |
|||||
Issue descriptionThere are two cases that a gvr context is needed: 1. magic window mode (gvr context is needed to get sensor data) 2. presenting vr (either webvr presenting or ChromeVr mode) The way we currently implement is: 1. For case 1, we create a non presenting gvr context and keep it around as long as there is a magic window in tab 2. After switch to case 2, we create a VrShell which is a GvrLayout, which contains a gvr context. And this gvr context takes control when presenting. 3. After exit vr presenting, the non presenting gvr context is used again by magic window. Ideally, we just want one gvr layout. But currently, there is a gvr bug that results incorrect left/right eye rendering if gvr context is created when phone is in portrait mode. So create a gvr context for magic window(mostly in portrait mode) and separate gvr context for rendering (only in landscape mode) is the preferred way currently. This could change in the future, and we probably also don't need to keep non presenting gvr context around when presenting (this might have interesting effect if we open a magic window in ChromeVr). So a refactor is probably necessary. Creating this bug to track the process.
,
Dec 5 2016
b/30419347 is the bug that should fix the incorrect dimension issue. We should investigate this once it is fixed.
,
Dec 6 2016
Correction: b/31014865 is the issue that track the fix and it seems it is already fixed.
,
Dec 8 2016
,
Dec 8 2016
This may be related to and/or affected by issue 671302 .
,
Dec 8 2016
,
Aug 9 2017
We recently refactor a lot of code. And we probably dont keep the non presenting gvr context alive anymore when presenting. mthiesse@ can correct me if I am wrong. We are still using two different gvr context for magic window and presenting though. So keep this bug open for now.
,
Aug 9 2017
I don't think this is the desired direction anymore. I'd like to have device/vr own its own gvrLayout to do magic window mode, etc. without having to talk to the browser. I think we should close this bug.
,
Oct 10 2017
WAI, device/vr now has its own context and manages it independently. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ddorwin@chromium.org
, Dec 5 2016