New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655240 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Closing tab does not stop mirroring session.

Project Member Reported by x...@chromium.org, Oct 12 2016

Issue description

Mirroring session is not stopped after closing the tab. 
Last frame is continue displayed on receiver.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9

commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9
Author: xjz <xjz@chromium.org>
Date: Thu Oct 13 19:22:25 2016

Bug fix: stop mirroring session when tab is closed.
Fix bug caused by cl: https://codereview.chromium.org/2365223002.
|running_callback_| is used as a callback when status changes, and
should not be reset if the capture is successfully started.

BUG= 655240 

Review-Url: https://codereview.chromium.org/2408143004
Cr-Commit-Position: refs/heads/master@{#425124}

[modify] https://crrev.com/a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9/content/renderer/media/media_stream_video_capturer_source.cc

Comment 2 by x...@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Comment 3 by m...@chromium.org, Oct 18 2016

Status: Started (was: Fixed)
Before calling this fixed, we should make a follow-up change to correct the issues that allowed this mistake to happen in the first place. I've made comments here: https://codereview.chromium.org/2408143004

Comment 5 by x...@chromium.org, Oct 20 2016

Status: Fixed (was: Started)

Comment 6 by x...@chromium.org, Oct 21 2016

Labels: Merge-Request-55
Requesting to merge to M55. Low risk.

Comment 7 by gov...@chromium.org, Oct 22 2016

Is this applicable to all os or any specific os?

Comment 8 by x...@chromium.org, Oct 22 2016

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
It is applicable to all os other than ios.

Comment 9 by dimu@chromium.org, Oct 24 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b1c1094bb1e7e9918204064c14f2fd7688ae557

commit 6b1c1094bb1e7e9918204064c14f2fd7688ae557
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:52:54 2016

Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromium.org/2365223002. |running_callback_| is used as a callback when status changes, and should not be reset if the capture is successfully started.

BUG= 655240 

Review-Url: https://codereview.chromium.org/2408143004
Cr-Commit-Position: refs/heads/master@{#425124}
(cherry picked from commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9)

Review URL: https://codereview.chromium.org/2446803002 .

Cr-Commit-Position: refs/branch-heads/2883@{#265}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/6b1c1094bb1e7e9918204064c14f2fd7688ae557/content/renderer/media/media_stream_video_capturer_source.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4edd4994e815e13a5ce741fcf35111a465175e5

commit c4edd4994e815e13a5ce741fcf35111a465175e5
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:54:23 2016

Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future.

BUG= 655240 

Review-Url: https://chromiumcodereview.appspot.com/2432373003
Cr-Commit-Position: refs/heads/master@{#426327}
(cherry picked from commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7)

Review URL: https://codereview.chromium.org/2451473002 .

Cr-Commit-Position: refs/branch-heads/2883@{#267}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b1c1094bb1e7e9918204064c14f2fd7688ae557

commit 6b1c1094bb1e7e9918204064c14f2fd7688ae557
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:52:54 2016

Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromium.org/2365223002. |running_callback_| is used as a callback when status changes, and should not be reset if the capture is successfully started.

BUG= 655240 

Review-Url: https://codereview.chromium.org/2408143004
Cr-Commit-Position: refs/heads/master@{#425124}
(cherry picked from commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9)

Review URL: https://codereview.chromium.org/2446803002 .

Cr-Commit-Position: refs/branch-heads/2883@{#265}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/6b1c1094bb1e7e9918204064c14f2fd7688ae557/content/renderer/media/media_stream_video_capturer_source.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4edd4994e815e13a5ce741fcf35111a465175e5

commit c4edd4994e815e13a5ce741fcf35111a465175e5
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:54:23 2016

Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future.

BUG= 655240 

Review-Url: https://chromiumcodereview.appspot.com/2432373003
Cr-Commit-Position: refs/heads/master@{#426327}
(cherry picked from commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7)

Review URL: https://codereview.chromium.org/2451473002 .

Cr-Commit-Position: refs/branch-heads/2883@{#267}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source_unittest.cc

Comment 14 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment