Closing tab does not stop mirroring session. |
||||||||||
Issue descriptionMirroring session is not stopped after closing the tab. Last frame is continue displayed on receiver.
,
Oct 13 2016
,
Oct 18 2016
Before calling this fixed, we should make a follow-up change to correct the issues that allowed this mistake to happen in the first place. I've made comments here: https://codereview.chromium.org/2408143004
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7 commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7 Author: xjz <xjz@chromium.org> Date: Wed Oct 19 23:18:26 2016 Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future. BUG= 655240 Review-Url: https://chromiumcodereview.appspot.com/2432373003 Cr-Commit-Position: refs/heads/master@{#426327} [modify] https://crrev.com/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7/content/renderer/media/media_stream_video_capturer_source.cc [modify] https://crrev.com/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7/content/renderer/media/media_stream_video_capturer_source.h [modify] https://crrev.com/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7/content/renderer/media/media_stream_video_capturer_source_unittest.cc
,
Oct 20 2016
,
Oct 21 2016
Requesting to merge to M55. Low risk.
,
Oct 22 2016
Is this applicable to all os or any specific os?
,
Oct 22 2016
It is applicable to all os other than ios.
,
Oct 24 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b1c1094bb1e7e9918204064c14f2fd7688ae557 commit 6b1c1094bb1e7e9918204064c14f2fd7688ae557 Author: Yuri Wiitala <miu@chromium.org> Date: Mon Oct 24 21:52:54 2016 Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromium.org/2365223002. |running_callback_| is used as a callback when status changes, and should not be reset if the capture is successfully started. BUG= 655240 Review-Url: https://codereview.chromium.org/2408143004 Cr-Commit-Position: refs/heads/master@{#425124} (cherry picked from commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9) Review URL: https://codereview.chromium.org/2446803002 . Cr-Commit-Position: refs/branch-heads/2883@{#265} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/6b1c1094bb1e7e9918204064c14f2fd7688ae557/content/renderer/media/media_stream_video_capturer_source.cc
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4edd4994e815e13a5ce741fcf35111a465175e5 commit c4edd4994e815e13a5ce741fcf35111a465175e5 Author: Yuri Wiitala <miu@chromium.org> Date: Mon Oct 24 21:54:23 2016 Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future. BUG= 655240 Review-Url: https://chromiumcodereview.appspot.com/2432373003 Cr-Commit-Position: refs/heads/master@{#426327} (cherry picked from commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7) Review URL: https://codereview.chromium.org/2451473002 . Cr-Commit-Position: refs/branch-heads/2883@{#267} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.cc [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.h [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b1c1094bb1e7e9918204064c14f2fd7688ae557 commit 6b1c1094bb1e7e9918204064c14f2fd7688ae557 Author: Yuri Wiitala <miu@chromium.org> Date: Mon Oct 24 21:52:54 2016 Bug fix: stop mirroring session when tab is closed. Fix bug caused by cl: https://codereview.chromium.org/2365223002. |running_callback_| is used as a callback when status changes, and should not be reset if the capture is successfully started. BUG= 655240 Review-Url: https://codereview.chromium.org/2408143004 Cr-Commit-Position: refs/heads/master@{#425124} (cherry picked from commit a8e9c8591d8d5026c32d6d93bf11f0ff5096eee9) Review URL: https://codereview.chromium.org/2446803002 . Cr-Commit-Position: refs/branch-heads/2883@{#265} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/6b1c1094bb1e7e9918204064c14f2fd7688ae557/content/renderer/media/media_stream_video_capturer_source.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4edd4994e815e13a5ce741fcf35111a465175e5 commit c4edd4994e815e13a5ce741fcf35111a465175e5 Author: Yuri Wiitala <miu@chromium.org> Date: Mon Oct 24 21:54:23 2016 Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future. BUG= 655240 Review-Url: https://chromiumcodereview.appspot.com/2432373003 Cr-Commit-Position: refs/heads/master@{#426327} (cherry picked from commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7) Review URL: https://codereview.chromium.org/2451473002 . Cr-Commit-Position: refs/branch-heads/2883@{#267} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.cc [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source.h [modify] https://crrev.com/c4edd4994e815e13a5ce741fcf35111a465175e5/content/renderer/media/media_stream_video_capturer_source_unittest.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2016