New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655233 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocked on:
issue 659671
issue 659672

Blocking:
issue 578833



Sign in to add a comment

Implement watch/cancelWatchAvailability

Project Member Reported by avayvod@chromium.org, Oct 12 2016

Issue description

The current implementation is using getAvailability() and doesn't have a way to implement steps 4-5 of the algorithm (see https://w3c.github.io/remote-playback/#getting-the-remote-playback-devices-availability-information).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab7f8f63e07b15373ad84ff677244d70f5059e1

commit 6ab7f8f63e07b15373ad84ff677244d70f5059e1
Author: avayvod <avayvod@chromium.org>
Date: Tue Oct 18 05:51:50 2016

[Blink, RemotePlayback] watchAvailability() implementation.

BUG= 655233 
TEST=new layout tests + https://avayvod.github.io/remote-playback/test.html

Review-Url: https://codereview.chromium.org/2415723002
Cr-Commit-Position: refs/heads/master@{#425891}

[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html
[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/cancel-watch-availability.html
[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-cancel-watch-availability-throws.html
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-prompt-throws.html
[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/disable-remote-playback-watch-availability-throws.html
[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-initial-callback.html
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/bindings/modules/v8/custom/V8RemotePlaybackCustom.cpp
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/EventTargetModulesFactory.in
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/BUILD.gn
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.cpp
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.h
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.idl
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.idl
[delete] https://crrev.com/e285449e2f13d8bd0a931a6becdee1a0f2d2cb48/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp
[delete] https://crrev.com/e285449e2f13d8bd0a931a6becdee1a0f2d2cb48/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.h
[delete] https://crrev.com/e285449e2f13d8bd0a931a6becdee1a0f2d2cb48/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.idl
[modify] https://crrev.com/6ab7f8f63e07b15373ad84ff677244d70f5059e1/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

Blockedon: 659671
Blockedon: 659672
Status: Fixed (was: Started)

Sign in to add a comment