Stop uploading failing_results.json, just upload full_results.json. |
|||||
Issue descriptionRight now when arching layout test results, we archive both failing_results.json and full_results.json. These files' contents are mostly redundant. Other test suites besides layout tests generally use full_results.json. So if we move towards using just full_results.json for layout tests, and stop archiving failing_results.json then that would simplify things a little and make layout test results more consistent with other tests' test results. See http://crrev.com/2401623005 for some context.
,
Oct 12 2016
The only place that should continue using failing_results.json is https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/harness/results.html. In that case, we want to keep the more specific failure types (IMAGE, IMAGE+TEXT, AUDIO, TEXT) that we'll be collapsing down to FAIL in the more general full_results.json. We need the specifics in the former case so we can show the right UI for each failure.
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/32e8a2445eb9d63658dcab6fdc7e93edcdd04d90 commit 32e8a2445eb9d63658dcab6fdc7e93edcdd04d90 Author: qyearsley <qyearsley@chromium.org> Date: Thu Oct 13 16:49:40 2016 Update TODO comment about full_results.json in archive_layout_test_results.py. BUG=655202 Review-Url: https://codereview.chromium.org/2415543003 [modify] https://crrev.com/32e8a2445eb9d63658dcab6fdc7e93edcdd04d90/scripts/slave/chromium/archive_layout_test_results.py
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/de0bb8593f3c3ca6ad86252d755b0e773a65466d commit de0bb8593f3c3ca6ad86252d755b0e773a65466d Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Oct 13 17:05:40 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/32e8a2445eb9d63658dcab6fdc7e93edcdd04d90 Update TODO comment about full_results.json in archive_layout_test_results.py. (qyearsley@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=655202 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2408423006 [modify] https://crrev.com/de0bb8593f3c3ca6ad86252d755b0e773a65466d/infra/config/recipes.cfg
,
Oct 14 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e22f92fea14cffb851511b3bf1417c92f22336ad commit e22f92fea14cffb851511b3bf1417c92f22336ad Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Oct 14 21:41:49 2016
,
Mar 7 2017
,
Mar 9 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2018
I can still see "failing_results.json" in code search so I guess this issue is still valid. Marking it as available again.
,
Mar 13 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by qyears...@chromium.org
, Oct 12 2016