New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655166 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 581456
issue 649700



Sign in to add a comment

Add ability to compute text intercepts to GraphicsContext

Project Member Reported by drott@chromium.org, Oct 12 2016

Issue description

For text-decoration-skip: ink we need to have access to text intercepts, i.e. figuring out where the line decoration intersects with the glyph shapes.

Skia offers this functionality and we need to integrate it with our text and graphics code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1221f6b6b59f582f07f7042bd3780e6b375c733

commit b1221f6b6b59f582f07f7042bd3780e6b375c733
Author: drott <drott@chromium.org>
Date: Fri Oct 14 18:30:30 2016

Add ability to compute text intercepts to Font

For text-decoration-skip: ink we need to have access to text intercepts,
i.e. figuring out where the line decoration intersects with the glyph
shapes. Skia offers this functionality and we need to integrate it with
our text and graphics code.

BUG= 655166 

Review-Url: https://codereview.chromium.org/2416603002
Cr-Commit-Position: refs/heads/master@{#425394}

[modify] https://crrev.com/b1221f6b6b59f582f07f7042bd3780e6b375c733/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/b1221f6b6b59f582f07f7042bd3780e6b375c733/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/b1221f6b6b59f582f07f7042bd3780e6b375c733/third_party/WebKit/Source/platform/fonts/Font.h
[add] https://crrev.com/b1221f6b6b59f582f07f7042bd3780e6b375c733/third_party/WebKit/Source/platform/fonts/FontTest.cpp

Comment 2 by drott@chromium.org, Oct 17 2016

Status: Fixed (was: Started)

Sign in to add a comment