New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655159 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Inbox hijacks Ctrl-J --> downloads cannot be opened using shortcut key

Reported by mr.ber...@gmail.com, Oct 12 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Sofari/537.36

Steps to reproduce the problem:
1. Go to https://inbox.google.com/
2. Press "?"
3. Make sure shortcuts are on
4. Observe that the list does not contain Ctrl-J
5. Press Ctrl-J

What is the expected behavior?
Downloads open

What went wrong?
Next email is focused (which is consistent with the "J" shortcut)

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

Firefox does the same, so it might be an Inbox issue.

I have tried reproducing the issue with this, but I can't (j correctly shows an alert, ctrl-j correctly opens downloads):
<script src="https://craig.global.ssl.fastly.net/js/mousetrap/mousetrap.min.js"></script>
<script>Mousetrap.bind('j',function(e){window.alert('Hi');});</script>
 
Components: UI>Input>KeyboardShortcuts
The issue here sounds like which keystrokes the browsers allow in-browser Apps to intercept, and which they keep for themselves, rather than having anything to do specifically with downloads; adding a likely label.

Comment 2 by hdodda@chromium.org, Oct 13 2016

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Windows 10 using chrome stable 54.0.2840.59 .

Please check the attached screen cast and let us know if we have followed correct procedure to reproduce the issue. Steps tried to reproduce:

1. Navigated to https://inbox.google.com/
2. on "?" , shortcuts page opened and it is on.
3. on Ctrl+J , Downloads page is opened.

Thank You !
655159.mp4
928 KB View Download

Comment 3 by mr.ber...@gmail.com, Oct 13 2016

I agree, I guess it depends on where your focus is.
- Click into the "Search box" --> Ctrl-J correctly opens Downloads
- Click "New conversation" in Hangouts --> Ctrl-J correctly opens Downloads
- Select a conversation in Hangouts --> Ctrl-J correctly opens Downloads
- Have "?" open --> Ctrl-J correctly opens Downloads

But:
- Click "Inbox", "Snoozed" or anything in the left-side menu --> Ctrl-J does NOT open Downloads
- Click any email --> Ctrl-J does NOT open Downloads

So I guess "Ctrl-J" is bound by Inbox whenever "J" is bound by Inbox.

So to my original steps, I would like to add an additional step 3.5:

3.5. Dismiss the shortcuts help (Escape), click "Inbox" in the left-side menu

That should help you reproduce it. (Just a tiny bit of initiative would have got you there, too.)

Comment 4 by hdodda@chromium.org, Oct 14 2016

Unable to reproduce the issue on windows 10 using chrome stable 54.0.2840.59 , followed the below steps to reproduce:

1. Navigated to https://inbox.google.com/.
2. Clicked on Inbox/ Snoozed on the left side and on cntrl+J , downloads got opened.

Hence, issue is not reproduced.

Thank You!

Comment 5 by hdodda@chromium.org, Oct 14 2016

Screen cast attached for reference ..
655159 (1).mp4
659 KB View Download

Comment 6 by mr.ber...@gmail.com, Oct 14 2016

Assuming that you have followed these steps before starting the video, especially, step 3,

2. Press "?"
3. Make sure shortcuts are on
4. Observe that the list does not contain Ctrl-J
n. Dismiss the shortcuts help (Escape)

your steps look alright to me, and I agree the issue does not reproduce. I can still reproduce it, though, even in Firefox, and I don't see how I can improve my repro steps. Again, I assume you have keyboard shortcuts still on, because that does not show in the video in #c5.

Comment 7 by mr.ber...@gmail.com, Oct 16 2016

Also, the same issue does not reproduce on Gmail. Maybe the use a different technique to bind keys there, but Ctrl-J correctly opens "Downloads" even when shortcuts are active and "j"/"k" are being used to navigate between threads.
Cc: kavvaru@chromium.org
Components: Platform>Apps
Labels: -Needs-Feedback M-56 OS-Linux
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on windows 7,Ubuntu 14.04 using chrome version 54.0.2840.59 and canary 56.0.2891.0.
This is non regression issue as this is observed from M30 old builds.
Marking it as Untriaged to get more inputs from dev team.

Thanks,

Labels: pre-stable-54.0.2840.59

Comment 10 by woxxom@gmail.com, Nov 16 2016

Some browsers (chromium forks included) lower the priority of site hotkeys and always prefer browser hotkeys instead. It breaks usability on sites with rich keyboard interface. It's the worst with advanced javascript text editors that redefine a lot of hotkeys.

Chrome protects only the most important shortcuts by ignoring js method event.preventDefault(), apparently to avoid the user being trapped by a page: 
Ctrl-W to close current tab
Ctrl-N to create a new window
Ctrl-T to create a new tab

Currently, it's up to the inbox site to choose a better hotkey than Ctrl-J, which is used by many (most?) browsers to open Downloads.

In the future, it might be good to have a per-site permission to override browser hotkeys. Disabled by default, I guess.
I think part of the issue is that inbox assigns "J", which I would suppose does not necessarily have to interfere with "Ctrl-J" (at least that's how it works in Chrome on Windows: in a textarea, you can type "J" and still open downloads with "Ctrl-J"), but for some reason it DOES interfere. Whether that is due to Inbox being too greedy, or Chrome to little protective is impossible for me to decide. But I feel that there is no fundamental shortcut conflict at work here, different from what #10 implies.

Comment 12 by woxxom@gmail.com, Nov 16 2016

#11, ah so apparently the inbox site doesn't check for event.ctrlKey, and this is indeed the site's bug, not Chrome's.
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over a year.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment