WebglConformance_conformance2_rendering_blitframebuffer_filter_outofbounds failing on Linux AMD |
||||||||||
Issue descriptionAfter a WebGL roll including fixes to this tests, it started failing on: - Linux Release ATI - Linux Release New Intel (both command buffer, and ANGLE OpenGL backend) - Linux Release AMD R7 240
,
Oct 13 2016
I think this issue is a duplicate one with https://bugs.chromium.org/p/chromium/issues/detail?id=644740. And the fix has been submitted yesterday at https://codereview.chromium.org/2409523002. Could you take a look, Zhenyao and Corentin?
,
Oct 24 2016
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/49409 has https://codereview.chromium.org/2409523002, but still fails. Going to suppress this failure while it's being investigated.
,
Oct 24 2016
Are they still failing? The fix should have landed already.
,
Oct 24 2016
The fix didn't work.
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b73b48dee7cd47c37f8ff58a3c4461b28554c54c commit b73b48dee7cd47c37f8ff58a3c4461b28554c54c Author: ynovikov <ynovikov@chromium.org> Date: Tue Oct 25 01:35:32 2016 Suppress WebGL 2 conformance failures on Linux bots. BUG= 655147 , 658832 , 658842, 658844, 658898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2445973002 Cr-Commit-Position: refs/heads/master@{#427220} [modify] https://crrev.com/b73b48dee7cd47c37f8ff58a3c4461b28554c54c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Oct 25 2016
As my comments in https://bugs.chromium.org/p/chromium/issues/detail?id=658832. The failures for blitFramebuffer (default_framebuffer_00.html and blitframebuffer_filter_outofbounds.html and framebuffer_test.html) are two issues: 1) specific driver bug for Linux AMD (can anyone work on this? I have no Linux AMD machine, and it is not very suitable for Intel guys to fix AMD specific issue) 2) add some workaround in angle project(I suppose that Corentin is working on this), the logic of the workaround should be similar to this change for Mac and Linux Intel/AMD: https://codereview.chromium.org/2409523002. Please re-assign it to me if I can help.
,
Oct 25 2016
We will look at 1) (or just leave the suppression until we look closer at AMD). I will take care of 2), there's a couple things from your changes I still need to replicate.
,
Oct 25 2016
OK, thank you, @cwallez.
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c22bae95d9d3afc83ab83faec39227a09fe47fda commit c22bae95d9d3afc83ab83faec39227a09fe47fda Author: cwallez <cwallez@chromium.org> Date: Mon Nov 14 19:14:39 2016 WebGL CTS: remove now passing expectations. Most of them come from implementing a work around for blits on Intel. BUG= chromium:483282 BUG= chromium:598902 BUG= chromium:634525 BUG= chromium:655147 BUG= chromium:658898 BUG= chromium:658832 BUG= chromium:664180 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2501543003 Cr-Commit-Position: refs/heads/master@{#431891} [modify] https://crrev.com/c22bae95d9d3afc83ab83faec39227a09fe47fda/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Nov 15 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15 2017
We'll want to re-triage this.
,
Nov 16
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16
jdarpinian: Would you be able to confirm if this is still an issue? Thanks.
,
Nov 16
I've confirmed that the test is passing on Intel but still failing on Linux AMD. Because we are not planning to attempt a conformance run on Linux AMD I have not added this to our list of conformance bugs to fix.
,
Nov 16
,
Nov 16
Could we remove any remaining suppressions for Linux Intel, change the summary of this bug, and close this as WontFix? Perhaps we should add comments to the suppression file for WontFix'd bugs like this one, to save ourselves time when revisiting things.
,
Nov 17
All the Intel suppressions are removed. When we get Linux AMD bots with updated hardware we will reevaluate all the AMD test suppressions. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by zmo@chromium.org
, Oct 12 2016Status: Assigned (was: Available)