Regression: Omnibox url does not change to chrome://kill though page is killed.
Reported by
rk...@etouch.net,
Oct 12 2016
|
|||||||||
Issue descriptionChrome Version: 56.0.2888.0 (Official Build) 41c5c138b099891457c2e0cb965b8f24dacc403e-refs/heads/master@{#424625}-32/64 bit OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://version page. (2) Then click on omnibox and change url to chrome://kill(Page gets killed) (3) Observe omnibox url Actual: Omnibox url does not change to chrome://kill i.e. its shown chrome://version even after page gets killed. Expected: Omnibox url should change to chrome://kill. This is a regression issue, broken in 'M-55', will soon update the other info: Good Build: 55.0.2876.0 Bad Build: 55.0.2878.0
,
Oct 13 2016
,
Oct 14 2016
Adding RB label as this is a recent regression
,
Oct 14 2016
Hmm. I almost think we should not fix this, since chrome://kill is a command (similar to a JS URL), not a page. I discussed both sides of the issue in issue 541032 (comment 2), though, so I'm ok putting it back.
,
Oct 14 2016
I think Chrome's current behavior is probably more correct than leaving chrome://kill in the address bar when you kill something.
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b18f8385af6097264889f6e368bbd3b31c11b09 commit 0b18f8385af6097264889f6e368bbd3b31c11b09 Author: jam <jam@chromium.org> Date: Fri Oct 14 19:08:10 2016 Fix regression where navigating to debug URLs didn't update the omnibox. The regression test also exposed that this was broken with PlzNavigate, so fix that as well by not discarding pending entries when encountering navigation errors for debug URLs. This regressed in r422302. BUG= 655109 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2415173002 Cr-Commit-Position: refs/heads/master@{#425415} [modify] https://crrev.com/0b18f8385af6097264889f6e368bbd3b31c11b09/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/0b18f8385af6097264889f6e368bbd3b31c11b09/content/browser/frame_host/navigator_impl.cc
,
Oct 17 2016
,
Oct 17 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 17 2016
If possible, please merge your change to M55 branch 2883 before 4:00 PM PT today, Monday (10/17/16) in order to make to this week last M55 dev release before Beta promotion. Thank you.
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3b34968218a7f6223dd06069a267ad0a04a8504 commit c3b34968218a7f6223dd06069a267ad0a04a8504 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Oct 17 19:36:40 2016 Fix regression where navigating to debug URLs didn't update the omnibox. The regression test also exposed that this was broken with PlzNavigate, so fix that as well by not discarding pending entries when encountering navigation errors for debug URLs. This regressed in r422302. BUG= 655109 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2415173002 Cr-Commit-Position: refs/heads/master@{#425415} (cherry picked from commit 0b18f8385af6097264889f6e368bbd3b31c11b09) Review URL: https://codereview.chromium.org/2423243002 . Cr-Commit-Position: refs/branch-heads/2883@{#157} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c3b34968218a7f6223dd06069a267ad0a04a8504/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/c3b34968218a7f6223dd06069a267ad0a04a8504/content/browser/frame_host/navigator_impl.cc
,
Oct 17 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3b34968218a7f6223dd06069a267ad0a04a8504 commit c3b34968218a7f6223dd06069a267ad0a04a8504 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Oct 17 19:36:40 2016 Fix regression where navigating to debug URLs didn't update the omnibox. The regression test also exposed that this was broken with PlzNavigate, so fix that as well by not discarding pending entries when encountering navigation errors for debug URLs. This regressed in r422302. BUG= 655109 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2415173002 Cr-Commit-Position: refs/heads/master@{#425415} (cherry picked from commit 0b18f8385af6097264889f6e368bbd3b31c11b09) Review URL: https://codereview.chromium.org/2423243002 . Cr-Commit-Position: refs/branch-heads/2883@{#157} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c3b34968218a7f6223dd06069a267ad0a04a8504/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/c3b34968218a7f6223dd06069a267ad0a04a8504/content/browser/frame_host/navigator_impl.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbasuvula@chromium.org
, Oct 12 2016Labels: hasbisect-per-revision OS-Linux OS-Mac OS-Windows
Owner: jam@chromium.org
Status: Assigned (was: Unconfirmed)