Regression: Highlight vanishes on added rule while hovering on it. |
|||||||||||
Issue descriptionVersion: 54.0.2840.59 beta OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1) Launch chrome and open devtools on any page >> In elements tab from styles section click on "Add rule" >> Now without clicking hover on rule and observe Expected: Highlight should not vanish on hovering,it should vanish only after clicking elsewhere. Actual: Instead highlight vanishes while hovering on name of adding rule. This is a regression issue broken in M54. Good Build: 54.0.2804.0 dev Bad Build: 54.0.2805.0 dev
,
Oct 12 2016
Using the per-revision bisect providing the bisect results, Good build:54.0.2804.0(Revision: 407025). Bad build: 54.0.2805.0 (Revision:407311). You are probably looking for a change made after 407075 (known good), but no later than 407076 (first known bad). CHANGELOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/77c81222036bb21896fdec81724a154884c98f42..1ebd26d0dbc4c47ba9233f5e5c643eeb031afea2 From the CL above, assigning the issue to the concern owner @lushnikov - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Oct 12 2016
Please get this fixed before M55 hits beta.
,
Oct 13 2016
M55 Beta launch is coming VERY soon. Please try to have fix merged to M55 branch 2883 before 5:00 PM PT Monday, 10/17/16. Thank you.
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c541e81dfe2ed204f982aefbda2f5a1d02fc077 commit 1c541e81dfe2ed204f982aefbda2f5a1d02fc077 Author: lushnikov <lushnikov@chromium.org> Date: Thu Oct 13 20:50:39 2016 DevTools: [SSP] fix hoverable selectors We should initialize initial state of section so that it propogates to BlankPropertiesSection. BUG= 655086 R=dgozman Review-Url: https://codereview.chromium.org/2420513002 Cr-Commit-Position: refs/heads/master@{#425146} [modify] https://crrev.com/1c541e81dfe2ed204f982aefbda2f5a1d02fc077/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Oct 13 2016
,
Oct 14 2016
Verified the fix on the latest M-56(56.0.2890.0). This is working as intended on Windows-10, Mac OS 10.11.6 and Linux Ubuntu 14.04.
,
Oct 14 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4efefefbb5c684a83748abf46beeb5271d2b331d commit 4efefefbb5c684a83748abf46beeb5271d2b331d Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Fri Oct 14 23:38:21 2016 DevTools: [SSP] fix hoverable selectors We should initialize initial state of section so that it propogates to BlankPropertiesSection. BUG= 655086 R=dgozman Review-Url: https://codereview.chromium.org/2420513002 Cr-Commit-Position: refs/heads/master@{#425146} (cherry picked from commit 1c541e81dfe2ed204f982aefbda2f5a1d02fc077) Review URL: https://codereview.chromium.org/2424453003 . Cr-Commit-Position: refs/branch-heads/2883@{#126} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4efefefbb5c684a83748abf46beeb5271d2b331d/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Oct 14 2016
,
Oct 15 2016
lushnikov@, thanks for merging into M55 branch 2883.
,
Oct 18 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 55.0.2883.18.Highlight not vanished when hovering on the added rule. Please find the attached screen cast for the same. Adding TE-Verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4efefefbb5c684a83748abf46beeb5271d2b331d commit 4efefefbb5c684a83748abf46beeb5271d2b331d Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Fri Oct 14 23:38:21 2016 DevTools: [SSP] fix hoverable selectors We should initialize initial state of section so that it propogates to BlankPropertiesSection. BUG= 655086 R=dgozman Review-Url: https://codereview.chromium.org/2420513002 Cr-Commit-Position: refs/heads/master@{#425146} (cherry picked from commit 1c541e81dfe2ed204f982aefbda2f5a1d02fc077) Review URL: https://codereview.chromium.org/2424453003 . Cr-Commit-Position: refs/branch-heads/2883@{#126} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4efefefbb5c684a83748abf46beeb5271d2b331d/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kavvaru@chromium.org
, Oct 12 2016Status: Untriaged (was: Unconfirmed)