[MD settings]Unnecessary 'Credit card' option gets unchecked after clicking on 'Learn more' link
Reported by
jshan...@etouch.net,
Oct 12 2016
|
|||||
Issue descriptionChrome Version: 54.0.2840.59 5b2f167ccdaed3f1a90ec1084715fbb91b8d25b0-refs/branch-heads/2840@{#726} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) Steps: 1. Launch Chrome and sign to chrome with valid credential. 2. Navigate to chrome://md-settings/syncSetup and uncheck 'Sync everything'. 3. Now click on 'Learn more' link seen against 'Credit card' option (link opens in new tab) 4. Switch back to previous tab(Sync setting) and observe. Actual: Unnecessary 'Credit card' option gets unchecked after clicking on 'Learn more' link. Expected: 'Credit card' option should not get uncheck after clicking on 'Learn more' link. This is non-regression issue seen from M-53, since this is new feature introduced in 53.0.2770.0. Changelog url: https://chromium.googlesource.com/chromium/src/+log/53.0.2769.0..53.0.2770.0?pretty=fuller&n=10000 Suspecting: r400199 ?
,
Oct 17 2016
,
Nov 17 2016
,
Nov 19 2016
This is happening because the anchor tag is part of the check box's clickable content. I think we can fix it by stop-propagating the click at the anchor tag.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37cd8d80895f447c7b34da5178d5ac71edca9656 commit 37cd8d80895f447c7b34da5178d5ac71edca9656 Author: scottchen <scottchen@chromium.org> Date: Mon Nov 21 20:34:08 2016 MD Settings: In /syncSetup clicking links in checkbox label should not change checkbox value. There was a bug in which the clicks on anchor tags within the checkbox label will unintentionally alter the checkbox value. This patch fixes this issue by adding a listener with event.stopPropagate. BUG= 655069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2512323002 Cr-Commit-Position: refs/heads/master@{#433629} [modify] https://crrev.com/37cd8d80895f447c7b34da5178d5ac71edca9656/chrome/browser/resources/settings/people_page/sync_page.html [modify] https://crrev.com/37cd8d80895f447c7b34da5178d5ac71edca9656/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/37cd8d80895f447c7b34da5178d5ac71edca9656/chrome/test/data/webui/settings/people_page_sync_page_test.js
,
Nov 21 2016
,
Nov 21 2016
Issue 622676 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nyerramilli@chromium.org
, Oct 12 2016