New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655063 link

Starred by 3 users
Status: Fixed
Owner:
paulmeyer@chromium.org
Closed: Nov 2016
Cc:
ajha@chromium.org
█ nick@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
creis@chromium.org
azurewei@chromium.org
█ durga.behera@chromium.org
█ nasko@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 647249
Blocking:
issue 545200



Sign in to add a comment

Can not drag and drop images into Hangouts extension chat window

Reported by b...@haloassociates.co.uk, Oct 12 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2888.0 Safari/537.36

Steps to reproduce the problem:
1. Download Chrome Canary
2. Download Google Hangouts Extension
3. Open up a chat with someone. 
4. Find a locally saved image, and drag and drop the image into a chat window.

What is the expected behavior?
The image should be placed into the chat field, ready to send.

What went wrong?
The extension appears to close itself and the window.

Apon opening the hangout window again, no image is there.

WebStore page: https://chrome.google.com/webstore/detail/google-hangouts/nckgahadagoaajjgafhacjanaoiihapd?hl=en

Did this work before? Yes Before the latest hangouts update was released (material redesign update)

Chrome version: 56.0.2888.0  Channel: canary
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 23.0 r0

It works within normal Chrome (Version 53.0.2785.143 (64-bit))

Comment 1 by ligim...@chromium.org, Oct 12 2016

Labels: M-56 Needs-Bisect

Comment 2 by krajshree@chromium.org, Oct 13 2016

Labels: -Type-Bug -Pri-2 -Needs-Bisect M-55 hasbisect-per-revison Pri-1 Type-Bug-Regression
Owner: nasko@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04, Mac OS 10.11.6 using reported version #56.0.2888.0 and latest canary #56.0.2889.0.

Bisect Information:
=====================
Good build: 55.0.2841.0
Bad Build : 55.0.2842.2

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/5d6411a1a10652b1a3d9ced8d744f7e427918805..d8f0aefde00132b06bd97cb17555f2ec89a0c203

From the above change log suspecting below change

Review URL: https://codereview.chromium.org/2285883002

nasko@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 3 by krajshree@chromium.org, Oct 13 2016

Labels: -M-56

Comment 4 by krajshree@chromium.org, Oct 13 2016

Labels: OS-Linux OS-Windows

Comment 5 by nasko@chromium.org, Oct 13 2016

Cc: creis@chromium.org nick@chromium.org
Components: Internals>Sandbox>SiteIsolation
Yes, this is due to enabling Isolate Extensions in M55. It is known that drag'n'drop doesn't function with out-of-process iframes, which this feature utilizes.

Comment 6 by paulmeyer@chromium.org, Oct 24 2016

Cc: kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org azurewei@chromium.org ajha@chromium.org
 Issue 655092  has been merged into this issue.

Comment 7 by nasko@chromium.org, Oct 24 2016

Labels: Proj-IsolateExtensions-BlockingLaunch

Comment 8 by creis@chromium.org, Oct 25 2016

Blockedon: 647249
Cc: nasko@chromium.org
Owner: paulmeyer@chromium.org
Paul is working on drag n drop support for OOPIFs in  issue 647249 , which is needed to support this.

Comment 9 by creis@chromium.org, Oct 31 2016

Blocking: 545200
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef5a7989fc1b10c8b642863b74714585ebe845d

commit 6ef5a7989fc1b10c8b642863b74714585ebe845d
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue Nov 08 20:33:58 2016

Drag-and-drop: Move startDrag out of WebView/RenderView.

This patch is part of the effort to transition D&D functions to all be
widget-based instead of view-based. This is necessary in order to allow
D&D to work with out-of-process iframes.

BUG= 647249 ,  655063 

TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2475443003
Cr-Commit-Position: refs/heads/master@{#430701}

[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/plugins/renderer/webview_plugin.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_view_test_client.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_view_test_client.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_view_test_proxy.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_widget_test_client.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_widget_test_client.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/components/test_runner/web_widget_test_proxy.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/public/browser/render_widget_host.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/renderer/render_view_impl.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/renderer/render_view_impl.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/renderer/render_widget.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/renderer/render_widget.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/renderer/render_widget_owner_delegate.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/content/test/test_render_view_host.cc
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/third_party/WebKit/public/web/WebViewClient.h
[modify] https://crrev.com/6ef5a7989fc1b10c8b642863b74714585ebe845d/third_party/WebKit/public/web/WebWidgetClient.h
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f6c31d8095307a275eec336423e749ae6af956

commit 90f6c31d8095307a275eec336423e749ae6af956
Author: paulmeyer <paulmeyer@chromium.org>
Date: Sat Nov 12 00:17:59 2016

Drag-and-drop: Move DragEnter, DragOver, DragLeave, and DragDrop out of
WebView/RenderView.

This patch is part of the effort to transition D&D functions to all be
widget-based instead of view-based. This is necessary in order to allow
D&D to work with out-of-process iframes.

BUG= 647249 ,  655063 

Review-Url: https://codereview.chromium.org/2485693003
Cr-Commit-Position: refs/heads/master@{#431692}

[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/chrome/browser/ui/webui/webui_webview_browsertest.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/components/test_runner/event_sender.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/components/test_runner/event_sender.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/browser/web_contents/web_drag_dest_mac.mm
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/public/browser/render_view_host.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/public/browser/render_widget_host.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/renderer/render_view_impl.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/renderer/render_view_impl.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/renderer/render_widget.cc
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/content/renderer/render_widget.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebFrameWidgetBase.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebViewFrameWidget.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/90f6c31d8095307a275eec336423e749ae6af956/third_party/WebKit/public/web/WebView.h
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906

commit 7f6f1d4f12b96484ad238b5b0be7fd31d89e6906
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue Nov 15 00:00:27 2016

Drag-and-drop: Move updateDragCursor to RenderWidgetHost.

This patch is part of the effort to transition D&D functions to all be
widget-based instead of view-based. This is necessary in order to allow
D&D to work with out-of-process iframes.

BUG= 647249 ,  655063 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2503563002
Cr-Commit-Position: refs/heads/master@{#431997}

[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/browser_plugin/browser_plugin_embedder.h
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/7f6f1d4f12b96484ad238b5b0be7fd31d89e6906/content/browser/web_contents/web_contents_impl.h
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5

commit 8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue Nov 15 05:12:21 2016

Drag-and-drop: Move dragSourceEndedAt and dragSourceSystemDragEnded out
of WebView/RenderView.

This patch is part of the effort to transition D&D functions to all be
widget-based instead of view-based. This is necessary in order to allow
D&D to work with out-of-process iframes.

BUG= 647249 ,  655063 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2501213002
Cr-Commit-Position: refs/heads/master@{#432111}

[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/components/test_runner/event_sender.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/public/browser/render_view_host.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/public/browser/render_widget_host.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/renderer/render_view_impl.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/renderer/render_widget.cc
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/content/renderer/render_widget.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/Source/web/WebFrameWidgetBase.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/8fc8ea94ab9b37dc2fab2beeb6bff3180685d2d5/third_party/WebKit/public/web/WebView.h
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82b174cd84e9749ec642bfd5bc7805a41d6af0b

commit c82b174cd84e9749ec642bfd5bc7805a41d6af0b
Author: paulmeyer <paulmeyer@chromium.org>
Date: Thu Nov 17 01:45:37 2016

Drag-and-drop: Target drag messages to specific RenderWidgets.

This patch allows drag messages (like dragEnter, dragOver, dragEnd,
etc.) to be routed to the specific RenderWidgets they affect (rather
than always to the main frame widget). This is part of an ongoing
effort to allow D&D to work with out-of-process iframes.

BUG= 647249 ,  655063 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2505113002
Cr-Commit-Position: refs/heads/master@{#432688}

[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_mus.cc
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/browser/web_contents/web_contents_view_mus.h
[modify] https://crrev.com/c82b174cd84e9749ec642bfd5bc7805a41d6af0b/content/public/browser/render_widget_host.h
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c58c371878e696f904efd8e13886b23abd41eea

commit 0c58c371878e696f904efd8e13886b23abd41eea
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Thu Nov 17 22:59:51 2016

Drag-and-drop: Target drag messages (the sequel).

This patch follows up on https://codereview.chromium.org/2505113002/,
completing drag-and-drop targeting in a few remaining places, such as in
Mac-specific code as well as in WebContentsImpl::SystemDragEnded(). This
is part of an ongoing effort to allow D&D to work with out-of-process
iframes.

BUG= 647249 ,  655063 
R=avi@chromium.org, dcheng@chromium.org

Review URL: https://codereview.chromium.org/2509933002 .

Cr-Commit-Position: refs/heads/master@{#433003}

[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_drag_dest_mac.h
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_drag_dest_mac.mm
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_drag_source_mac.h
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_drag_source_mac.mm
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/browser/web_contents/web_drag_source_mac_unittest.mm
[modify] https://crrev.com/0c58c371878e696f904efd8e13886b23abd41eea/content/public/browser/web_contents.h
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90572ae460ace736685280a608590812abf6bc6a

commit 90572ae460ace736685280a608590812abf6bc6a
Author: paulmeyer <paulmeyer@chromium.org>
Date: Fri Nov 18 03:42:19 2016

Drag-and-drop across OOPIFs.

This patch enables drag-and-drop to work across out-of-process iframes.

BUG= 647249 ,  655063 

Review-Url: https://codereview.chromium.org/2508013002
Cr-Commit-Position: refs/heads/master@{#433068}

[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/core/page/DragController.h
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/WebFrameWidgetBase.h
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/90572ae460ace736685280a608590812abf6bc6a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Comment 17 by paulmeyer@chromium.org, Nov 18 2016

Status: Fixed (was: Assigned)

Comment 18 by dcheng@chromium.org, Nov 18 2016

Components: Blink>DataTransfer

Comment 19 by paulmeyer@chromium.org, Nov 18 2016

Labels: Merge-Request-56

Comment 20 by bustamante@google.com, Nov 18 2016

Labels: -Merge-Request-56 Merge-Approved-56
Approved as this was just hours after branch point and is needed to work with the CL in #15.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 18 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee134950d793e5cd43ecdb871639f2cb2cd67c9

commit 4ee134950d793e5cd43ecdb871639f2cb2cd67c9
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Fri Nov 18 22:14:18 2016

Drag-and-drop across OOPIFs.

This patch enables drag-and-drop to work across out-of-process iframes.

BUG= 647249 ,  655063 

Review-Url: https://codereview.chromium.org/2508013002
Cr-Commit-Position: refs/heads/master@{#433068}
(cherry picked from commit 90572ae460ace736685280a608590812abf6bc6a)

Review URL: https://codereview.chromium.org/2517653003 .

Cr-Commit-Position: refs/branch-heads/2924@{#6}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/core/page/DragController.h
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/WebFrameWidgetBase.h
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/4ee134950d793e5cd43ecdb871639f2cb2cd67c9/third_party/WebKit/Source/web/tests/WebViewTest.cpp
►

Sign in to add a comment