New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655062 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression : Animation is not seen properly while expanding/collapsing 'Advanced' options in chrome://md-settings.

Reported by mni...@etouch.net, Oct 12 2016

Issue description

Version: 54.0.2840.59 5b2f167ccdaed3f1a90ec1084715fbb91b8d25b0-refs/branch-heads/2840@{#726} (64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/passwords
2. Now click on 'Main Menu' button, click on 'Advanced' button twice and observe animation while expanding 'Advanced' options

Actual: Animation is not seen properly while expanding/collapsing 'Advanced' options.
Expected: Animation should be seen properly while expanding/collapsing 'Advanced' options.

This is regression issue, broken in ‘M 54’ and will soon update other info
Good build : 54.0.2820.0
Bad build : 54.0.2821.0
 
Actual_video.mov
3.3 MB Download
Expected_video.mov
1.3 MB Download

Comment 1 by hdodda@chromium.org, Oct 12 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:54.0.2820.0(Revision: 409955).
Bad build: 54.0.2822.0 (Revision:410267).

You are probably looking for a change made after 410227 (known good), but no later than 410228 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ae875419ff203324cd94c335695a7f9c0081e197..5b6b548e6ebc2374818b61e14cd315add717f71a

From the CL above, suspecting https://chromium.googlesource.com/chromium/src/+/911a4d605e2c485c0cc9547b084a9a3bd3c2e495

@tommycli - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2210933004

Thanks!




Labels: -M-54 M-55 ReleaseBlock-Beta
Please get this fixed before M55 hits beta.

Comment 3 by gov...@chromium.org, Oct 13 2016

M55 Beta launch is coming VERY soon. Please try to have fix merged to M55 branch 2883 before 5:00 PM PT Monday, 10/17/16. Thank you.

Comment 4 by dbeam@chromium.org, Oct 13 2016

Labels: -ReleaseBlock-Beta
Cc: dbeam@chromium.org michae...@chromium.org tommycli@chromium.org dschuyler@chromium.org
Owner: ----
Not caused by above CL.

It's a Performance / UI Jank issue.

Root cause is: We are now linking the left-navigation Advanced toggle state to the main page Advanced toggle state.

When we expand the Advanced menu on the left nav, it also triggers the main page's Advanced contents to render. That causes the left nav animation to stutter.

It's techincally correct... it's just slow.
Status: Available (was: Assigned)
How did you determine this was just stutter? Even at 10% speed the animation is very smooth (but wrong, as in the video).

The effect differs depending on which section is selected. Try the same with "Accessibility" and see how the sub-menu starts at "Accessibility". Looking at the Elements panel (tabindex changes), I wonder if this is a focus issue, maybe causing the sub-menu to "scroll" to the wrong place.
I stand corrected. Running it at 10% does show the animation being actually incorrect rather than an instance of UI Jank.

Thanks for the protip (Dev tools => 3 dot menu => More tools => Animations)
Status: WontFix (was: Available)
It appears that our menu is working as Polymer intended. The paper-submenu demo shows the same behavior - The expansion is indeed different depending on which sub-item is selected, and sometimes it looks funny.

https://elements.polymer-project.org/elements/paper-menu?view=demo:demo/index.html&active=paper-submenu

Marking tentatively as WONTFIX. Re-open and we'll have to file an upstream issue if we want paper-submenu to behave differently.
Status: Available (was: WontFix)
re-opening, since michaelpg points out it didn't used to look like this.
Labels: Proj-MaterialDesign-WebUI
Labels: -M-55 M-56
Moving Milestone to M56 as M55 is already in stable and issue is specific to Proj-MaterialDesign-WebUI.
Able to reproduce the issue on windows 7 using chrome version 57.0.2978.0.

Could any one from dev team please look into this issue.

Thanks,

Comment 13 by dbeam@chromium.org, Jan 12 2017

Blocking: 671375
Cc: -tommycli@chromium.org
Labels: -M-56 Hotlist-MD-Settings-General
Owner: tommycli@chromium.org
Status: Assigned (was: Available)
Status: WontFix (was: Assigned)
This looks right to me, closing.

Sign in to add a comment