Regression:[MD-Settings]Text beside the checkbox is slightly swifted upwards.
Reported by
dmascare...@etouch.net,
Oct 12 2016
|
|||||
Issue descriptionChrome Version:56.0.2887.0 (Official Build) 731c9896052c3824ec4630a1461738ecbccb16b5-refs/heads/master@{#424315} OS: Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/privacy. 2. Observe text beside the checkboxes. Actual:Text beside the checkbox is slightly swifted upwards. Expected:Text beside the checkbox should be proper. This is regression issue broken in 'M 56' and below is manual bisect: Good build:56.0.2886.0 Bad build:56.0.2887.0 Note: Will soon update the Linux OS Info.
,
Oct 12 2016
It is likely that my change affected it. Dave is the appropriate person to look into it, though.
,
Oct 12 2016
,
Oct 17 2016
Just a note in case someone else looks at this: My first guess is that the .secondary padding is pushing it up. This happened before and the css was modified to check whether the .secondary was :empty, that likely got broken or confused.
,
Oct 19 2016
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2 commit 3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2 Author: dschuyler <dschuyler@chromium.org> Date: Thu Oct 20 18:22:48 2016 [MD settings] content settings add site button; layout fixes This CL moves the 'Add site exception' button to an 'Add' button on the header line of the site exceptions. The filter for the site data has been moved into the list of sites. The remove all local cookie and storage button has been removed from the list of cookies (it's still available in the dialog). Also, the misalignment of .secondary text in checkboxes and content settings has been fixed. BUG= 654875 , 655036 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2429973003 Cr-Commit-Position: refs/heads/master@{#426536} [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/app/settings_strings.grdp [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_data.js [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/resources/settings/site_settings/site_settings_category.html [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2/chrome/test/data/webui/settings/site_list_tests.js
,
Oct 20 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hdodda@chromium.org
, Oct 12 2016Labels: hasbisect-per-revision OS-Linux
Owner: finnur@chromium.org