base::ObserverList works with range-based for loops now, so we should use that instead of the macro. It's more flexible and it usually looks nicer.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0694bae6c808bb107c1e1f4e72c4cc88685e2f commit 8f0694bae6c808bb107c1e1f4e72c4cc88685e2f Author: dcheng <dcheng@chromium.org> Date: Wed Oct 12 15:58:15 2016 Add PRESUBMIT to disallow new usage of FOR_EACH_OBSERVER. BUG= 655021 Review-Url: https://codereview.chromium.org/2417513002 Cr-Commit-Position: refs/heads/master@{#424752} [modify] https://crrev.com/8f0694bae6c808bb107c1e1f4e72c4cc88685e2f/PRESUBMIT.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e2934b8ab27cbab3c507df708a91c75c0ff19c6 commit 5e2934b8ab27cbab3c507df708a91c75c0ff19c6 Author: yusukes <yusukes@chromium.org> Date: Wed Oct 12 19:24:14 2016 Remove FOR_EACH_OBSERVER from arc/ since it's being deprecated BUG= 655021 TEST=try, ARC still starts Review-Url: https://codereview.chromium.org/2416633002 Cr-Commit-Position: refs/heads/master@{#424819} [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/components/arc/arc_bridge_bootstrap.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/components/arc/arc_bridge_service.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/components/arc/instance_holder.h [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/components/arc/intent_helper/link_handler_model_impl.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/components/arc/test/fake_arc_bridge_bootstrap.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/ui/arc/notification/arc_custom_notification_item.cc [modify] https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6/ui/arc/notification/arc_notification_surface_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b787f9b3c7e6237a0535211f40b37b9989021a4 commit 6b787f9b3c7e6237a0535211f40b37b9989021a4 Author: dcheng <dcheng@chromium.org> Date: Wed Oct 12 23:54:47 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //ipc. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2412483008 Cr-Commit-Position: refs/heads/master@{#424912} [modify] https://crrev.com/6b787f9b3c7e6237a0535211f40b37b9989021a4/ipc/ipc_test_sink.cc
I'm working on ui/base/models.
I have a bunch of CLs in flight to get rid of GetNext(). They should all be able to land within the next day or two, and then we can focus on getting rid of FOR_EACH_OBSERVER.
https://codereview.chromium.org/2414453006
I'll do ui/compositor/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f2c0c22727611cc5f812c7597522d0fcf769c66 commit 9f2c0c22727611cc5f812c7597522d0fcf769c66 Author: dcheng <dcheng@chromium.org> Date: Thu Oct 13 01:24:55 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //components/renderer_context_menu. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2410893006 Cr-Commit-Position: refs/heads/master@{#424928} [modify] https://crrev.com/9f2c0c22727611cc5f812c7597522d0fcf769c66/components/renderer_context_menu/render_view_context_menu_base.cc
I made https://docs.google.com/spreadsheets/d/14u7dpq7NcBTtQj3hhEOrnA5Eq3Q9N_ON4w9pLCLC2cI/edit#gid=0 to track this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d41ce0ce55bb756c85f63c94ddac80d35badedd0 commit d41ce0ce55bb756c85f63c94ddac80d35badedd0 Author: dcheng <dcheng@chromium.org> Date: Thu Oct 13 06:10:20 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //device. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2418653002 Cr-Commit-Position: refs/heads/master@{#424965} [modify] https://crrev.com/d41ce0ce55bb756c85f63c94ddac80d35badedd0/device/generic_sensor/platform_sensor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f239a9796979beb7984664eac50b1c49bcfd14 commit d4f239a9796979beb7984664eac50b1c49bcfd14 Author: vabr <vabr@chromium.org> Date: Thu Oct 13 09:17:37 2016 Remove FOR_EACH_OBSERVER from autofill and password_manager components According to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/udrb7JoPdiY/zxK09HZlAAAJ, the FOR_EACH_OBSERVER macro is now deprecated and should be replaced by range-based for loops. This CL achieves that goal for the autofill and password_manager components. The referenced bug also tracks adding a presubmit script to avoid regressions in the future. The presubmit check is not part of this CL. BUG= 655021 Review-Url: https://codereview.chromium.org/2412073003 Cr-Commit-Position: refs/heads/master@{#424987} [modify] https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc [modify] https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14/components/autofill/core/browser/webdata/autofill_webdata_service.cc [modify] https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14/components/password_manager/core/browser/log_router.cc [modify] https://crrev.com/d4f239a9796979beb7984664eac50b1c49bcfd14/components/password_manager/core/browser/password_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e59e943420412def899ad2bbf7a496050071b549 commit e59e943420412def899ad2bbf7a496050071b549 Author: avi <avi@chromium.org> Date: Thu Oct 13 15:37:26 2016 Remove stl_util's deletion functions from tab_strip_model, and do other modernization. BUG= 555865 , 655021 Review-Url: https://codereview.chromium.org/2411113003 Cr-Commit-Position: refs/heads/master@{#425041} [modify] https://crrev.com/e59e943420412def899ad2bbf7a496050071b549/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/e59e943420412def899ad2bbf7a496050071b549/chrome/browser/ui/tabs/tab_strip_model.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2d442c2aaafb39b866d324b7706e40597320ea3 commit a2d442c2aaafb39b866d324b7706e40597320ea3 Author: dcheng <dcheng@chromium.org> Date: Thu Oct 13 15:39:21 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //content. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2410283004 Cr-Commit-Position: refs/heads/master@{#425043} [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/public/test/mock_render_thread.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/renderer/render_frame_impl.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/renderer/render_thread_impl.cc [modify] https://crrev.com/a2d442c2aaafb39b866d324b7706e40597320ea3/content/renderer/render_view_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea68766deda7cb89f2f08e1ca816f9666a95c3bd commit ea68766deda7cb89f2f08e1ca816f9666a95c3bd Author: dcheng <dcheng@chromium.org> Date: Thu Oct 13 16:59:52 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //chrome. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2416533003 Cr-Commit-Position: refs/heads/master@{#425066} [modify] https://crrev.com/ea68766deda7cb89f2f08e1ca816f9666a95c3bd/chrome/browser/task_manager/task_manager_interface.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1e9c58586fa4cc980defdd1dc72d2b5e15277cae commit 1e9c58586fa4cc980defdd1dc72d2b5e15277cae Author: sdefresne <sdefresne@google.com> Date: Thu Oct 13 18:11:00 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d38152e1420a5ee6dcf4768a8254da959045307a commit d38152e1420a5ee6dcf4768a8254da959045307a Author: dcheng <dcheng@chromium.org> Date: Thu Oct 13 18:21:37 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //ui. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2414863002 Cr-Commit-Position: refs/heads/master@{#425094} [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/aura/window.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/compositor/layer_animation_sequence.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/compositor/layer_animator.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/events/platform/platform_event_source.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/events/platform/x11/x11_event_source_libevent.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/views/mus/pointer_watcher_event_router.cc [modify] https://crrev.com/d38152e1420a5ee6dcf4768a8254da959045307a/ui/wm/core/compound_event_filter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ebab277cd6641cc047072c8c8677d1408aa8e89 commit 7ebab277cd6641cc047072c8c8677d1408aa8e89 Author: yusukes <yusukes@chromium.org> Date: Thu Oct 13 21:06:21 2016 Replace FOR_EACH_OBSERVER in c/b/chromeos with range-based for BUG= 655021 TEST=try, git grep FOR_EACH_OBSERVER c/b/chromeos Review-Url: https://codereview.chromium.org/2416763002 Cr-Commit-Position: refs/heads/master@{#425153} [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/camera_presence_notifier.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/device/input_service_proxy.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/drive/drive_integration_service.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/file_system_provider/provided_file_system.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/file_system_provider/request_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/file_system_provider/service.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/first_run/drive_first_run_controller.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/input_method/mock_candidate_window_controller.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/ui/user_adding_screen.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/mobile/mobile_activator.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/net/network_portal_detector_impl.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/options/cert_library.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/policy/device_local_account_policy_service.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/policy/user_network_configuration_updater.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/settings/device_settings_service.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/system/automatic_reboot_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/system/device_disabling_manager.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/system/pointer_device_observer.cc [modify] https://crrev.com/7ebab277cd6641cc047072c8c8677d1408aa8e89/chrome/browser/chromeos/system/system_clock.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5319f19e04605ea292a54070d7065e53522d7b8 commit b5319f19e04605ea292a54070d7065e53522d7b8 Author: tfarina <tfarina@chromium.org> Date: Fri Oct 14 00:35:09 2016 ui/base/models: convert usage of FOR_EACH_OBSERVER macro ObserverList now supports range-based for loops and thus this can be used to iterate through a list of observers as the FOR_EACH_OBSERVER macro was deprecated. BUG= 655021 TEST=ui_base_unittests R=sky@chromium.org Review-Url: https://codereview.chromium.org/2414453006 Cr-Commit-Position: refs/heads/master@{#425216} [modify] https://crrev.com/b5319f19e04605ea292a54070d7065e53522d7b8/ui/base/models/list_model.h [modify] https://crrev.com/b5319f19e04605ea292a54070d7065e53522d7b8/ui/base/models/tree_node_model.h
Working on ui/views.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ec6a6fc99af367856742f4a55cd916e13002759 commit 9ec6a6fc99af367856742f4a55cd916e13002759 Author: loyso <loyso@chromium.org> Date: Fri Oct 14 01:16:36 2016 Remove usage of FOR_EACH_OBSERVER macro in ui/compositor/. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2417613003 Cr-Commit-Position: refs/heads/master@{#425228} [modify] https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759/ui/compositor/compositor.cc [modify] https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759/ui/compositor/compositor_vsync_manager.cc [modify] https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759/ui/compositor/layer.cc [modify] https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759/ui/compositor/layer_animation_sequence.cc [modify] https://crrev.com/9ec6a6fc99af367856742f4a55cd916e13002759/ui/compositor/test/in_process_context_factory.cc
https://codereview.chromium.org/2418983002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fae50227c1e5ded8422e2bada33cc651b268663 commit 9fae50227c1e5ded8422e2bada33cc651b268663 Author: dcheng <dcheng@chromium.org> Date: Fri Oct 14 03:21:04 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //ppapi. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2419663003 Cr-Commit-Position: refs/heads/master@{#425246} [modify] https://crrev.com/9fae50227c1e5ded8422e2bada33cc651b268663/ppapi/proxy/ppapi_proxy_test.cc
c#22, tfarina@ - we have a spreadsheet to avoid collisions https://docs.google.com/spreadsheets/d/14u7dpq7NcBTtQj3hhEOrnA5Eq3Q9N_ON4w9pLCLC2cI/edit#gid=0 I did ui/views too.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/033378b487d7dc1aeccaff510b92559d4b0c8f5a commit 033378b487d7dc1aeccaff510b92559d4b0c8f5a Author: loyso <loyso@chromium.org> Date: Fri Oct 14 04:24:54 2016 Remove usage of FOR_EACH_OBSERVER macro in ui/wm/. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2416963006 Cr-Commit-Position: refs/heads/master@{#425253} [modify] https://crrev.com/033378b487d7dc1aeccaff510b92559d4b0c8f5a/ui/wm/core/cursor_manager.cc [modify] https://crrev.com/033378b487d7dc1aeccaff510b92559d4b0c8f5a/ui/wm/core/default_activation_client.cc [modify] https://crrev.com/033378b487d7dc1aeccaff510b92559d4b0c8f5a/ui/wm/core/focus_controller.cc [modify] https://crrev.com/033378b487d7dc1aeccaff510b92559d4b0c8f5a/ui/wm/core/transient_window_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06 commit 725a3dbcf54b79a10d1eba8f8164f7e22d4dab06 Author: tfarina <tfarina@chromium.org> Date: Fri Oct 14 16:49:01 2016 ui/views: convert usage of FOR_EACH_OBSERVER macro ObserverList now supports range-based for loops and thus this can be used to iterate through a list of observers as the FOR_EACH_OBSERVER macro was deprecated. This patch was generated by the following command line: $ cd ui/views $ perl -0777 -pi -e 's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for (\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq) And then manually inspected for line indentation fixes. BUG= 655021 TEST=views_unittests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2418983002 Cr-Commit-Position: refs/heads/master@{#425359} [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/animation/bounds_animator.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/focus/focus_manager.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/focus/widget_focus_manager.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/mus/pointer_watcher_event_router.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/widget/desktop_aura/x11_desktop_handler.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/widget/widget.cc [modify] https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06/ui/views/win/windows_session_change_observer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1 commit 5c5793146c75f6f720e1ff5bcd01752ae7cb05b1 Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 14 20:07:33 2016 Remove usage of FOR_EACH_OBSERVER macro in ash/common Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2414303002 Cr-Commit-Position: refs/heads/master@{#425443} [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/shelf/shelf_background_animator.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/shelf/shelf_button.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/shelf/shelf_model.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/shelf/wm_shelf.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/system/chromeos/network/vpn_delegate.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/system/chromeos/power/power_status.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/system/tray/system_tray_notifier.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/wm/dock/docked_window_layout_manager.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/wm/window_state.cc [modify] https://crrev.com/5c5793146c75f6f720e1ff5bcd01752ae7cb05b1/ash/common/wm_shell.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef4a9037f628f79c406b28e199ffaff192e3f299 commit ef4a9037f628f79c406b28e199ffaff192e3f299 Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 14 20:08:35 2016 Remove usage of FOR_EACH_OBSERVER macro in mojo Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2418043002 Cr-Commit-Position: refs/heads/master@{#425444} [modify] https://crrev.com/ef4a9037f628f79c406b28e199ffaff192e3f299/mojo/edk/js/handle.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ce34a01bdadbeeec6ed4469574351eae9a7764 commit 92ce34a01bdadbeeec6ed4469574351eae9a7764 Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 14 20:49:05 2016 Remove usage of FOR_EACH_OBSERVER macro in ash/aura Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2420863002 Cr-Commit-Position: refs/heads/master@{#425459} [modify] https://crrev.com/92ce34a01bdadbeeec6ed4469574351eae9a7764/ash/aura/pointer_watcher_adapter.cc [modify] https://crrev.com/92ce34a01bdadbeeec6ed4469574351eae9a7764/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/92ce34a01bdadbeeec6ed4469574351eae9a7764/ash/aura/wm_window_aura.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/262cf7e2ec101f26d00da06958854f85c4cca368 commit 262cf7e2ec101f26d00da06958854f85c4cca368 Author: yusukes <yusukes@chromium.org> Date: Fri Oct 14 20:56:53 2016 Replace FOR_EACH_OBSERVER in chromeos/ with range-based for BUG= 655021 TEST=try, git grep FOR_EACH_OBSERVER chromeos/ Review-Url: https://codereview.chromium.org/2413963002 Cr-Commit-Position: refs/heads/master@{#425461} [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/audio/audio_devices_pref_handler_impl.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/cert_loader.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/cras_audio_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_cras_audio_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_power_manager_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_session_manager_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_shill_device_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_shill_service_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/fake_update_engine_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/power_manager_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/session_manager_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/shill_client_helper.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/system_clock_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/dbus/update_engine_client.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/disks/disk_mount_manager.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/disks/mock_disk_mount_manager.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/login/login_state.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/client_cert_resolver.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/managed_network_configuration_handler_impl.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/network_connection_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/network_profile_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/network_sms_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/network/network_state_handler.cc [modify] https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368/chromeos/settings/timezone_settings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e67b103db4db5c11c52ef9e27254453c80882b1 commit 0e67b103db4db5c11c52ef9e27254453c80882b1 Author: dcheng <dcheng@chromium.org> Date: Fri Oct 14 21:16:41 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //remoting. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2415753002 Cr-Commit-Position: refs/heads/master@{#425463} [modify] https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1/remoting/host/register_support_host_request_unittest.cc [modify] https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1/remoting/signaling/delegating_signal_strategy.cc [modify] https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1/remoting/signaling/fake_signal_strategy.cc [modify] https://crrev.com/0e67b103db4db5c11c52ef9e27254453c80882b1/remoting/signaling/xmpp_signal_strategy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/018341c1b436b105874d589bbc1b0c8b6a8a1f9e commit 018341c1b436b105874d589bbc1b0c8b6a8a1f9e Author: dcheng <dcheng@chromium.org> Date: Fri Oct 14 21:53:56 2016 Remove usage of base::ObserverList<T>::Iter::GetNext() in //components/prefs. Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2415793002 Cr-Commit-Position: refs/heads/master@{#425480} [modify] https://crrev.com/018341c1b436b105874d589bbc1b0c8b6a8a1f9e/components/prefs/pref_notifier_impl.cc [modify] https://crrev.com/018341c1b436b105874d589bbc1b0c8b6a8a1f9e/components/prefs/pref_notifier_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9dd01442c877d2f76cf750e7b52a59caba4b22b commit c9dd01442c877d2f76cf750e7b52a59caba4b22b Author: dcheng <dcheng@chromium.org> Date: Sat Oct 15 05:43:19 2016 Remove base::ObserverList<T>::Iter::GetNext(). Observer lists now support range-based for loops. BUG= 655021 R=danakj@chromium.org TBR=marq@chromium.org,sky@chromium.org Review-Url: https://codereview.chromium.org/2419673003 Cr-Commit-Position: refs/heads/master@{#425549} [modify] https://crrev.com/c9dd01442c877d2f76cf750e7b52a59caba4b22b/base/observer_list.h [modify] https://crrev.com/c9dd01442c877d2f76cf750e7b52a59caba4b22b/base/observer_list_threadsafe.h [modify] https://crrev.com/c9dd01442c877d2f76cf750e7b52a59caba4b22b/base/observer_list_unittest.cc [modify] https://crrev.com/c9dd01442c877d2f76cf750e7b52a59caba4b22b/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/c9dd01442c877d2f76cf750e7b52a59caba4b22b/ui/base/win/osk_display_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fcc0a7a476a0c2adc3e95e8e846d7253b8c38b8 commit 4fcc0a7a476a0c2adc3e95e8e846d7253b8c38b8 Author: ericwilligers <ericwilligers@chromium.org> Date: Sat Oct 15 22:00:21 2016 Reduce FOR_EACH_OBSERVER usage in ppapi Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2413313005 Cr-Commit-Position: refs/heads/master@{#425574} [modify] https://crrev.com/4fcc0a7a476a0c2adc3e95e8e846d7253b8c38b8/ppapi/proxy/host_dispatcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d54a2ec95d7c59e6ebf65dd07de3e30cba882bd0 commit d54a2ec95d7c59e6ebf65dd07de3e30cba882bd0 Author: ericwilligers <ericwilligers@chromium.org> Date: Sat Oct 15 22:01:41 2016 Remove usage of FOR_EACH_OBSERVER macro in chromecast Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422853002 Cr-Commit-Position: refs/heads/master@{#425575} [modify] https://crrev.com/d54a2ec95d7c59e6ebf65dd07de3e30cba882bd0/chromecast/graphics/cast_vsync_settings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a60549cd31bee65971319a1afd1cae62f8e7fa07 commit a60549cd31bee65971319a1afd1cae62f8e7fa07 Author: ericwilligers <ericwilligers@chromium.org> Date: Sun Oct 16 00:09:05 2016 Reduce usage of FOR_EACH_OBSERVER macro in base Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2418933004 Cr-Commit-Position: refs/heads/master@{#425580} [modify] https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07/base/memory/memory_pressure_listener.cc [modify] https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07/base/message_loop/message_loop.cc [modify] https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07/base/observer_list_unittest.cc [modify] https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07/base/process/port_provider_mac.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5517050cb3a120f0b98cc46ee4f07dcc4df0a280 commit 5517050cb3a120f0b98cc46ee4f07dcc4df0a280 Author: ericwilligers <ericwilligers@chromium.org> Date: Sun Oct 16 20:47:07 2016 Remove usage of FOR_EACH_OBSERVER macro in mash/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2423733002 Cr-Commit-Position: refs/heads/master@{#425595} [modify] https://crrev.com/5517050cb3a120f0b98cc46ee4f07dcc4df0a280/mash/browser/browser.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53 commit 6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 01:35:08 2016 Reduce usage of FOR_EACH_OBSERVER macro in content/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422933002 Cr-Commit-Position: refs/heads/master@{#425603} [modify] https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53/content/child/worker_thread_registry.cc [modify] https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53/content/public/test/mock_download_item.cc [modify] https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd556481d2bcd71877cd7d86276177f0978df052 commit dd556481d2bcd71877cd7d86276177f0978df052 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 03:36:35 2016 Remove FOR_EACH_OBSERVER macro usage in chrome/browser/sync_file_system Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2425553002 Cr-Commit-Position: refs/heads/master@{#425613} [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/drive_backend/sync_engine.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/drive_backend/sync_worker.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/local/local_file_sync_context.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/local/local_file_sync_service.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/local/local_file_sync_status.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/mock_remote_file_sync_service.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/sync_file_system_service.cc [modify] https://crrev.com/dd556481d2bcd71877cd7d86276177f0978df052/chrome/browser/sync_file_system/task_logger.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9f4516076a6e3a3b4b8043347e613f5cc59165e commit e9f4516076a6e3a3b4b8043347e613f5cc59165e Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 04:29:17 2016 Remove usage of FOR_EACH_OBSERVER macro in services/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2424613002 Cr-Commit-Position: refs/heads/master@{#425615} [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/navigation/public/cpp/view.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/public/cpp/input_devices/input_device_client.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/public/cpp/window.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/ws/animation_runner.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/ws/focus_controller.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/ws/server_window.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/ws/user_id_tracker.cc [modify] https://crrev.com/e9f4516076a6e3a3b4b8043347e613f5cc59165e/services/ui/ws/window_manager_window_tree_factory_set.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86 commit e092a95ec32bc04e0dab4537b7d486e8ab1a0f86 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 05:19:11 2016 Reduce FOR_EACH_OBSERVER usage in content/browser/service_worker Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2418373002 Cr-Commit-Position: refs/heads/master@{#425619} [modify] https://crrev.com/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86/content/browser/service_worker/service_worker_registration.cc [modify] https://crrev.com/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86/content/browser/service_worker/service_worker_version.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e commit dc7ddf145e6c0b3c77c54744d7f68216264d7c0e Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 08:25:47 2016 Remove usage of FOR_EACH_OBSERVER macro in components/policy Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422083002 Cr-Commit-Position: refs/heads/master@{#425633} [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/browser/configuration_policy_pref_store.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/cloud/cloud_policy_client.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/cloud/cloud_policy_core.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/cloud/cloud_policy_service.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/cloud/cloud_policy_store.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/configuration_policy_provider.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/policy_service_impl.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/remote_commands/remote_commands_queue.cc [modify] https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e/components/policy/core/common/schema_registry.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/254597bee97c1289d67dce3f228cfe88b533e85b commit 254597bee97c1289d67dce3f228cfe88b533e85b Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 10:32:31 2016 Reduce usage of FOR_EACH_OBSERVER macro in content/browser Observer lists now support range-based for loops. BUG= 655021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2422923002 Cr-Commit-Position: refs/heads/master@{#425648} [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/appcache/appcache_group.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/appcache/appcache_host.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/appcache/appcache_service_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/dom_storage/dom_storage_context_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/download/download_item_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/frame_host/frame_tree_node.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/notification_service_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/site_instance_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/tracing/tracing_controller_impl.cc [modify] https://crrev.com/254597bee97c1289d67dce3f228cfe88b533e85b/content/browser/webrtc/webrtc_internals.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/061fa6fc79808afd84bc34ca2e6d9e8ae7e21785 commit 061fa6fc79808afd84bc34ca2e6d9e8ae7e21785 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 11:22:38 2016 Remove usage of FOR_EACH_OBSERVER macro in gin Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2417423002 Cr-Commit-Position: refs/heads/master@{#425657} [modify] https://crrev.com/061fa6fc79808afd84bc34ca2e6d9e8ae7e21785/gin/modules/module_registry.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8f5859c1d467cb68e81bacbfe9c22841e8e59ee commit d8f5859c1d467cb68e81bacbfe9c22841e8e59ee Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 12:06:43 2016 Remove usage of FOR_EACH_OBSERVER macro in platform/scheduler Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2420303002 Cr-Commit-Position: refs/heads/master@{#425658} [modify] https://crrev.com/d8f5859c1d467cb68e81bacbfe9c22841e8e59ee/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc [modify] https://crrev.com/d8f5859c1d467cb68e81bacbfe9c22841e8e59ee/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19 commit eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19 Author: yusukes <yusukes@chromium.org> Date: Mon Oct 17 17:20:28 2016 Replace FOR_EACH_OBSERVER in c/b/ui/app_list with range-based for BUG= 655021 TEST=try, git grep FOR_EACH_OBSERVER c/b/ui/app_list Review-Url: https://codereview.chromium.org/2424563002 Cr-Commit-Position: refs/heads/master@{#425708} [modify] https://crrev.com/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19/chrome/browser/ui/app_list/app_list_syncable_service.cc [modify] https://crrev.com/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19/chrome/browser/ui/app_list/start_page_service.cc [modify] https://crrev.com/eb6c5349cf9dc4b3a37c8c050e0fa6fa929e1f19/chrome/browser/ui/app_list/test/fake_profile_store.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec commit 4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec Author: yusukes <yusukes@chromium.org> Date: Mon Oct 17 17:42:27 2016 Replace FOR_EACH_OBSERVER in components/drive with range-based for BUG= 655021 TEST=try, git grep FOR_EACH_OBSERVER components/drive Review-Url: https://codereview.chromium.org/2421083002 Cr-Commit-Position: refs/heads/master@{#425717} [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/chromeos/change_list_loader.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/chromeos/directory_loader.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/chromeos/file_system.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/drive_app_registry.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/drive_notification_manager.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/job_scheduler.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/service/drive_api_service.cc [modify] https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec/components/drive/service/fake_drive_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f50484f7c534e731522341bdede48b3712973b8 commit 0f50484f7c534e731522341bdede48b3712973b8 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 18:57:11 2016 Remove usage of FOR_EACH_OBSERVER macro in components/signin Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422943002 Cr-Commit-Position: refs/heads/master@{#425737} [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/about_signin_internals.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/fake_signin_manager.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/gaia_cookie_manager_service.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/signin_error_controller.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/0f50484f7c534e731522341bdede48b3712973b8/components/signin/core/browser/signin_manager_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eff47d40c77f3b32269da49e144fe4836429a33 commit 5eff47d40c77f3b32269da49e144fe4836429a33 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:19:18 2016 Remove usage of FOR_EACH_OBSERVER macro in ash/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2421853003 Cr-Commit-Position: refs/heads/master@{#425741} [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/common/keyboard/keyboard_ui.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/display/display_manager.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/first_run/first_run_helper_impl.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/mus/keyboard_ui_mus.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/mus/window_manager.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/shell.cc [modify] https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33/ash/wm/video_detector.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/741d9665244b69173a34ddc8a6c1ecf5c9dc188f commit 741d9665244b69173a34ddc8a6c1ecf5c9dc188f Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:24:15 2016 Remove usage of FOR_EACH_OBSERVER macro in ui/app_list Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422873002 Cr-Commit-Position: refs/heads/master@{#425746} [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/app_list_item.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/app_list_item_list.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/app_list_model.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/folder_image.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/pagination_model.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/search/history_data.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/search_box_model.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/search_result.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/speech_ui_model.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f/ui/app_list/views/top_icon_animation_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e commit 88e697452a8b5c05b5a54d8acfdd221e1ca78d6e Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:29:55 2016 Remove usage of FOR_EACH_OBSERVER macro in content/renderer Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2416153005 Cr-Commit-Position: refs/heads/master@{#425747} [modify] https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e/content/renderer/pepper/plugin_instance_throttler_impl.cc [modify] https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e/content/renderer/render_frame_impl.cc [modify] https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e/content/renderer/render_thread_impl.cc [modify] https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e/content/renderer/render_view_impl.cc [modify] https://crrev.com/88e697452a8b5c05b5a54d8acfdd221e1ca78d6e/content/renderer/render_widget.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfd9e46ec6757c9285ad9d7365651b461e5a6b19 commit dfd9e46ec6757c9285ad9d7365651b461e5a6b19 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:38:17 2016 Remove usage of FOR_EACH_OBSERVER macro in ui/message_center Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2424603002 Cr-Commit-Position: refs/heads/master@{#425749} [modify] https://crrev.com/dfd9e46ec6757c9285ad9d7365651b461e5a6b19/ui/message_center/message_center_impl.cc [modify] https://crrev.com/dfd9e46ec6757c9285ad9d7365651b461e5a6b19/ui/message_center/notification_blocker.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/852c97af1b95c322684ed412e2ea9dbd3c092bd2 commit 852c97af1b95c322684ed412e2ea9dbd3c092bd2 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:46:11 2016 Remove usage of FOR_EACH_OBSERVER macro in gpu Observer lists now support range-based for loops. BUG= 655021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2414153005 Cr-Commit-Position: refs/heads/master@{#425753} [modify] https://crrev.com/852c97af1b95c322684ed412e2ea9dbd3c092bd2/gpu/command_buffer/service/shader_translator.cc [modify] https://crrev.com/852c97af1b95c322684ed412e2ea9dbd3c092bd2/gpu/ipc/client/command_buffer_proxy_impl.cc [modify] https://crrev.com/852c97af1b95c322684ed412e2ea9dbd3c092bd2/gpu/ipc/service/gpu_command_buffer_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0abdc20ecc4456af20381bdb5578129f96f70e4 commit e0abdc20ecc4456af20381bdb5578129f96f70e4 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:47:10 2016 Remove usage of FOR_EACH_OBSERVER macro in storage Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422843002 Cr-Commit-Position: refs/heads/master@{#425754} [modify] https://crrev.com/e0abdc20ecc4456af20381bdb5578129f96f70e4/storage/browser/database/database_tracker.cc [modify] https://crrev.com/e0abdc20ecc4456af20381bdb5578129f96f70e4/storage/browser/quota/special_storage_policy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2cfa7df4977e2ebc4911fa611ef9ef79e4a04a2 commit a2cfa7df4977e2ebc4911fa611ef9ef79e4a04a2 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:48:06 2016 Remove usage of FOR_EACH_OBSERVER macro in jingle Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2419693006 Cr-Commit-Position: refs/heads/master@{#425755} [modify] https://crrev.com/a2cfa7df4977e2ebc4911fa611ef9ef79e4a04a2/jingle/notifier/listener/fake_push_client.cc [modify] https://crrev.com/a2cfa7df4977e2ebc4911fa611ef9ef79e4a04a2/jingle/notifier/listener/non_blocking_push_client.cc [modify] https://crrev.com/a2cfa7df4977e2ebc4911fa611ef9ef79e4a04a2/jingle/notifier/listener/xmpp_push_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3227eb557cf28256df2764c6149d0178ea9d17c7 commit 3227eb557cf28256df2764c6149d0178ea9d17c7 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 19:53:54 2016 Remove usage of FOR_EACH_OBSERVER macro in google_apis Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422843003 Cr-Commit-Position: refs/heads/master@{#425758} [modify] https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7/google_apis/drive/auth_service.cc [modify] https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7/google_apis/gaia/account_tracker.cc [modify] https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7/google_apis/gaia/identity_provider.cc [modify] https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7/google_apis/gaia/oauth2_token_service.cc [modify] https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7/google_apis/gaia/oauth2_token_service_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08199f18817ec5b16b50946cecd40739561bfb01 commit 08199f18817ec5b16b50946cecd40739561bfb01 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 20:33:28 2016 Remove usage of FOR_EACH_OBSERVER macro in blimp Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2425493002 Cr-Commit-Position: refs/heads/master@{#425768} [modify] https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01/blimp/client/core/contents/blimp_contents_impl.cc [modify] https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01/blimp/client/core/session/connection_status.cc [modify] https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01/blimp/engine/app/settings_manager.cc [modify] https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01/blimp/engine/app/ui/blimp_screen.cc [modify] https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01/blimp/net/blimp_connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c729e8d010011dde4608d7c177ab227ac9d203b commit 1c729e8d010011dde4608d7c177ab227ac9d203b Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 22:40:04 2016 Remove usage of FOR_EACH_OBSERVER macro in remoting Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2425483002 Cr-Commit-Position: refs/heads/master@{#425796} [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/host/chromoting_host.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/host/daemon_process.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/protocol/webrtc_audio_source_adapter.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/signaling/delegating_signal_strategy.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/signaling/fake_signal_strategy.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/signaling/xmpp_signal_strategy.cc [modify] https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b/remoting/test/test_chromoting_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0 commit d1e2815e0685cff01fabe8a34c45ece45ef2d4b0 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 22:53:14 2016 Reduce FOR_EACH_OBSERVER usage in extensions Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2424593002 Cr-Commit-Position: refs/heads/master@{#425800} [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/api/audio/audio_service_chromeos.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/api/display_source/display_source_apitestbase.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/api/networking_private/networking_private_linux.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/api/networking_private/networking_private_service_client.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/app_window/app_window_geometry_cache.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/app_window/app_window_registry.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/extension_host.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/extension_icon_image.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/extension_pref_value_map.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/extension_prefs.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/extension_registry.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/process_manager.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/script_executor.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/user_script_loader.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/browser/warning_service.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/components/native_app_window/native_app_window_views.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/renderer/user_script_set.cc [modify] https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0/extensions/renderer/user_script_set_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01080f9de6ea0553025c24725219823e911c6aa5 commit 01080f9de6ea0553025c24725219823e911c6aa5 Author: ericwilligers <ericwilligers@chromium.org> Date: Mon Oct 17 22:55:09 2016 Remove usage of FOR_EACH_OBSERVER macro in apps/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422543002 Cr-Commit-Position: refs/heads/master@{#425802} [modify] https://crrev.com/01080f9de6ea0553025c24725219823e911c6aa5/apps/app_lifetime_monitor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b11c071cc39ba3f1cddf28447f3107cff9f55c25 commit b11c071cc39ba3f1cddf28447f3107cff9f55c25 Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 00:24:41 2016 Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2423563003 Cr-Commit-Position: refs/heads/master@{#425830} [modify] https://crrev.com/b11c071cc39ba3f1cddf28447f3107cff9f55c25/media/audio/audio_manager_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043 commit 9d64a5f4c772200ddf5b7070e5a4c9d49e29a043 Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 00:28:49 2016 Remove usage of FOR_EACH_OBSERVER macro in net Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2423713002 Cr-Commit-Position: refs/heads/master@{#425832} [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/base/sdch_manager.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/cert/sth_distributor.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/dns/mdns_client_impl.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/log/net_log.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/nqe/network_quality_store.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/proxy/polling_proxy_config_service.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/proxy/proxy_config_service_android.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/proxy/proxy_config_service_linux.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/proxy/proxy_config_service_mac.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/proxy/proxy_service_unittest.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/ssl/ssl_config_service.cc [modify] https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043/net/url_request/url_request_context_getter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff4feda3274263980796e5d4862e6fc0bac414ed commit ff4feda3274263980796e5d4862e6fc0bac414ed Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 00:33:44 2016 Remove usage of FOR_EACH_OBSERVER macro in ios/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2420013005 Cr-Commit-Position: refs/heads/master@{#425835} [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/chrome/browser/browser_state/browser_state_info_cache.cc [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/chrome/browser/reading_list/reading_list_model.cc [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/chrome/browser/reading_list/reading_list_model_impl.cc [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/chrome/browser/signin/signin_manager_factory.cc [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/web/active_state_manager_impl.mm [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/web/web_state/global_web_state_event_tracker.mm [modify] https://crrev.com/ff4feda3274263980796e5d4862e6fc0bac414ed/ios/web/web_state/web_state_impl.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce commit 720393e91b2cfe204d8ceee35c9b0b4dad69d2ce Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 01:25:34 2016 Remove usage of FOR_EACH_OBSERVER macro in components/history Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2423813002 Cr-Commit-Position: refs/heads/master@{#425848} [modify] https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce/components/history/core/browser/history_backend.cc [modify] https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce/components/history/core/browser/history_service.cc [modify] https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce/components/history/core/browser/top_sites.cc [modify] https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce/components/history/core/browser/web_history_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a commit 7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 02:37:21 2016 Remove usage of FOR_EACH_OBSERVER macro in components/sync Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2424673002 Cr-Commit-Position: refs/heads/master@{#425864} [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/base/sync_prefs.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/device_info/device_info_service.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/device_info/device_info_sync_service.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/driver/backend_migrator.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/driver/generic_change_processor.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/driver/sync_error_controller.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/engine_impl/cycle/directory_type_debug_info_emitter.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/engine_impl/cycle/sync_cycle.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/engine_impl/net/server_connection_manager.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/engine_impl/sync_scheduler_impl.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/js/sync_js_controller.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/test/fake_server/fake_server.cc [modify] https://crrev.com/7e4a453ea003a8d7fe6ad74ca0fbf2890a57ed8a/components/sync/test/fake_sync_encryption_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd commit 9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 18 03:18:45 2016 Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2424853003 Cr-Commit-Position: refs/heads/master@{#425881} [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ash/app_sync_ui_state.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ash/cast_config_delegate_media_router.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ash/session_state_delegate_chromeos.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/browser_list.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/ime/ime_window.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/libgtk2ui/gtk2_ui.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/search/search_model.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/settings_window_manager.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/toolbar/toolbar_actions_model.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/frame/browser_view_layout.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/frame/immersive_mode_controller.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/website_settings/chosen_object_row.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/views/website_settings/permission_selector_row.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/media_router/query_result_manager.cc [modify] https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd/chrome/browser/ui/webui/signin/login_ui_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b2ea16259b449afdc068feffcbe6d59df6fb39a commit 7b2ea16259b449afdc068feffcbe6d59df6fb39a Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 00:07:18 2016 Reduce usage of FOR_EACH_OBSERVER macro in components/invalidation Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2427913002 Cr-Commit-Position: refs/heads/master@{#426096} [modify] https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a/components/invalidation/impl/invalidation_logger.cc [modify] https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a/components/invalidation/impl/invalidator_registrar.cc [modify] https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a/components/invalidation/impl/sync_system_resources.cc [modify] https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a/components/invalidation/impl/ticl_settings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44bb427594f2418304cd165861f34e1faa060a08 commit 44bb427594f2418304cd165861f34e1faa060a08 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 00:15:24 2016 Reduce FOR_EACH_OBSERVER usage in ui/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2422073002 Cr-Commit-Position: refs/heads/master@{#426098} [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/android/window_android.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/aura/env.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/aura/test/test_cursor_client.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/aura/test/test_focus_client.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/aura/window.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/aura/window_tree_host.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/clipboard/clipboard_monitor.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/ime/chromeos/ime_keyboard.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/ime/input_method_base.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/ime/mock_input_method.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/user_activity/user_activity_detector.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/base/win/osk_display_manager.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/chromeos/ime/candidate_window_view.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/chromeos/ime/input_method_menu_manager.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/chromeos/network/network_icon_animation.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/display/chromeos/display_configurator.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/display/chromeos/x11/native_display_delegate_x11.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/display/display_change_notifier.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/display/display_list.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/display/fake_display_delegate.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/events/devices/device_data_manager.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/events/ozone/device/device_manager_manual.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/events/ozone/device/udev/device_manager_udev.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/events/platform/platform_event_source.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/gfx/sys_color_change_listener.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/gfx/win/singleton_hwnd.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/gl/gpu_switching_manager.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/native_theme/native_theme.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/ozone/platform/drm/host/drm_native_display_delegate.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/ozone/platform/drm/mus_thread_proxy.cc [modify] https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08/ui/snapshot/screenshot_grabber.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff2af33b552b7a319cc81cb26906064578182458 commit ff2af33b552b7a319cc81cb26906064578182458 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 00:16:50 2016 Reduce usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2430823002 Cr-Commit-Position: refs/heads/master@{#426099} [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/renderer_context_menu/render_view_context_menu_base.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/search_engines/template_url_service.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/search_provider_logos/logo_tracker.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/sessions/core/tab_restore_service_helper.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/syncable_prefs/pref_model_associator.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/syncable_prefs/pref_service_syncable.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/undo/undo_manager.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/update_client/update_client.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/user_prefs/tracked/segregated_pref_store.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/variations/service/variations_service.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/wallpaper/wallpaper_manager_base.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/wallpaper/wallpaper_resizer.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/zoom/zoom_controller.cc [modify] https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458/components/zoom/zoom_event_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98f5411faa0c4ab9993073664ac05feda1fd03d5 commit 98f5411faa0c4ab9993073664ac05feda1fd03d5 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 00:30:10 2016 Remove usage of FOR_EACH_OBSERVER macro in device/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2423793002 Cr-Commit-Position: refs/heads/master@{#426104} [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluetooth_adapter.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluetooth_adapter_android.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluetooth_adapter_mac.mm [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluetooth_adapter_win.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluetooth_task_manager_win.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluez/bluetooth_adapter_bluez.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/bluez/bluetooth_advertisement_bluez.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_adapter_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_device_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_gatt_service_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_input_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_le_advertising_manager_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_media_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/bluetooth_media_transport_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_adapter_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_device_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_gatt_service_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_input_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_media_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/bluetooth/test/mock_bluetooth_gatt_notify_session.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/generic_sensor/platform_sensor.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/hid/hid_service.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/hid/input_service_linux.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/media_transfer_protocol/media_transfer_protocol_manager.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/usb/usb_device.cc [modify] https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5/device/usb/usb_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9d3ea15202868716617ceb73ee8d5595778d504 commit d9d3ea15202868716617ceb73ee8d5595778d504 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 00:31:10 2016 Reduce FOR_EACH_OBSERVER macro usage in chrome/browser Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2426223002 Cr-Commit-Position: refs/heads/master@{#426105} [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/app_controller_mac.mm [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/background/background_application_list_model.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/background/background_contents.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/command_updater.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media/android/router/media_router_android.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media/router/issue_manager.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media/router/presentation_service_delegate_impl.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc [modify] https://crrev.com/d9d3ea15202868716617ceb73ee8d5595778d504/chrome/browser/media_galleries/media_galleries_preferences.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc commit 2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc Author: tfarina <tfarina@chromium.org> Date: Wed Oct 19 01:44:31 2016 components/bookmarks: convert usage of FOR_EACH_OBSERVER macro ObserverList now supports range-based for loops and thus this can be used to iterate through a list of observers as the FOR_EACH_OBSERVER macro was deprecated. This patch was generated by the following command line: $ cd components/bookmarks $ perl -0777 -pi -e 's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for (\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq) And then manually inspected for line indentation fixes. BUG= 655021 TEST=components_unittests R=sky@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2425603005 Cr-Commit-Position: refs/heads/master@{#426113} [modify] https://crrev.com/2fa1d2fb3d6251ea8cbff3a34801d06f5c8c2abc/components/bookmarks/browser/bookmark_model.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe109cda61d666ccbc0c32f068a82284ff971872 commit fe109cda61d666ccbc0c32f068a82284ff971872 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 01:45:51 2016 Reduce usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2423353002 Cr-Commit-Position: refs/heads/master@{#426114} [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/connection.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/cryptauth/cryptauth_device_manager.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/cryptauth/mock_cryptauth_client.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/logging/log_buffer.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/messenger_impl.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/proximity_monitor_impl.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/remote_device_life_cycle_impl.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/proximity_auth/screenlock_bridge.cc [modify] https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872/components/user_manager/user_manager_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de3863410bd8a5d13537e0206f1630d5e36b295b commit de3863410bd8a5d13537e0206f1630d5e36b295b Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 02:35:09 2016 Reduce FOR_EACH_OBSERVER usage in content/browser/renderer_host Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2418143004 Cr-Commit-Position: refs/heads/master@{#426120} [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/renderer_host/text_input_manager.cc [modify] https://crrev.com/de3863410bd8a5d13537e0206f1630d5e36b295b/content/browser/web_contents/web_contents_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5f79de1c6d55f1831b31a8a51746cda178e2ab0 commit b5f79de1c6d55f1831b31a8a51746cda178e2ab0 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 04:15:10 2016 Remove FOR_EACH_OBSERVER macro usage in chrome/browser/extensions Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2422963002 Cr-Commit-Position: refs/heads/master@{#426132} [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/commands/command_service.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/content_settings/content_settings_store.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/dial/dial_service.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/extension_action/extension_action_api.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/identity/identity_api.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/api/mdns/dns_sd_registry.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/blacklist.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/error_console/error_console.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/extension_error_reporter.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/extension_management.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/extension_service.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/install_tracker.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/extensions/window_controller_list.cc [modify] https://crrev.com/b5f79de1c6d55f1831b31a8a51746cda178e2ab0/chrome/browser/profiles/profile_info_cache.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d04c9b0e175803d97a65465718096c2e07d376c commit 7d04c9b0e175803d97a65465718096c2e07d376c Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 12:29:58 2016 Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2423883005 Cr-Commit-Position: refs/heads/master@{#426158} [modify] https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc [modify] https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c/chrome/browser/android/data_usage/data_use_tab_model.cc [modify] https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c/chrome/browser/android/thumbnail/thumbnail_cache.cc [modify] https://crrev.com/7d04c9b0e175803d97a65465718096c2e07d376c/chrome/browser/browsing_data/cookies_tree_model.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b92b0593764170610e6f1f9009ad1f07c9eb713 commit 8b92b0593764170610e6f1f9009ad1f07c9eb713 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 19 22:21:58 2016 Remove FOR_EACH_OBSERVER macro usage in chrome/browser/supervised_user Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2438513002 Cr-Commit-Position: refs/heads/master@{#426307} [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/content_settings/tab_specific_content_settings.cc [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/plugins/plugin_installer.cc [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/supervised_user/supervised_user_pref_store.cc [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/supervised_user/supervised_user_service.cc [modify] https://crrev.com/8b92b0593764170610e6f1f9009ad1f07c9eb713/chrome/browser/supervised_user/supervised_user_url_filter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da4988bb37c6d17714361ce75d532debbfd8ea17 commit da4988bb37c6d17714361ce75d532debbfd8ea17 Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 21 02:26:48 2016 Remove usage of FOR_EACH_OBSERVER macro in components/translate Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2425603004 Cr-Commit-Position: refs/heads/master@{#426697} [modify] https://crrev.com/da4988bb37c6d17714361ce75d532debbfd8ea17/components/bubble/bubble_manager.cc [modify] https://crrev.com/da4988bb37c6d17714361ce75d532debbfd8ea17/components/translate/content/browser/content_translate_driver.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58b0e16aa06b1a90993d95b2730672174e3c818f commit 58b0e16aa06b1a90993d95b2730672174e3c818f Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 21 07:15:56 2016 Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser Observer lists now support range-based for loops. BUG= 655021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://chromiumcodereview.appspot.com/2439493002 Cr-Commit-Position: refs/heads/master@{#426745} [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/lifetime/keep_alive_registry.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/local_discovery/service_discovery_client_mdns.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/memory/tab_manager.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/notifications/message_center_settings_controller.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/prerender/prerender_contents.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/search/instant_service.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/task_manager/task_manager_interface.cc [modify] https://crrev.com/58b0e16aa06b1a90993d95b2730672174e3c818f/chrome/browser/win/enumerate_modules_model.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cc834266d6a53ac9ceca591e5463b937bef4b1a commit 2cc834266d6a53ac9ceca591e5463b937bef4b1a Author: ericwilligers <ericwilligers@chromium.org> Date: Fri Oct 21 11:43:46 2016 Remove usage of FOR_EACH_OBSERVER macro in headless domain_cc.template Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2427883003 Cr-Commit-Position: refs/heads/master@{#426771} [modify] https://crrev.com/2cc834266d6a53ac9ceca591e5463b937bef4b1a/headless/lib/browser/domain_cc.template
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbd511b8d0d428d569c8012532ba0c80240ad160 commit cbd511b8d0d428d569c8012532ba0c80240ad160 Author: ericwilligers <ericwilligers@chromium.org> Date: Sat Oct 22 02:19:37 2016 Reduce usage of FOR_EACH_OBSERVER macro in chrome/browser/signin Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://chromiumcodereview.appspot.com/2435533004 Cr-Commit-Position: refs/heads/master@{#426951} [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/download/download_history.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/signin/cross_device_promo.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/signin/signin_manager_factory.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/status_icons/status_icon.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/status_icons/status_icon_menu_model.cc [modify] https://crrev.com/cbd511b8d0d428d569c8012532ba0c80240ad160/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a22488d46eda64d30a93a3d75c1fb5e41b486a1d commit a22488d46eda64d30a93a3d75c1fb5e41b486a1d Author: ericwilligers <ericwilligers@chromium.org> Date: Tue Oct 25 01:20:57 2016 Remove usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG= 655021 Review-Url: https://codereview.chromium.org/2440303002 Cr-Commit-Position: refs/heads/master@{#427212} [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/content_settings/core/browser/content_settings_observable_provider.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/content_settings/core/browser/host_content_settings_map.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/cronet/android/cronet_in_memory_pref_store.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/data_usage/core/data_use_aggregator.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/dom_distiller/core/distilled_page_prefs.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/dom_distiller/core/dom_distiller_store.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/exo/surface.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/exo/wm_helper.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/favicon/core/favicon_driver.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/gcm_driver/gcm_driver_desktop.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/infobars/core/infobar_manager.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/metrics/leak_detector/leak_detector.cc [modify] https://crrev.com/a22488d46eda64d30a93a3d75c1fb5e41b486a1d/components/metrics/metrics_service.cc
I'll erase the macro in ./PRESUBMIT.py base/android/java/src/org/chromium/base/ObserverList.java base/observer_list.h base/observer_list_unittest.cc
Final CL: https://codereview.chromium.org/2451933003/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/802c2138162919a3602f4eb20feb3e4020b81438 commit 802c2138162919a3602f4eb20feb3e4020b81438 Author: loyso <loyso@chromium.org> Date: Wed Oct 26 07:13:06 2016 base: Erase unused FOR_EACH_OBSERVER macro. We use the range based for loop from now. BUG= 655021 Review-Url: https://codereview.chromium.org/2451933003 Cr-Commit-Position: refs/heads/master@{#427623} [modify] https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438/PRESUBMIT.py [modify] https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438/base/android/java/src/org/chromium/base/ObserverList.java [modify] https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438/base/observer_list.h [modify] https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438/base/observer_list_unittest.cc
Comment 1 by loyso@chromium.org
, Oct 12 2016