New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654998 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary focus is seen on first history item checkbox after clicking card title bar in chrome://history.

Reported by mni...@etouch.net, Oct 12 2016 
Version: 56.0.2887.0 731c9896052c3824ec4630a1461738ecbccb16b5-refs/heads/master@{#424315} (64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history
2. Now click on card title bar and observe the focus on checkbox of first history item.

Actual: Unnecessary focus is seen on first history item checkbox after clicking on card title bar for first instance.
Expected: Focus should not be seen on first history item checkbox after clicking on card title bar for first instance.

This is regression issue, broken in ‘M 55’ and will soon update other info
Good build : 55.0.2867.0
Bad build : 55.0.2868.0
Actual_video.mov
2.0 MB Download
Expected_video.mov
1.6 MB Download

Comment 1 by brajkumar@chromium.org, Oct 12 2016

Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2867.0(Revision: 419930).
Bad build: 55.0.2868.0 (Revision:420217).

You are probably looking for a change made after 419955 (known good), but no later than 419956 (first known bad).

CHANGELOG URL:
-----------------  https://chromium.googlesource.com/chromium/src/+log/eedb95b1a034bb392ed83e84ee690395a0db3e27..a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3

From the CL above, assigning the issue to the concern owner 

@calamity - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!

Comment 2 by brajkumar@chromium.org, Oct 19 2016 

Just to update the latest behavior of the bug, Issue is still observed on chrome latest Dev M56-56.0.2894.0.

calamity@ Could you please let us know is there any latest update available for this issue ? if it's related to your change, else feel free to reassign to the concerned Dev person.

Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc

commit a9c75fd281a6d46fb86d66518bcdf2f82bd932dc
Author: calamity <calamity@chromium.org>
Date: Tue Oct 25 06:36:41 2016

[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG= 654998 
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2420583003
Cr-Commit-Position: refs/heads/master@{#427288}

[modify] https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc/chrome/browser/resources/md_history/lazy_load.crisper.js

Comment 4 by calamity@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment