ppapi_nacl_tests_* sometimes non-deterministic |
|||
Issue descriptionBuild determinism will save on infrastructure utilization. Most of the build on Linux are deterministic but I sometimes see ppapi_nacl_tests_* are not. Since object files are the same, the difference should be caused by linking. https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Linux%20deterministic/builds/3955/steps/compare_build_artifacts/logs/stdio (snip) ppapi_nacl_tests_pnacl_newlib_x32_nonsfi.nexe: DIFFERENT (unexpected): different size: 1843300 != 2309272 ppapi_nacl_tests_pnacl_newlib_x64.nexe : DIFFERENT (unexpected): different size: 2541536 != 3007472 (snip) Equals: 605 Expected diffs: 0 Unexpected diffs: 2 Unexpected files with diffs: ppapi_nacl_tests_pnacl_newlib_x32_nonsfi.nexe ppapi_nacl_tests_pnacl_newlib_x64.nexe Checking ppapi_nacl_tests_pnacl_newlib_x32_nonsfi.nexe difference: (181 deps) Checking ppapi_nacl_tests_pnacl_newlib_x64.nexe difference: (181 deps) step returned non-zero exit code: 1 Note that the same issue has been solved in https://bugs.chromium.org/p/chromium/issues/detail?id=429358, but I guess this is somewhat regression.
,
Oct 12 2016
,
Oct 12 2016
Thanks Yoshisato. That's weird that the file differences are so large; 25% larger is really significant.
,
Nov 11 2016
Interesting thing is that entry shows the same file size difference in other failure case. https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Linux%20deterministic/builds/5255/steps/compare_build_artifacts/logs/stdio ppapi_nacl_tests_pnacl_newlib_x32_nonsfi.nexe : DIFFERENT (unexpected): different size: 1843300 != 2309272 https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Linux%20deterministic/builds/5228/steps/compare_build_artifacts/logs/stdio ppapi_nacl_tests_pnacl_newlib_x64.nexe : DIFFERENT (unexpected): different size: 3007472 != 2541536
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bae8cb9758e013af1fe31af033f13fa5d117355 commit 4bae8cb9758e013af1fe31af033f13fa5d117355 Author: yyanagisawa <yyanagisawa@chromium.org> Date: Fri Nov 11 16:53:44 2016 Also whitelist ppapi_nacl_tests_* on Linux. BUG= 654989 BUG= 330263 Review-Url: https://codereview.chromium.org/2496903002 Cr-Commit-Position: refs/heads/master@{#431579} [modify] https://crrev.com/4bae8cb9758e013af1fe31af033f13fa5d117355/tools/determinism/compare_build_artifacts.py
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7498c76194b55b499beaf3e27ef28bbea2ea80d commit a7498c76194b55b499beaf3e27ef28bbea2ea80d Author: yyanagisawa <yyanagisawa@chromium.org> Date: Fri Nov 11 16:58:56 2016 Output list of differences to JSON file. It might be easier to investigate the reason of non-deterministic build, if we keep binaries to somewhere. To do so, let me make caller to know list of differences via JSON file. BUG= 654989 Review-Url: https://codereview.chromium.org/2495783002 Cr-Commit-Position: refs/heads/master@{#431583} [modify] https://crrev.com/a7498c76194b55b499beaf3e27ef28bbea2ea80d/tools/determinism/compare_build_artifacts.py
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1557bb36a0031296459485eac2e8d074eb22385b commit 1557bb36a0031296459485eac2e8d074eb22385b Author: yyanagisawa <yyanagisawa@chromium.org> Date: Wed Nov 16 15:20:20 2016 Should open file with 'w' to write a file. BUG= 654989 Review-Url: https://codereview.chromium.org/2504903002 Cr-Commit-Position: refs/heads/master@{#432492} [modify] https://crrev.com/1557bb36a0031296459485eac2e8d074eb22385b/tools/determinism/compare_build_artifacts.py
,
Feb 3 2017
I do not see the difference recently. maybe the issue has been fixed???
,
Feb 3 2017
It is fairly possible.
,
Feb 6 2017
Ok, I will also remove this from whitelist.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da0042ab3daeba3a3c97421c114d9ea4003ce573 commit da0042ab3daeba3a3c97421c114d9ea4003ce573 Author: yyanagisawa <yyanagisawa@chromium.org> Date: Tue Feb 07 08:32:41 2017 ppapi_nacl_tests_* seems to be deterministic. BUG= 654989 Review-Url: https://codereview.chromium.org/2674123002 Cr-Commit-Position: refs/heads/master@{#448571} [modify] https://crrev.com/da0042ab3daeba3a3c97421c114d9ea4003ce573/tools/determinism/deterministic_build_whitelist.pyl |
|||
►
Sign in to add a comment |
|||
Comment 1 by yyanagisawa@chromium.org
, Oct 12 2016