New issue
Advanced search Search tips

Issue 654981 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Oct 2016
Cc:
js...@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Stop bundling roboto font on Android

Project Member Reported by agrieve@chromium.org, Oct 12 2016 
resource_sizes.py shows:
                    IDR_WEBUI_ROBOTO_ROBOTO_MEDIUM_WOFF2     1    62.31k   0.50%
                   IDR_WEBUI_ROBOTO_ROBOTO_REGULAR_WOFF2     1    61.94k   0.50%
                      IDR_WEBUI_ROBOTO_ROBOTO_BOLD_WOFF2     1    60.23k   0.48%

However, starting with Android 4.1 (the first version of JellyBean), Roboto is included by Android OS. It should be safe to just remove these fonts from the .pak.

Comment 2 by agrieve@chromium.org, Oct 12 2016 

Thanks for the pointers! Should make this easy to fix :).

Looks like we never actually define the "android" grit define :(.
https://cs.chromium.org/chromium/src/tools/grit/grit_rule.gni

Comment 4 by agrieve@chromium.org, Oct 12 2016 

-t doesn't actually add a define. If you add "-D android", then it works.

I'm saying this just by trying it out. I'm not actually sure what "-t" does, or if it's supposed to add a define.

Comment 5 by agrieve@chromium.org, Oct 13 2016

Status: Fixed (was: Available)

Comment 7 by js...@chromium.org, Oct 14 2016 

Glad that this was found and fixed. Like dbeam@, I thought Roboto had never been bundled with Android Chrome.
►

Sign in to add a comment