Touch scroll deprecation claims removal will be in M55 |
||||||||||
Issue descriptionOn Chrome 55 Touch on the 'touchstart' box in http://output.jsbin.com/kibaxu Open console See warning like: "Performing operations that require explicit user interaction on touchstart events is deprecated and will be removed in M55, around November 2016". Issue 611981 tracks making this change for M56. In the meantime I'd like to correct the warning to refer to M56 instead of M55.
,
Oct 12 2016
Requesting merge to M55 for this trivial warning message change.
,
Oct 13 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278 commit 33d95c3c0e29e1263bd81aacbbaa15906abdd278 Author: Rick Byers <rbyers@chromium.org> Date: Thu Oct 13 18:53:14 2016 Punt touch UGI deprecation to M56 BUG= 654978 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) Review URL: https://codereview.chromium.org/2412423003 . Cr-Commit-Position: refs/branch-heads/2883@{#93} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/33d95c3c0e29e1263bd81aacbbaa15906abdd278/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/33d95c3c0e29e1263bd81aacbbaa15906abdd278/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 13 2016
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606411c1b192126517b4bb47f70ec4f6cb950b7f commit 606411c1b192126517b4bb47f70ec4f6cb950b7f Author: johnme <johnme@chromium.org> Date: Fri Oct 14 14:12:17 2016 Revert of Punt touch UGI deprecation to M56 (patchset #1 id:1 of https://codereview.chromium.org/2412423003/ ) Reason for revert: This patch breaks compile on the branch, since the "M55" enum value is still used with dopplerWillBeRemoved (note that https://chromium.googlesource.com/chromium/src/+/9848564877f0057f4dcbc98bce061dfa17a9202c removes dopplerWillBeRemoved on master, but that patch is not on the branch) Original issue's description: > Punt touch UGI deprecation to M56 > > BUG= 654978 > > Review-Url: https://codereview.chromium.org/2408203004 > Cr-Commit-Position: refs/heads/master@{#424739} > (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) > > Committed: https://chromium.googlesource.com/chromium/src/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278 TBR=rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 654978 Review-Url: https://codereview.chromium.org/2419563004 Cr-Commit-Position: refs/branch-heads/2883@{#106} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/606411c1b192126517b4bb47f70ec4f6cb950b7f/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/606411c1b192126517b4bb47f70ec4f6cb950b7f/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 14 2016
Filed issue 656030 for the reason this couldn't be merged cleanly (sorry I didn't notice in advance!). I'll re-land a partial merge to avoid the issue for now without blocking on issue 656030 .
,
Oct 14 2016
Re-merged (along with a trivial fix for issue 656030 ), I'll watch the branch builders this time...
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 commit ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 Author: Rick Byers <rbyers@chromium.org> Date: Fri Oct 14 16:43:54 2016 Punt touch UGI and doppler deprecations to M56 Cherry pick and also update the doppler warning to M56 (which was removed from trunk already so can't be merged). BUG= 654978 , 656030 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) R=rtoy@chromium.org Review URL: https://codereview.chromium.org/2422673002 . Cr-Commit-Position: refs/branch-heads/2883@{#109} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 14 2016
Build passed: https://chromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/4854
,
Oct 14 2016
,
Oct 18 2016
Verified this issue on Windows-10 Dell M3800 using chrome latest Dev M55-55.0.2883.18 by following steps mentioned in the original comment. Observed the error in the console saying "Performing operations that require explicit user interaction on touchstart events is deprecated and will be removed in M56" as expected. Note: Unable to verify it on Mac and Linux due to lack of hardware available with HYD-TE team. Requesting some one from MTV team to verify it. Thanks!
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278 commit 33d95c3c0e29e1263bd81aacbbaa15906abdd278 Author: Rick Byers <rbyers@chromium.org> Date: Thu Oct 13 18:53:14 2016 Punt touch UGI deprecation to M56 BUG= 654978 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) Review URL: https://codereview.chromium.org/2412423003 . Cr-Commit-Position: refs/branch-heads/2883@{#93} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/33d95c3c0e29e1263bd81aacbbaa15906abdd278/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/33d95c3c0e29e1263bd81aacbbaa15906abdd278/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606411c1b192126517b4bb47f70ec4f6cb950b7f commit 606411c1b192126517b4bb47f70ec4f6cb950b7f Author: johnme <johnme@chromium.org> Date: Fri Oct 14 14:12:17 2016 Revert of Punt touch UGI deprecation to M56 (patchset #1 id:1 of https://codereview.chromium.org/2412423003/ ) Reason for revert: This patch breaks compile on the branch, since the "M55" enum value is still used with dopplerWillBeRemoved (note that https://chromium.googlesource.com/chromium/src/+/9848564877f0057f4dcbc98bce061dfa17a9202c removes dopplerWillBeRemoved on master, but that patch is not on the branch) Original issue's description: > Punt touch UGI deprecation to M56 > > BUG= 654978 > > Review-Url: https://codereview.chromium.org/2408203004 > Cr-Commit-Position: refs/heads/master@{#424739} > (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) > > Committed: https://chromium.googlesource.com/chromium/src/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278 TBR=rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 654978 Review-Url: https://codereview.chromium.org/2419563004 Cr-Commit-Position: refs/branch-heads/2883@{#106} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/606411c1b192126517b4bb47f70ec4f6cb950b7f/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/606411c1b192126517b4bb47f70ec4f6cb950b7f/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 commit ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 Author: Rick Byers <rbyers@chromium.org> Date: Fri Oct 14 16:43:54 2016 Punt touch UGI and doppler deprecations to M56 Cherry pick and also update the doppler warning to M56 (which was removed from trunk already so can't be merged). BUG= 654978 , 656030 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) R=rtoy@chromium.org Review URL: https://codereview.chromium.org/2422673002 . Cr-Commit-Position: refs/branch-heads/2883@{#109} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 12 2016